Skip to content

Problem with HTML parsing #54

@amenk

Description

@amenk

We have the following HTML

<!--Authentication Pop-Up-->
</div></header><div x-data="initHeaderNavigation()"
 x-init="$watch('activeSubmenuId', value => activateSubmenuMobile(value))"

The module inserts the hint like this

<!--Authentication Pop-Up-->
</div></header><div x-data="initHeaderNavigation()"
 x-init="$watch('activeSubmenuId', value = data-ho-hinttype="block" ....
 @menu-back.window="back"
 class="relative z-50 font-bold bg-gray-200 lg:block lg:z-40"

Reason: We should not parse HTML with regex https://github.com/ho-nl/magento2-Ho_Templatehints/blob/master/Plugin/View/LayoutPlugin.php#L117

Related to Hyvä, because we use Alpine JS there and these notations are common

https://gitlab.hyva.io/hyva-themes/hyva-compat/magento2-ho-templatehints/-/issues/2

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions