Skip to content

Very noisy output when port is already free #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kibertoad opened this issue Nov 28, 2023 · 3 comments · May be fixed by #162
Open

Very noisy output when port is already free #97

kibertoad opened this issue Nov 28, 2023 · 3 comments · May be fixed by #162
Assignees
@hilleer

Comments

@kibertoad
Copy link

Currently I'm getting this kind of errors when there is nothing to be killed:

Failed to get pid of port 3011 Error: Couldn't find a process with port `3011`
    at getPort (C:\sources\node\autopilot\node_modules\pid-from-port\index.js:29:9)
    at C:\sources\node\autopilot\node_modules\pid-from-port\index.js:51:32
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

This is way too much noise. Simple one-liner saying that port wasn't busy to begin with would suffice. Would it be possible to either add a quiet mode for "not found" error, or some ways to customize errors thrown?
@hilleer hilleer self-assigned this Nov 29, 2023
@hilleer
Copy link
Owner

hilleer commented Jan 8, 2025 •
edited
Loading

Hi @kibertoad

I never came back to improving this. How would a flag like --silent or --ignore-errors work for you?

@kibertoad
Copy link
Author

it would be great!

@hilleer hilleer linked a pull request Jan 8, 2025 that will close this issue
Open
@hilleer
Copy link
Owner

hilleer commented Jan 8, 2025

I published a new (beta) version 3.3.1-0 here.

Would be thankful if you can give it a try when you have time 🤞

@hilleer hilleer linked a pull request Jan 8, 2025 that will close this issue
Feat/silent-flag #162
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hilleer hilleer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat/silent-flag hilleer/kill-port-process
2 participants
@kibertoad @hilleer