Skip to content

Commit 36120f5

Browse files
committed
Downgrade Derby to 10.16 to be compatible with JDK 17 in tests
1 parent c304763 commit 36120f5

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

.github/dependabot.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,10 @@ updates:
111111
# we don't want always want to get the latest Weld version:
112112
- dependency-name: "org.jboss.weld.se:*"
113113
update-types: ["version-update:semver-major"]
114+
# Sticking to Derby 10.16 for now since later versions require JDK 21+, and we need to test with JDK 17.
115+
# See https://db.apache.org/derby/derby_downloads.html
116+
- dependency-name: "org.apache.derby:*"
117+
update-types: [ "version-update:semver-major", "version-update:semver-minor" ]
114118
# Sticking to SLF4J 1.x for now since later versions require to upgrade providers
115119
# (Log4j, ... see https://www.slf4j.org/faq.html#changesInVersion200),
116120
# and also because we only need this dependency for AWS SDK,

build/parents/build/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -158,9 +158,9 @@
158158

159159
<!-- >>> JDBC Drivers -->
160160
<version.com.h2database>2.3.232</version.com.h2database>
161-
<!-- Sticking to Derby 10.15 for now since later versions require JDK 17+, and we need to test with JDK 11.
161+
<!-- Sticking to Derby 10.16 for now since later versions require JDK 21+, and we need to test with JDK 17.
162162
See https://db.apache.org/derby/derby_downloads.html -->
163-
<version.org.apache.derby>10.17.1.0</version.org.apache.derby>
163+
<version.org.apache.derby>10.16.1.1</version.org.apache.derby>
164164
<version.org.postgresql>42.7.7</version.org.postgresql>
165165
<version.org.mariadb.jdbc>3.5.3</version.org.mariadb.jdbc>
166166
<version.mysql.mysql-connector-j>9.3.0</version.mysql.mysql-connector-j>

pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -209,6 +209,7 @@
209209
<!-- The lowest supported version of Java for applications using Hibernate Search -->
210210
<!-- Set statically, independently from the current JDK: we want our code to comply with this version -->
211211
<!-- Adjust the contributing guide when changing the release Java version -->
212+
<!-- Once upgrading review the dependency list to see if any major versions can be updated e.g. Derby 10.17 requires JDK 21 (see dependabot config and comments in POMs). -->
212213
<java-version.main.release>17</java-version.main.release>
213214
<java-version.main.compiler.java_home>${java.home}</java-version.main.compiler.java_home>
214215
<java-version.main.compiler>${java-version.main.compiler.java_home}/bin/javac</java-version.main.compiler>

0 commit comments

Comments
 (0)