Make the illegal pop message more user friendly

[DavideD]

Users can sometime see this error:

org.hibernate.HibernateException: java.util.concurrent.CompletionException: java.lang.IllegalStateException: Illegal pop() with non-matching JdbcValuesSourceProcessingState

Usually, when they are sharing the session in different streams.
We could add some info to the error message.

[DavideD]

Hibernate ORM is generating this error. I've created an issue for it: https://hibernate.atlassian.net/browse/HHH-16869

[prashantguleria]

Hi were you able to find any workaround related to this issue?

[DavideD]

What do you mean?
This error means that the session is not used correctly. The user needs to change something.

This issue refers only to the error message

[prashantguleria]

Ohh Alright, I have started getting this exception intermittently when using hibernate 6.2.2.
I am still unable to find how it's happening because it's occurring once in > 1000 executions.

[DavideD]

It happens when the same session instance is used in parallel by different threads or different CompletionStage or Uni.

[DavideD]

Well... I guess it could also be a bug. In any case we would need to see some code to be able to help.
Feel free to create a separate issue with more details.

[prashantguleria]

Well... I guess it could also be a bug. In any case we would need to see some code to be able to help. Feel free to create a separate issue with more details.

Hi I have created this issue.

https://hibernate.atlassian.net/browse/HHH-16903

Can you please have a look into it?

[noobgramming]

I've run into this error as well. Reproduces on my system(Using Mutiny.SessionFactory):

final var result = sessionFactory
        .withTransaction(session -> {
             Uni.combine()
                        .all()
                        .unis(session.find(Item1.class, id),  session.find(Item2.class, id2))
                        .asTuple();
            }).await().indefinitely();

I know that this is a perfect example of what NOT to do in Hibernate Reactive 😊, but the error message could be a lot friendlier.

[DavideD]

This is an error thrown by Hibernate ORM. I've opened an issue some time ago about it: https://hibernate.atlassian.net/browse/HHH-16869

In short, this is not the only situation where this message is thrown and this is the best that can be done at the moment.
I'm going to close this issue, eventually we might be able to solve the issue by not having to throw the error in the first place.

[wutzebaer]

happend to me while using parallel streams... when i tested allone everything worked well.... but then there were two testers at the same time ^^

[dcaillia]

I had this case: using 6.2.18.Final

entity X.getY() relates OneToOne to entity Y
Y has a String property z with a setter that throws exception of you Y.setZ(null)
The database happened to have Y's with z=null

Then "SELECT x from X x" fails with this "illegal pop() with non-matching JdbcValuesSourceProcessingState"

The actual problem (that setZ throwed some Exception) was not logged or present in the stacktrace at all.

So it appears, then hibernate n+1-loads the Y's after having loaded a list of X'es, when calling X.setZ(null) throws exception, this exception gets swallowed, and eventually "illegal pop() with non-matching JdbcValuesSourceProcessingState" is thrown instead.