[#709] Fix call to non reactive delete method

When setting an association with orphan removal
to null we should call the reavtive delete.

Author: DavideD

hibernate-reactive-core/src/main/java/org/hibernate/reactive/engine/impl/Cascade.java

@@ -34,7 +34,6 @@
 
 import java.util.Collection;
 import java.util.Collections;
-import java.util.HashSet;
 import java.util.Iterator;
 import java.util.concurrent.CompletionStage;
 
@@ -350,19 +349,20 @@ private void cascadeLogicalOneToOneOrphanRemoval(
 								);
 							}
 
+							final Object loaded = loadedValue;
 							if ( type.isAssociationType()
 									&& ( (AssociationType) type ).getForeignKeyDirection()
 											.equals(ForeignKeyDirection.TO_PARENT) ) {
 								// If FK direction is to-parent, we must remove the orphan *before* the queued update(s)
 								// occur.  Otherwise, replacing the association on a managed entity, without manually
 								// nulling and flushing, causes FK constraint violations.
-								ReactiveSession session = (ReactiveSession) eventSource;
-								final Object finalLoadedValue = loadedValue;
-								stage = stage.thenCompose( v -> session.reactiveRemoveOrphanBeforeUpdates( entityName, finalLoadedValue ) );
+								stage = stage.thenCompose( v -> ( (ReactiveSession) eventSource )
+										.reactiveRemoveOrphanBeforeUpdates( entityName, loaded ) );
 							}
 							else {
 								// Else, we must delete after the updates.
-								eventSource.delete( entityName, loadedValue, isCascadeDeleteEnabled, new HashSet<>() );
+								stage = stage.thenCompose( v -> ( (ReactiveSession) eventSource )
+										.reactiveRemove( entityName, loaded, isCascadeDeleteEnabled, new IdentitySet() ) );
 							}
 						}
 					}

hibernate-reactive-core/src/main/java/org/hibernate/reactive/session/ReactiveSession.java

@@ -60,6 +60,8 @@ public interface ReactiveSession extends ReactiveQueryExecutor {
 
 	CompletionStage<Void> reactiveRemove(Object entity, boolean isCascadeDeleteEnabled, IdentitySet transientObjects);
 
+	CompletionStage<Void> reactiveRemove(String entityName, Object child, boolean isCascadeDeleteEnabled, IdentitySet transientEntities);
+
 	<T> CompletionStage<T> reactiveMerge(T object);
 
 	CompletionStage<Void> reactiveMerge(Object object, MergeContext copiedAlready);

hibernate-reactive-core/src/main/java/org/hibernate/reactive/session/impl/ReactiveSessionImpl.java

@@ -741,7 +741,24 @@ public CompletionStage<Void> reactiveRemove(Object object, boolean isCascadeDele
 						null,
 						object,
 						isCascadeDeleteEnabled,
-						((ReactivePersistenceContextAdapter) getPersistenceContextInternal())
+						( (ReactivePersistenceContextAdapter) getPersistenceContextInternal() )
+								.isRemovingOrphanBeforeUpates(),
+						this
+				),
+				transientEntities
+		);
+	}
+
+	@Override
+	public CompletionStage<Void> reactiveRemove(String entityName, Object child, boolean isCascadeDeleteEnabled, IdentitySet transientEntities) {
+		checkOpenOrWaitingForAutoClose();
+
+		return fireRemove(
+				new DeleteEvent(
+						entityName,
+						child,
+						isCascadeDeleteEnabled,
+						( (ReactivePersistenceContextAdapter) getPersistenceContextInternal() )
 								.isRemovingOrphanBeforeUpates(),
 						this
 				),