Clean up potential code problems

From github-code-scanning

Author: DavideD

hibernate-reactive-core/src/main/java/org/hibernate/reactive/event/impl/DefaultReactiveDeleteEventListener.java

@@ -27,7 +27,6 @@
 import org.hibernate.event.spi.DeleteEvent;
 import org.hibernate.event.spi.DeleteEventListener;
 import org.hibernate.event.spi.EventSource;
-import org.hibernate.internal.util.collections.IdentitySet;
 import org.hibernate.jpa.event.spi.CallbackRegistry;
 import org.hibernate.jpa.event.spi.CallbackRegistryConsumer;
 import org.hibernate.persister.entity.EntityPersister;
@@ -75,17 +74,17 @@ public void wasJpaBootstrap(boolean wasJpaBootstrap) {
 	@Deprecated
 	@Override
 	public void onDelete(DeleteEvent event) {
-		throw new UnsupportedOperationException("Use the reactive version instead: reactiveOnDelete(DeleteEvent)");
+		throw LOG.nonReactiveMethodCall( "reactiveOnDelete" );
 	}
 
 	/**
 	 * @deprecated only the reactive version is supported
-	 * @see #reactiveOnDelete(DeleteEvent, IdentitySet)
+	 * @see #reactiveOnDelete(DeleteEvent, DeleteContext)
 	 */
 	@Deprecated
 	@Override
 	public void onDelete(DeleteEvent event, DeleteContext transientEntities) throws HibernateException {
-		throw new UnsupportedOperationException("Use the reactive version instead: reactiveOnDelete(DeleteEvent, DeleteContext)");
+		throw LOG.nonReactiveMethodCall( "reactiveOnDelete" );
 	}
 
 	/**
@@ -94,6 +93,7 @@ public void onDelete(DeleteEvent event, DeleteContext transientEntities) throws
 	 * @param event The delete event to be handled.
 	 *
 	 */
+	@Override
 	public CompletionStage<Void> reactiveOnDelete(DeleteEvent event) throws HibernateException {
 		return reactiveOnDelete( event, DeleteContext.create() );
 	}
@@ -105,6 +105,7 @@ public CompletionStage<Void> reactiveOnDelete(DeleteEvent event) throws Hibernat
 	 * @param transientEntities The cache of entities already deleted
 	 *
 	 */
+	@Override
 	public CompletionStage<Void> reactiveOnDelete(DeleteEvent event, DeleteContext transientEntities) throws HibernateException {
 		EventSource source = event.getSession();
 		if ( event.getObject() instanceof CompletionStage ) {

hibernate-reactive-core/src/main/java/org/hibernate/reactive/id/impl/EmulatedSequenceReactiveIdentifierGenerator.java

@@ -70,27 +70,33 @@ protected int determineIncrement(Properties params) {
 		return getInt( SequenceStyleGenerator.INCREMENT_PARAM, params, SequenceStyleGenerator.DEFAULT_INCREMENT_SIZE );
 	}
 
+	@Override
 	protected Object[] updateParameters(long currentValue, long updatedValue) {
 		return new Object[] { updatedValue, currentValue };
 	}
 
+	@Override
 	protected Object[] insertParameters(long insertedValue) {
 		return new Object[] { insertedValue };
 	}
 
+	@Override
 	protected Object[] selectParameters() {
 		return new Object[] {};
 	}
 
+	@Override
 	protected String buildSelectQuery() {
 		return "select tbl." + valueColumnName + " from " + renderedTableName + " tbl";
 	}
 
+	@Override
 	protected String buildUpdateQuery() {
 		return "update " + renderedTableName + " set " + valueColumnName + "=?"
 				+ " where " + valueColumnName + "=?";
 	}
 
+	@Override
 	protected String buildInsertQuery() {
 		return "insert into " + renderedTableName + " (" + valueColumnName + ") "
 				+ " values (?)";

hibernate-reactive-core/src/main/java/org/hibernate/reactive/loader/ast/internal/ReactiveSingleIdEntityLoaderStandardImpl.java

@@ -38,6 +38,7 @@ public class ReactiveSingleIdEntityLoaderStandardImpl<T> extends SingleIdEntityL
 
 	private AtomicInteger nonReusablePlansGenerated = new AtomicInteger();
 
+	@Override
 	public AtomicInteger getNonReusablePlansGenerated() {
 		return nonReusablePlansGenerated;
 	}
@@ -46,15 +47,12 @@ public AtomicInteger getNonReusablePlansGenerated() {
 
 	private final EntityMappingType entityDescriptor;
 
-	protected final SessionFactoryImplementor sessionFactory;
-
 	public ReactiveSingleIdEntityLoaderStandardImpl(
 			EntityMappingType entityDescriptor,
 			SessionFactoryImplementor sessionFactory) {
 		super( entityDescriptor, sessionFactory );
 		// todo (6.0) : consider creating a base AST and "cloning" it
 		this.entityDescriptor = entityDescriptor;
-		this.sessionFactory = sessionFactory;
 	}
 
 	@Override
@@ -127,6 +125,7 @@ public CompletionStage<T> load(
 	}
 
 	@Internal
+	@Override
 	public ReactiveSingleIdLoadPlan<T> resolveLoadPlan(
 			LockOptions lockOptions,
 			LoadQueryInfluencers loadQueryInfluencers,