Skip to content

Commit 7a7565b

Browse files
geoandDavideD
authored andcommitted
Update CachedQueryResultsGenerateStatisticsTest to match ORM tests
Hibernate ORM statistics test don't test Criteria queries (which don't seem to update statistics) and they also only test the statistics for query creation, not query execution
1 parent 0950278 commit 7a7565b

File tree

1 file changed

+12
-9
lines changed

1 file changed

+12
-9
lines changed

hibernate-reactive-core/src/test/java/org/hibernate/reactive/CachedQueryResultsGenerateStatisticsTest.java

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -6,19 +6,17 @@
66
package org.hibernate.reactive;
77

88

9+
import io.smallrye.mutiny.Uni;
10+
import io.vertx.ext.unit.TestContext;
911
import org.hibernate.cfg.AvailableSettings;
1012
import org.hibernate.cfg.Configuration;
1113
import org.hibernate.cfg.Environment;
14+
import org.hibernate.reactive.mutiny.Mutiny;
1215
import org.hibernate.reactive.provider.Settings;
13-
1416
import org.junit.Test;
1517

16-
import io.vertx.ext.unit.TestContext;
17-
1818
/**
1919
* Checks the # of cache hits when the configuration property Settings.GENERATE_STATISTICS is set to TRUE
20-
*
21-
* @see CachedQueryResultsTest#testQueryPlanCacheHitsGenerateStatisticsFalse(TestContext)
2220
*/
2321
public class CachedQueryResultsGenerateStatisticsTest extends BaseReactiveTest {
2422

@@ -38,10 +36,15 @@ protected Configuration constructConfiguration() {
3836

3937
@Test
4038
public void testQueryPlanCacheHitsWithGenerateStatisticsTrue(TestContext context) {
41-
test( context, CachedQueryResultsTest.criteriaFindAll()
42-
.call( CachedQueryResultsTest::criteriaFindAll )
43-
.call( CachedQueryResultsTest::criteriaFindAll )
44-
.invoke( () -> context.assertEquals( 2L, CachedQueryResultsTest.statistics().getQueryPlanCacheHitCount() ) )
39+
test( context, CachedQueryResultsGenerateStatisticsTest.createFindAllWithNamedQuery()
40+
.call( CachedQueryResultsGenerateStatisticsTest::createFindAllWithNamedQuery)
41+
.call( CachedQueryResultsGenerateStatisticsTest::createFindAllWithNamedQuery)
42+
.invoke( () -> context.assertEquals( 3L, CachedQueryResultsTest.statistics().getQueryPlanCacheHitCount() ) )
4543
);
4644
}
45+
46+
private static Uni<Mutiny.Query<CachedQueryResultsTest.Fruit>> createFindAllWithNamedQuery() {
47+
return getMutinySessionFactory().withSession(s -> Uni.createFrom().item(s.createNamedQuery( CachedQueryResultsTest.Fruit.FIND_ALL, CachedQueryResultsTest.Fruit.class ) ));
48+
}
49+
4750
}

0 commit comments

Comments
 (0)