Skip to content

Commit 28c5069

Browse files
committed
[#1609] Re-enable tests for MSSQL
After the upgrade to Vert.x 4.4.2, these tests work for MSSQL: * MultithreadedIdentityGenerationTest * MultithreadedInsertionTest Because before we couldn't use the correct dialect. See #1596
1 parent 797bfbc commit 28c5069

File tree

2 files changed

+0
-6
lines changed

2 files changed

+0
-6
lines changed

hibernate-reactive-core/src/test/java/org/hibernate/reactive/MultithreadedIdentityGenerationTest.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -86,9 +86,6 @@ public class MultithreadedIdentityGenerationTest {
8686
private static Vertx vertx;
8787
private static SessionFactory sessionFactory;
8888

89-
@Rule // Currently failing for unrelated reasons on SQL Server https://github.com/hibernate/hibernate-reactive/issues/1609
90-
public DatabaseSelectionRule dbRule = DatabaseSelectionRule.skipTestsFor( SQLSERVER );
91-
9289
@BeforeClass
9390
public static void setupSessionFactory() {
9491
final VertxOptions vertxOptions = new VertxOptions();

hibernate-reactive-core/src/test/java/org/hibernate/reactive/MultithreadedInsertionTest.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,6 @@
6767
@RunWith(VertxUnitRunner.class)
6868
public class MultithreadedInsertionTest {
6969

70-
@Rule // Currently failing for unrelated reasons on SQL Server https://github.com/hibernate/hibernate-reactive/issues/1609
71-
public DatabaseSelectionRule dbRule = DatabaseSelectionRule.skipTestsFor( SQLSERVER );
72-
7370
/**
7471
* The number of threads should be higher than the default size of the connection pool so that
7572
* this test is also effective in detecting problems with resource starvation.

0 commit comments

Comments
 (0)