Skip to content

Commit ed52201

Browse files
committed
HHH-19324 Fix DynamicTypingTests on hana_cloud and cockroachdb
1 parent f9164f2 commit ed52201

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

hibernate-core/src/test/java/org/hibernate/orm/test/boot/models/xml/dynamic/DynamicTypingTests.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -57,11 +57,11 @@ void testDynamicModelBasicTyping(DomainModelScope modelScope) {
5757
assertThat( entityBinding ).isNotNull();
5858

5959
verifyBasicAttribute( entityBinding, "theBoolean", BooleanJavaType.class, booleanJdbcType.getJdbcTypeCode() );
60-
verifyBasicAttribute( entityBinding, "theString", StringJavaType.class, SqlTypes.VARCHAR );
60+
verifyBasicAttribute( entityBinding, "theString", StringJavaType.class, SqlTypes.VARCHAR, /*HANA Cloud uses UTF8 by default*/ SqlTypes.NVARCHAR );
6161
verifyBasicAttribute( entityBinding, "theInt", IntegerJavaType.class, SqlTypes.INTEGER );
6262
verifyBasicAttribute( entityBinding, "theInteger", IntegerJavaType.class, SqlTypes.INTEGER );
6363
verifyBasicAttribute( entityBinding, "theUrl", UrlJavaType.class, SqlTypes.VARCHAR );
64-
verifyBasicAttribute( entityBinding, "theClob", ClobJavaType.class, SqlTypes.CLOB );
64+
verifyBasicAttribute( entityBinding, "theClob", ClobJavaType.class, SqlTypes.CLOB, /*CockroachDB doesn't support CLOBs*/ SqlTypes.VARCHAR );
6565
verifyBasicAttribute( entityBinding, "theInstant", InstantJavaType.class, SqlTypes.INSTANT );
6666
verifyBasicAttribute( entityBinding, "theDate", JdbcDateJavaType.class, SqlTypes.DATE );
6767
verifyBasicAttribute( entityBinding, "theTime", JdbcTimeJavaType.class, SqlTypes.TIME );
@@ -72,15 +72,15 @@ void testDynamicModelBasicTyping(DomainModelScope modelScope) {
7272
}
7373

7474

75-
private static void verifyBasicAttribute(RootClass rootClass, String attributeName, Class<? extends BasicJavaType<?>> expectedJavaType, int expectedJdbcTypeCode) {
75+
private static void verifyBasicAttribute(RootClass rootClass, String attributeName, Class<? extends BasicJavaType<?>> expectedJavaType, int... expectedJdbcTypeCodes) {
7676
final Property attribute = rootClass.getProperty( attributeName );
7777
assertThat( attribute.getType() ).isInstanceOf( BasicType.class );
78-
verifyBasicMapping( (BasicType<?>) attribute.getType(), expectedJavaType, expectedJdbcTypeCode );
78+
verifyBasicMapping( (BasicType<?>) attribute.getType(), expectedJavaType, expectedJdbcTypeCodes );
7979
}
8080

81-
private static void verifyBasicMapping(BasicType<?> type, Class<? extends BasicJavaType<?>> expectedJavaType, int expectedJdbcTypeCode) {
81+
private static void verifyBasicMapping(BasicType<?> type, Class<? extends BasicJavaType<?>> expectedJavaType, int... expectedJdbcTypeCodes) {
8282
assertThat( type.getJavaTypeDescriptor().getClass() ).isEqualTo( expectedJavaType );
83-
assertThat( type.getJdbcType().getJdbcTypeCode() ).isEqualTo( expectedJdbcTypeCode );
83+
assertThat( expectedJdbcTypeCodes ).contains( type.getJdbcType().getJdbcTypeCode() );
8484
}
8585

8686
private static void verifyElementCollection(RootClass rootClass, String name, Class<? extends BasicJavaType<?>> expectedJavaType, int expectedJdbcTypeCode) {

0 commit comments

Comments
 (0)