#99 - Recursive annotations lead to StackOverflowError

Author: sebersole

hibernate-models-jandex/src/test/java/org/hibernate/models/annotations/AnnotationCycleTests.java

@@ -0,0 +1,70 @@
+/*
+ * SPDX-License-Identifier: Apache-2.0
+ * Copyright: Red Hat Inc. and Hibernate Authors
+ */
+package org.hibernate.models.annotations;
+
+import java.lang.annotation.ElementType;
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+import java.lang.annotation.Target;
+
+import org.hibernate.models.spi.AnnotationDescriptor;
+import org.hibernate.models.spi.AnnotationDescriptorRegistry;
+import org.hibernate.models.spi.ClassDetails;
+import org.hibernate.models.spi.ClassDetailsRegistry;
+import org.hibernate.models.spi.SourceModelBuildingContext;
+
+import org.junit.jupiter.api.Test;
+
+import org.jboss.jandex.Index;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.hibernate.models.SourceModelTestHelper.buildJandexIndex;
+import static org.hibernate.models.SourceModelTestHelper.createBuildingContext;
+
+/**
+ * @author Steve Ebersole
+ */
+public class AnnotationCycleTests {
+	@Test
+	void testWithJandex() {
+		testAnnotationCycle( buildJandexIndex( SelfReferenceTests.SimpleClass.class ) );
+	}
+
+	@Test
+	void testWithoutJandex() {
+		testAnnotationCycle( null );
+	}
+
+	private void testAnnotationCycle(Index jandexIndex) {
+		final SourceModelBuildingContext buildingContext = createBuildingContext( jandexIndex, SimpleClass.class );
+		final ClassDetailsRegistry classDetailsRegistry = buildingContext.getClassDetailsRegistry();
+		final AnnotationDescriptorRegistry descriptorRegistry = buildingContext.getAnnotationDescriptorRegistry();
+
+		final ClassDetails classDetails = classDetailsRegistry.getClassDetails( SimpleClass.class.getName() );
+		assertThat( classDetails.hasDirectAnnotationUsage( A.class ) ).isTrue();
+		assertThat( classDetails.hasDirectAnnotationUsage( B.class ) ).isTrue();
+
+		final AnnotationDescriptor<A> aDescriptor = descriptorRegistry.getDescriptor( A.class );
+		final AnnotationDescriptor<B> bDescriptor = descriptorRegistry.getDescriptor( B.class );
+		assertThat( aDescriptor.hasDirectAnnotationUsage( B.class ) ).isTrue();
+		assertThat( bDescriptor.hasDirectAnnotationUsage( A.class ) ).isTrue();
+	}
+
+	@B
+	@Retention(RetentionPolicy.RUNTIME)
+	@Target(ElementType.TYPE)
+	public @interface A {
+	}
+
+	@A
+	@Retention(RetentionPolicy.RUNTIME)
+	@Target(ElementType.TYPE)
+	public @interface B {
+	}
+
+	@A @B
+	public static class SimpleClass {
+	}
+}

hibernate-models-jandex/src/test/java/org/hibernate/models/annotations/SelfReferenceTests.java

@@ -0,0 +1,52 @@
+/*
+ * SPDX-License-Identifier: Apache-2.0
+ * Copyright: Red Hat Inc. and Hibernate Authors
+ */
+package org.hibernate.models.annotations;
+
+import org.hibernate.models.spi.AnnotationDescriptor;
+import org.hibernate.models.spi.AnnotationDescriptorRegistry;
+import org.hibernate.models.spi.ClassDetails;
+import org.hibernate.models.spi.ClassDetailsRegistry;
+import org.hibernate.models.spi.SourceModelBuildingContext;
+
+import org.junit.jupiter.api.Test;
+
+import org.jboss.jandex.IndexView;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.hibernate.models.SourceModelTestHelper.buildJandexIndex;
+import static org.hibernate.models.SourceModelTestHelper.createBuildingContext;
+
+/**
+ * Tests for annotations that use themselves
+ *
+ * @author Steve Ebersole
+ */
+public class SelfReferenceTests {
+	@Test
+	void testWithJandex() {
+		testSelfReferencingAnnotation( buildJandexIndex( SimpleClass.class ) );
+	}
+
+	@Test
+	void testWithoutJandex() {
+		testSelfReferencingAnnotation( null );
+	}
+
+	private void testSelfReferencingAnnotation(IndexView jandexIndex) {
+		final SourceModelBuildingContext buildingContext = createBuildingContext( jandexIndex, SimpleClass.class );
+		final ClassDetailsRegistry classDetailsRegistry = buildingContext.getClassDetailsRegistry();
+		final AnnotationDescriptorRegistry descriptorRegistry = buildingContext.getAnnotationDescriptorRegistry();
+
+		final ClassDetails classDetails = classDetailsRegistry.getClassDetails( SimpleClass.class.getName() );
+		assertThat( classDetails.hasAnnotationUsage( SelfReferencingAnnotation.class, buildingContext ) ).isTrue();
+
+		final AnnotationDescriptor<SelfReferencingAnnotation> descriptor = descriptorRegistry.getDescriptor( SelfReferencingAnnotation.class );
+		assertThat( descriptor.hasAnnotationUsage( SelfReferencingAnnotation.class, buildingContext ) ).isTrue();
+	}
+
+	@SelfReferencingAnnotation
+	public static class SimpleClass {
+	}
+}

hibernate-models-jandex/src/test/java/org/hibernate/models/annotations/SelfReferencingAnnotation.java

@@ -0,0 +1,19 @@
+/*
+ * SPDX-License-Identifier: Apache-2.0
+ * Copyright: Red Hat Inc. and Hibernate Authors
+ */
+package org.hibernate.models.annotations;
+
+import java.lang.annotation.ElementType;
+import java.lang.annotation.RetentionPolicy;
+import java.lang.annotation.Target;
+import java.lang.annotation.Retention;
+
+/**
+ * @author Steve Ebersole
+ */
+@Target(ElementType.TYPE)
+@Retention(RetentionPolicy.RUNTIME)
+@SelfReferencingAnnotation
+public @interface SelfReferencingAnnotation {
+}

hibernate-models/src/main/java/org/hibernate/models/internal/StandardAnnotationDescriptor.java

@@ -1,10 +1,7 @@
 /*
- * Hibernate, Relational Persistence for Idiomatic Java
- *
  * SPDX-License-Identifier: Apache-2.0
  * Copyright: Red Hat Inc. and Hibernate Authors
  */
-
 package org.hibernate.models.internal;
 
 import java.lang.annotation.Annotation;
@@ -28,7 +25,9 @@
  */
 public class StandardAnnotationDescriptor<A extends Annotation> extends AbstractAnnotationDescriptor<A> {
 	private final List<AttributeDescriptor<?>> attributeDescriptors;
-	private final Map<Class<? extends Annotation>, ? extends Annotation> usagesMap;
+	private final SourceModelBuildingContext buildingContext;
+
+	private Map<Class<? extends Annotation>, ? extends Annotation> usagesMap;
 
 	public StandardAnnotationDescriptor(
 			Class<A> annotationType,
@@ -42,12 +41,15 @@ public StandardAnnotationDescriptor(
 			SourceModelBuildingContext buildingContext) {
 		super( annotationType, AnnotationHelper.extractTargets( annotationType ), AnnotationHelper.isInherited( annotationType ), repeatableContainer );
 
+		this.buildingContext = buildingContext;
 		this.attributeDescriptors = AnnotationDescriptorBuilding.extractAttributeDescriptors( annotationType );
-		this.usagesMap = buildUsagesMap( annotationType, buildingContext );
 	}
 
 	@Override
 	public Map<Class<? extends Annotation>, ? extends Annotation> getUsageMap() {
+		if ( usagesMap == null ) {
+			usagesMap = buildUsagesMap( getAnnotationType(), buildingContext );
+		}
 		return usagesMap;
 	}