No more headless=old (#38)

* No more headless=old

Signed-off-by: Mars Hall <mars@users.noreply.github.com>

* still needs headless though

Signed-off-by: Mars Hall <mars@users.noreply.github.com>

* Update docs for Chrome command flags

Signed-off-by: Mars Hall <mars@users.noreply.github.com>

---------

Signed-off-by: Mars Hall <mars@users.noreply.github.com>

Author: mars

README.md

@@ -17,6 +17,13 @@ heroku buildpacks:add -i 1 heroku-community/chrome-for-testing
 
 Deploy the app to install Chrome for Testing. 🚀 
 
+## Launching `chrome`
+
+To execute in a Heroku dyno, `chrome` typically requires the flags:
+
+* `--headless`
+* `--no-sandbox`
+
 ## Selecting the Chrome Release Channel
 
 By default, this buildpack will download the latest `Stable` release, which is provided
@@ -56,7 +63,7 @@ These locations may change in future versions of this buildpack, so please allow
 
 ### Changes to Command Flags
 
-The prior `heroku/google-chrome` buildpack wrapped the `chrome` command with default flags using a shim script. This is no longer implemented for `chrome` in this buildpack, to support evolving changes to the Chrome for Testing flags, such as the [--headless=new variation](https://developer.chrome.com/docs/chromium/new-headless).
+The prior `heroku/google-chrome` buildpack wrapped the `chrome` command with default flags using a shim script. This is no longer implemented for `chrome` in this buildpack, to support evolving changes to the Chrome for Testing flags.
 
 Depending on how an app is already setup for testing with Chrome, it may not require any changes.
 

bin/test.sh

@@ -18,9 +18,8 @@ docker run --rm heroku-buildpack-chrome-for-testing bash -l -c 'chromedriver --v
 docker run --rm heroku-buildpack-chrome-for-testing bash -l -c 'ldd $(which chrome)'
 docker run --rm heroku-buildpack-chrome-for-testing bash -l -c 'ldd $(which chromedriver)'
 
-# Check Chrome can fully boot in both new and old headless modes.
-docker run --rm heroku-buildpack-chrome-for-testing bash -l -c 'chrome --no-sandbox --headless=new --screenshot https://google.com'
-docker run --rm heroku-buildpack-chrome-for-testing bash -l -c 'chrome --no-sandbox --headless=old --screenshot https://google.com'
+# Check Chrome can fully boot.
+docker run --rm heroku-buildpack-chrome-for-testing bash -l -c 'chrome --no-sandbox --headless --screenshot https://google.com'
 
 # Display a size breakdown of the directories added by the buildpack to the app.
 docker run --rm heroku-buildpack-chrome-for-testing bash -l -c 'du --human-readable --max-depth=1 /app'