Merge #642

bors[bot] · stlankes · web-flow · commit edfd270deb1f · 2023-01-28T07:47:26.000Z
642: remove check of the backlog parameter r=stlankes a=stlankes

The check should be done by the implementation of the trait.

Co-authored-by: Stefan Lankes &lt;slankes@eonerc.rwth-aachen.de&gt;
diff --git a/src/fd/socket/mod.rs b/src/fd/socket/mod.rs
@@ -85,12 +85,8 @@ pub(crate) extern "C" fn __sys_accept(
 }
 
 pub(crate) extern "C" fn __sys_listen(fd: i32, backlog: i32) -> i32 {
-	if backlog > 1 {
-		-EINVAL
-	} else {
-		let obj = get_object(fd);
-		obj.map_or_else(|e| e, |v| (*v).listen(backlog))
-	}
+	let obj = get_object(fd);
+	obj.map_or_else(|e| e, |v| (*v).listen(backlog))
 }
 
 pub(crate) extern "C" fn __sys_bind(fd: i32, name: *const sockaddr, namelen: socklen_t) -> i32 {

Original file line number	Diff line number	Diff line change
`@@ -85,12 +85,8 @@ pub(crate) extern "C" fn __sys_accept(`
`85`	`85`	`}`
`86`	`86`
`87`	`87`	`pub(crate) extern "C" fn __sys_listen(fd: i32, backlog: i32) -> i32 {`
`88`		`- if backlog > 1 {`
`89`		`- -EINVAL`
`90`		`- } else {`
`91`		`- let obj = get_object(fd);`
`92`		`- obj.map_or_else(\|e\| e, \|v\| (*v).listen(backlog))`
`93`		`- }`
	`88`	`+ let obj = get_object(fd);`
	`89`	`+ obj.map_or_else(\|e\| e, \|v\| (*v).listen(backlog))`
`94`	`90`	`}`
`95`	`91`
`96`	`92`	`pub(crate) extern "C" fn __sys_bind(fd: i32, name: *const sockaddr, namelen: socklen_t) -> i32 {`