From 5b33a2a58c025aac4b3fe848950329d7461af511 Mon Sep 17 00:00:00 2001 From: Logan Parker Date: Fri, 19 Jan 2024 19:20:10 -0500 Subject: [PATCH 1/5] Create working tests --- RefactoringAssignment.iml | 10 ++++++++ src/{ => ifs}/InsuranceCalculator.java | 2 ++ test/ifs/IfElseDemoTest.java | 32 ++++++++++++++++++++++++++ 3 files changed, 44 insertions(+) rename src/{ => ifs}/InsuranceCalculator.java (96%) create mode 100644 test/ifs/IfElseDemoTest.java diff --git a/RefactoringAssignment.iml b/RefactoringAssignment.iml index 7e880ab..a2c2215 100644 --- a/RefactoringAssignment.iml +++ b/RefactoringAssignment.iml @@ -24,5 +24,15 @@ + + + + + + + + + + \ No newline at end of file diff --git a/src/InsuranceCalculator.java b/src/ifs/InsuranceCalculator.java similarity index 96% rename from src/InsuranceCalculator.java rename to src/ifs/InsuranceCalculator.java index 558e0a0..a5b8b80 100644 --- a/src/InsuranceCalculator.java +++ b/src/ifs/InsuranceCalculator.java @@ -1,3 +1,5 @@ +package ifs; + public class InsuranceCalculator { public double calculateInsurance(double income) { diff --git a/test/ifs/IfElseDemoTest.java b/test/ifs/IfElseDemoTest.java new file mode 100644 index 0000000..84b91fc --- /dev/null +++ b/test/ifs/IfElseDemoTest.java @@ -0,0 +1,32 @@ +package ifs; + +import org.junit.Test; + +import static org.junit.Assert.*; + +public class IfElseDemoTest { + @Test + public void low() { + assertEquals(1825, insuranceFor(5000), 0.01); + } + + @Test + public void medium() { + assertEquals(38600, insuranceFor(25000), 0.01); + } + + @Test + public void high() { + assertEquals(78500, insuranceFor(50000), 0.01); + } + + @Test + public void veryHigh() { + assertEquals(106400, insuranceFor(100_000), 0.01); + } + + private double insuranceFor(double income) { + return new InsuranceCalculator().calculateInsurance(income); + } + +} \ No newline at end of file From 9c10623d4cfac88143451830c76c9a0704351883 Mon Sep 17 00:00:00 2001 From: Logan Parker Date: Fri, 19 Jan 2024 19:24:20 -0500 Subject: [PATCH 2/5] Extract methods --- src/ifs/InsuranceCalculator.java | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/src/ifs/InsuranceCalculator.java b/src/ifs/InsuranceCalculator.java index a5b8b80..6f9ae2d 100644 --- a/src/ifs/InsuranceCalculator.java +++ b/src/ifs/InsuranceCalculator.java @@ -10,8 +10,24 @@ public double calculateInsurance(double income) { } else if (income <= 60000) { return (income-30000)*0.1+76500; } else { - return (income-60000)*0.02+105600; + return calculateInsuranceVeryHigh(income); } } + private static double calculateInsuranceVeryHigh(double income) { + return (income - getAdjustment()) * getWeight() + getConstant(); + } + + private static int getConstant() { + return 105600; + } + + private static double getWeight() { + return 0.02; + } + + private static int getAdjustment() { + return 60000; + } + } From f7fcf82201fa050bbcc9e96800d1026d250d340f Mon Sep 17 00:00:00 2001 From: Logan Parker Date: Fri, 19 Jan 2024 19:27:03 -0500 Subject: [PATCH 3/5] Use extract delegate refactoring --- src/ifs/InsuranceCalculator.java | 19 +------------------ src/ifs/InsuranceStrategyVeryHigh.java | 21 +++++++++++++++++++++ 2 files changed, 22 insertions(+), 18 deletions(-) create mode 100644 src/ifs/InsuranceStrategyVeryHigh.java diff --git a/src/ifs/InsuranceCalculator.java b/src/ifs/InsuranceCalculator.java index 6f9ae2d..d202093 100644 --- a/src/ifs/InsuranceCalculator.java +++ b/src/ifs/InsuranceCalculator.java @@ -10,24 +10,7 @@ public double calculateInsurance(double income) { } else if (income <= 60000) { return (income-30000)*0.1+76500; } else { - return calculateInsuranceVeryHigh(income); + return InsuranceStrategyVeryHigh.calculateInsuranceVeryHigh(income); } } - - private static double calculateInsuranceVeryHigh(double income) { - return (income - getAdjustment()) * getWeight() + getConstant(); - } - - private static int getConstant() { - return 105600; - } - - private static double getWeight() { - return 0.02; - } - - private static int getAdjustment() { - return 60000; - } - } diff --git a/src/ifs/InsuranceStrategyVeryHigh.java b/src/ifs/InsuranceStrategyVeryHigh.java new file mode 100644 index 0000000..a406bed --- /dev/null +++ b/src/ifs/InsuranceStrategyVeryHigh.java @@ -0,0 +1,21 @@ +package ifs; + +public class InsuranceStrategyVeryHigh { + public InsuranceStrategyVeryHigh() { + } + public static double calculateInsuranceVeryHigh(double income) { + return (income - getAdjustment()) * getWeight() + getConstant(); + } + + static int getConstant() { + return 105600; + } + + static double getWeight() { + return 0.02; + } + + static int getAdjustment() { + return 60000; + } +} \ No newline at end of file From 94607526fe8e1a9cb9537e595cc969b4a4306eac Mon Sep 17 00:00:00 2001 From: Logan Parker Date: Fri, 19 Jan 2024 19:31:22 -0500 Subject: [PATCH 4/5] Fine tuning --- src/ifs/InsuranceCalculator.java | 4 +++- src/ifs/InsuranceStrategy.java | 13 +++++++++++++ src/ifs/InsuranceStrategyVeryHigh.java | 14 +++++++------- 3 files changed, 23 insertions(+), 8 deletions(-) create mode 100644 src/ifs/InsuranceStrategy.java diff --git a/src/ifs/InsuranceCalculator.java b/src/ifs/InsuranceCalculator.java index d202093..d527ee3 100644 --- a/src/ifs/InsuranceCalculator.java +++ b/src/ifs/InsuranceCalculator.java @@ -2,6 +2,7 @@ public class InsuranceCalculator { + InsuranceStrategyVeryHigh strategyVeryHigh; public double calculateInsurance(double income) { if (income <= 10000) { return income*0.365; @@ -10,7 +11,8 @@ public double calculateInsurance(double income) { } else if (income <= 60000) { return (income-30000)*0.1+76500; } else { - return InsuranceStrategyVeryHigh.calculateInsuranceVeryHigh(income); + strategyVeryHigh = new InsuranceStrategyVeryHigh(); + return strategyVeryHigh.calculateInsurance(income); } } } diff --git a/src/ifs/InsuranceStrategy.java b/src/ifs/InsuranceStrategy.java new file mode 100644 index 0000000..75061a9 --- /dev/null +++ b/src/ifs/InsuranceStrategy.java @@ -0,0 +1,13 @@ +package ifs; + +public abstract class InsuranceStrategy { + public double calculateInsurance(double income) { + return (income - getAdjustment()) * getWeight() + getConstant(); + } + + public abstract int getConstant(); + + public abstract double getWeight(); + + public abstract int getAdjustment(); +} \ No newline at end of file diff --git a/src/ifs/InsuranceStrategyVeryHigh.java b/src/ifs/InsuranceStrategyVeryHigh.java index a406bed..3ad4d5a 100644 --- a/src/ifs/InsuranceStrategyVeryHigh.java +++ b/src/ifs/InsuranceStrategyVeryHigh.java @@ -1,21 +1,21 @@ package ifs; -public class InsuranceStrategyVeryHigh { +public class InsuranceStrategyVeryHigh extends InsuranceStrategy{ public InsuranceStrategyVeryHigh() { } - public static double calculateInsuranceVeryHigh(double income) { - return (income - getAdjustment()) * getWeight() + getConstant(); - } - static int getConstant() { + @Override + public int getConstant() { return 105600; } - static double getWeight() { + @Override + public double getWeight() { return 0.02; } - static int getAdjustment() { + @Override + public int getAdjustment() { return 60000; } } \ No newline at end of file From 58461a34f69b82352ef267de04de998473c10df6 Mon Sep 17 00:00:00 2001 From: Logan Parker Date: Fri, 19 Jan 2024 19:35:51 -0500 Subject: [PATCH 5/5] Implement abstract classes --- src/ifs/InsuranceCalculator.java | 15 +++++++++------ src/ifs/InsuranceStrategyHigh.java | 18 ++++++++++++++++++ src/ifs/InsuranceStrategyLow.java | 18 ++++++++++++++++++ src/ifs/InsuranceStrategyMedium.java | 18 ++++++++++++++++++ 4 files changed, 63 insertions(+), 6 deletions(-) create mode 100644 src/ifs/InsuranceStrategyHigh.java create mode 100644 src/ifs/InsuranceStrategyLow.java create mode 100644 src/ifs/InsuranceStrategyMedium.java diff --git a/src/ifs/InsuranceCalculator.java b/src/ifs/InsuranceCalculator.java index d527ee3..c7d316f 100644 --- a/src/ifs/InsuranceCalculator.java +++ b/src/ifs/InsuranceCalculator.java @@ -2,17 +2,20 @@ public class InsuranceCalculator { - InsuranceStrategyVeryHigh strategyVeryHigh; + private InsuranceStrategy strategy; public double calculateInsurance(double income) { if (income <= 10000) { - return income*0.365; + strategy = new InsuranceStrategyLow(); + return strategy.calculateInsurance(income); } else if (income <= 30000) { - return (income-10000)*0.2+35600; + strategy = new InsuranceStrategyMedium(); + return strategy.calculateInsurance(income); } else if (income <= 60000) { - return (income-30000)*0.1+76500; + strategy = new InsuranceStrategyHigh(); + return strategy.calculateInsurance(income); } else { - strategyVeryHigh = new InsuranceStrategyVeryHigh(); - return strategyVeryHigh.calculateInsurance(income); + strategy = new InsuranceStrategyVeryHigh(); + return strategy.calculateInsurance(income); } } } diff --git a/src/ifs/InsuranceStrategyHigh.java b/src/ifs/InsuranceStrategyHigh.java new file mode 100644 index 0000000..0c3fd99 --- /dev/null +++ b/src/ifs/InsuranceStrategyHigh.java @@ -0,0 +1,18 @@ +package ifs; + +public class InsuranceStrategyHigh extends InsuranceStrategy { + @Override + public int getConstant() { + return 76500; + } + + @Override + public double getWeight() { + return 0.1; + } + + @Override + public int getAdjustment() { + return 30000; + } +} \ No newline at end of file diff --git a/src/ifs/InsuranceStrategyLow.java b/src/ifs/InsuranceStrategyLow.java new file mode 100644 index 0000000..4609fcc --- /dev/null +++ b/src/ifs/InsuranceStrategyLow.java @@ -0,0 +1,18 @@ +package ifs; + +public class InsuranceStrategyLow extends InsuranceStrategy { + @Override + public int getConstant() { + return 0; + } + + @Override + public double getWeight() { + return 0.365; + } + + @Override + public int getAdjustment() { + return 0; + } +} \ No newline at end of file diff --git a/src/ifs/InsuranceStrategyMedium.java b/src/ifs/InsuranceStrategyMedium.java new file mode 100644 index 0000000..7f97923 --- /dev/null +++ b/src/ifs/InsuranceStrategyMedium.java @@ -0,0 +1,18 @@ +package ifs; + +public class InsuranceStrategyMedium extends InsuranceStrategy { + @Override + public int getConstant() { + return 35600; + } + + @Override + public double getWeight() { + return 0.2; + } + + @Override + public int getAdjustment() { + return 10000; + } +} \ No newline at end of file