Syncronize DefaultCacheImpl::Size (#1458)

diachenko-mischa · web-flow · commit 6ec925a4b7a1 · 2023-12-13T17:16:55.000+02:00
Fixes data race between Open/Close and Size.

Relates-To: OLPSUP-27831

Signed-off-by: Mykhailo Diachenko &lt;ext-mykhailo.z.diachenko@here.com&gt;
diff --git a/olp-cpp-sdk-core/src/cache/DefaultCacheImpl.cpp b/olp-cpp-sdk-core/src/cache/DefaultCacheImpl.cpp
@@ -1087,6 +1087,7 @@ void DefaultCacheImpl::SetEvictionPortion(uint64_t size) {
 }
 
 uint64_t DefaultCacheImpl::Size(CacheType type) const {
+  std::lock_guard<std::mutex> lock(cache_lock_);
   if (type == CacheType::kMutable) {
     return mutable_cache_data_size_;
   }

Original file line number	Diff line number	Diff line change
`@@ -1087,6 +1087,7 @@ void DefaultCacheImpl::SetEvictionPortion(uint64_t size) {`
`1087`	`1087`	`}`
`1088`	`1088`
`1089`	`1089`	`uint64_t DefaultCacheImpl::Size(CacheType type) const {`
	`1090`	`+ std::lock_guard<std::mutex> lock(cache_lock_);`
`1090`	`1091`	`if (type == CacheType::kMutable) {`
`1091`	`1092`	`return mutable_cache_data_size_;`
`1092`	`1093`	`}`