Skip to content

Commit 1c59ee6

Browse files
Switch to Boost.JSON
Relates-To: DATASDK-58 Signed-off-by: Andrey Kashcheev <ext-andrey.kashcheev@here.com>
1 parent e80ea0b commit 1c59ee6

File tree

128 files changed

+1850
-1841
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

128 files changed

+1850
-1841
lines changed

.github/workflows/psv_pipelines.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ jobs:
2727
run: ./scripts/misc/cpplint_ci.sh
2828
shell: bash
2929
- name: Install Ubuntu dependencies
30-
run: sudo apt-get update && sudo apt-get install -y libboost-all-dev ccache libssl-dev libcurl4-openssl-dev gcc-7 g++-7 --no-install-recommends
30+
run: sudo apt-get update && sudo apt-get install -y ccache libssl-dev libcurl4-openssl-dev gcc-7 g++-7 --no-install-recommends
3131
shell: bash
3232
- name: Compile project with cmake and ccache
3333
run: gcc --version && ./scripts/linux/psv/build_psv.sh
@@ -44,7 +44,7 @@ jobs:
4444
- name: Check out repository
4545
uses: actions/checkout@v4
4646
- name: Install Ubuntu dependencies
47-
run: sudo apt-get update && sudo apt-get install -y libboost-all-dev ccache libssl-dev libcurl4-openssl-dev gcc-9 g++-9 --no-install-recommends
47+
run: sudo apt-get update && sudo apt-get install -y ccache libssl-dev libcurl4-openssl-dev gcc-9 g++-9 --no-install-recommends
4848
shell: bash
4949
- name: Compile project with cmake and ccache
5050
run: gcc --version && ./scripts/linux/psv/build_psv.sh
@@ -72,7 +72,7 @@ jobs:
7272
- name: Check out repository
7373
uses: actions/checkout@v4
7474
- name: Install Ubuntu dependencies
75-
run: sudo apt-get update && sudo apt-get install -y libboost-all-dev libssl-dev libcurl4-openssl-dev gcc-7 g++-7 --no-install-recommends
75+
run: sudo apt-get update && sudo apt-get install -y libssl-dev libcurl4-openssl-dev gcc-7 g++-7 --no-install-recommends
7676
shell: bash
7777
- name: Compile project without cache
7878
run: ./scripts/linux/psv/build_psv_no_cache.sh
@@ -87,7 +87,7 @@ jobs:
8787
- name: Check out repository
8888
uses: actions/checkout@v4
8989
- name: Install Ubuntu dependencies
90-
run: sudo apt-get update && sudo apt-get install -y libboost-all-dev ccache libssl-dev libcurl4-openssl-dev --no-install-recommends
90+
run: sudo apt-get update && sudo apt-get install -y ccache libssl-dev libcurl4-openssl-dev --no-install-recommends
9191
shell: bash
9292
- name: Compile project with cmake and ccache
9393
run: gcc --version && ./scripts/linux/psv/build_psv.sh
@@ -104,7 +104,7 @@ jobs:
104104
- name: Check out repository
105105
uses: actions/checkout@v4
106106
- name: Install Ubuntu dependencies
107-
run: sudo rm /etc/apt/sources.list.d/microsoft-prod.list && sudo add-apt-repository ppa:ubuntu-toolchain-r/test && sudo apt-get update && sudo apt-get install -y libboost-all-dev libssl-dev libcurl4-openssl-dev gcc-13 g++-13 --no-install-recommends
107+
run: sudo rm /etc/apt/sources.list.d/microsoft-prod.list && sudo add-apt-repository ppa:ubuntu-toolchain-r/test && sudo apt-get update && sudo apt-get install -y libssl-dev libcurl4-openssl-dev gcc-13 g++-13 --no-install-recommends
108108
shell: bash
109109
- name: Compile project without cache
110110
run: ./scripts/linux/psv/build_psv_no_cache.sh
@@ -121,7 +121,7 @@ jobs:
121121
- name: Check out repository
122122
uses: actions/checkout@v4
123123
- name: Install Ubuntu dependencies
124-
run: sudo add-apt-repository ppa:ubuntu-toolchain-r/test && sudo apt-get update && sudo apt-get install -y libboost-all-dev ccache libssl-dev libcurl4-openssl-dev gcc-13 g++-13 --no-install-recommends
124+
run: sudo add-apt-repository ppa:ubuntu-toolchain-r/test && sudo apt-get update && sudo apt-get install -y ccache libssl-dev libcurl4-openssl-dev gcc-13 g++-13 --no-install-recommends
125125
shell: bash
126126
- name: Compile project with cmake and ccache
127127
run: gcc --version && ./scripts/linux/psv/build_psv.sh
@@ -136,7 +136,7 @@ jobs:
136136
- name: Check out repository
137137
uses: actions/checkout@v4
138138
- name: Install Ubuntu dependencies
139-
run: sudo apt-get update && sudo apt-get install -y libboost-all-dev libssl-dev libcurl4-openssl-dev --no-install-recommends
139+
run: sudo apt-get update && sudo apt-get install -y libssl-dev libcurl4-openssl-dev --no-install-recommends
140140
shell: bash
141141
- name: Compile project without cache
142142
run: ./scripts/linux/psv/build_psv_no_cache.sh

README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,6 @@ The table below lists the dependencies of the Data SDK.
7272
| Boost (headers only) | 1.82.0 |
7373
| LevelDB | 1.21 |
7474
| Snappy | 1.1.7 |
75-
| RapidJSON | latest |
7675
| Zlib | 1.3.1 |
7776

7877
### Linux dependencies

docs/get-started.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ cmake --build . --target install
7171

7272
<a href="https://cmake.org/download/" target="_blank">CMake</a> is the main build system. The minimal required version of CMake is 3.9.
7373

74-
CMake downloads <a href="https://github.com/google/leveldb" target="_blank">LevelDB</a>, <a href="https://github.com/google/snappy" target="_blank">Snappy</a>, <a href="https://github.com/Tencent/rapidjson" target="_blank">RapidJSON</a>, and <a href="https://www.boost.org/" target="_blank">Boost</a>. To disable downloading, set `OLP_SDK_BUILD_EXTERNAL_DEPS` to `OFF`. For details on CMake flags, see the [related](#cmake-flags) section.
74+
CMake downloads <a href="https://github.com/google/leveldb" target="_blank">LevelDB</a>, <a href="https://github.com/google/snappy" target="_blank">Snappy</a>, and <a href="https://www.boost.org/" target="_blank">Boost</a>. To disable downloading, set `OLP_SDK_BUILD_EXTERNAL_DEPS` to `OFF`. For details on CMake flags, see the [related](#cmake-flags) section.
7575

7676
**To build the Data SDK:**
7777

@@ -175,4 +175,4 @@ HERE Data SDK for C++ contains several example programs that demonstrate some of
175175
- [Read example](dataservice-read-catalog-example.md) – demonstrates how to get catalog and partition metadata, as well as partition data.
176176
- [Read example for a stream layer](dataservice-read-from-stream-layer-example.md) – demonstrates how to get data from a stream layer.
177177
- [Cache example](dataservice-cache-example.md) – demonstrates how to get partition data and work with a mutable and protected cache.
178-
- [Write example](dataservice-write-example.md) – demonstrates how to publish data to the HERE platform.
178+
- [Write example](dataservice-write-example.md) – demonstrates how to publish data to the HERE platform.

docs/work-with-data-apis.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ The example below demonstrates how to use the `olp::client::OlpClient` class fro
5959
}
6060
```
6161

62-
5. If the check passed and the status of the received `olp::client::HttpResponse` is `olp::http::HttpStatusCode::OK` (that is 200 OK), extract the encoded JSON from the response and parse it using RapidJSON or any other JSON parsing library.
62+
5. If the check passed and the status of the received `olp::client::HttpResponse` is `olp::http::HttpStatusCode::OK` (that is 200 OK), extract the encoded JSON from the response and parse it using JSON parsing library.
6363

6464
```cpp
6565
std::string response_json;

external/CMakeLists.txt

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -48,10 +48,6 @@ set(OLP_SDK_CPP_SNAPPY_TAG "1.1.7")
4848
set(OLP_SDK_CPP_LEVELDB_URL "https://github.com/google/leveldb.git")
4949
set(OLP_SDK_CPP_LEVELDB_TAG "1.21")
5050

51-
set(OLP_SDK_CPP_RAPIDJSON_URL "https://github.com/Tencent/rapidjson.git")
52-
# Next commit after that breaks our build
53-
set(OLP_SDK_CPP_RAPIDJSON_TAG "d621dc9e9c77f81e5c8a35b8dcc16dcd63351321")
54-
5551
set(OLP_SDK_CPP_BOOST_URL "https://github.com/boostorg/boost.git")
5652
set(OLP_SDK_CPP_BOOST_TAG "boost-1.82.0")
5753

@@ -73,11 +69,6 @@ if(NOT TARGET GTest AND NOT GTest_FOUND)
7369
add_subdirectory(googletest)
7470
endif()
7571

76-
find_package(RapidJSON 1.1.0 QUIET)
77-
if(NOT TARGET RapidJSON AND NOT RapidJSON_FOUND)
78-
add_subdirectory(rapidjson)
79-
endif()
80-
8172
if(OLP_SDK_ENABLE_DEFAULT_CACHE)
8273
find_package(leveldb QUIET)
8374
if(NOT TARGET leveldb AND NOT leveldb_FOUND)

external/boost/CMakeLists.txt.boost.in

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,11 @@ include(ExternalProject)
2424
ExternalProject_Add(boost-download
2525
GIT_REPOSITORY @OLP_SDK_CPP_BOOST_URL@
2626
GIT_TAG @OLP_SDK_CPP_BOOST_TAG@
27-
GIT_SUBMODULES libs/any
27+
GIT_SUBMODULES libs/align
28+
libs/any
2829
libs/assert
2930
libs/config
31+
libs/container
3032
libs/container_hash
3133
libs/core
3234
libs/detail
@@ -35,8 +37,10 @@ ExternalProject_Add(boost-download
3537
libs/function_types
3638
libs/headers
3739
libs/integer
40+
libs/intrusive
3841
libs/io
3942
libs/iterator
43+
libs/json
4044
libs/move
4145
libs/mpl
4246
libs/mp11
@@ -48,12 +52,14 @@ ExternalProject_Add(boost-download
4852
libs/serialization
4953
libs/smart_ptr
5054
libs/static_assert
55+
libs/system
5156
libs/throw_exception
5257
libs/tti
5358
libs/type_index
5459
libs/type_traits
5560
libs/utility
5661
libs/uuid
62+
libs/variant2
5763
libs/winapi
5864
tools/build
5965
tools/boost_install

external/rapidjson/CMakeLists.txt

Lines changed: 0 additions & 35 deletions
This file was deleted.

external/rapidjson/CMakeLists.txt.rapidjson.in

Lines changed: 0 additions & 38 deletions
This file was deleted.

0 commit comments

Comments
 (0)