Skip to content

Commit 1ff8df9

Browse files
authored
Merge pull request #21 from jhomarolo/master
change eslint action
2 parents a1631a6 + 66c3719 commit 1ff8df9

File tree

4 files changed

+13
-18
lines changed

4 files changed

+13
-18
lines changed

.github/linters/.eslintrc.json renamed to .eslintrc.json

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,16 +10,17 @@
1010
"Atomics": "readonly",
1111
"SharedArrayBuffer": "readonly"
1212
},
13+
"parser": "babel-eslint",
1314
"parserOptions": {
14-
"ecmaVersion": 2020
15+
"ecmaVersion": 2018
1516
},
1617
"rules": {
1718
"semi": ["error", "never"],
1819
"func-names": 0,
1920
"no-param-reassign": 0,
2021
"no-multi-str": 0,
2122
"no-unused-vars": ["warn", { "argsIgnorePattern": "^_" }],
22-
"no-console": ["warn", { "allow": ["tron"] }],
23+
"no-console": ["error", { "allow": ["tron"] }],
2324
"consistent-return": 0
2425
}
25-
}
26+
}

.github/workflows/on_pull_request.yml

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -18,22 +18,15 @@ jobs:
1818
uses: actions/setup-node@v1
1919
with:
2020
node-version: ${{ matrix.node-version }}
21-
- name: npm install
21+
- name: Installing dependencies
2222
run: npm i --ignore-scripts
23-
- run: npm ci
24-
- run: npm run build --if-present
25-
- run: npm test
26-
- run: npx nyc --reporter=lcov npm test && npx codecov
23+
- name: Running tests
24+
run: |
25+
npm test
26+
npx nyc --reporter=lcov npm test && npx codecov
2727
env:
2828
CI: true
2929
- name: Upload coverage to Codecov
3030
uses: codecov/codecov-action@v1.0.7
31-
- name: Run Super Linter - ESLint
32-
uses: github/super-linter@v3.3.0
33-
env:
34-
VALIDATE_ALL_CODEBASE: true
35-
LINTER_RULES_PATH: .github/linters
36-
JAVASCRIPT_ES_CONFIG_FILE: .eslintrc.json
37-
VALIDATE_JAVASCRIPT_STANDARD: false
38-
VALIDATE_JAVASCRIPT_ES: true
39-
DISABLE_ERRORS: false
31+
- name: Running Linter - ESLint
32+
run: npm run lint

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,6 +158,5 @@ public
158158
# DynamoDB Local files
159159
.dynamodb/
160160
.editorconfig
161-
/.eslintrc.json
162161
.prettierrc
163162

package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@
1010
"coverage-report": "nyc --reporter=html --reporter=text mocha --recursive ./test --timeout 10000",
1111
"coverage": "nyc --reporter=text mocha --recursive ./test --timeout 10000",
1212
"semantic-release": "semantic-release",
13+
"lint": "npx eslint \"**/*.{js,jsx}\" --quiet",
14+
"lint:fix": "npx eslint \"**/*.{js,jsx}\" --fix",
1315
"commit": "cz"
1416
},
1517
"directories": {

0 commit comments

Comments
 (0)