feat: support max breadcrumbs

Author: pmb0

lib/Sentry/Hub/Scope.pm

@@ -20,6 +20,8 @@ has tags                   => sub { {} };
 has transaction_name       => undef;
 has user                   => undef;
 
+my $DEFAULT_MAX_BREADCRUMBS = 100;
+
 sub set_span ($self, $span) {
   $self->span($span);
   return $self;
@@ -92,7 +94,15 @@ sub clear ($self) {
 
 sub add_breadcrumb ($self, $breadcrumb) {
   $breadcrumb->{timestamp} //= time;
-  push @{ $self->breadcrumbs }, $breadcrumb;
+
+  my $breadcrumbs = $self->breadcrumbs;
+
+  my $max_crumbs = $ENV{SENTRY_MAX_BREADCRUMBS} || $DEFAULT_MAX_BREADCRUMBS;
+  if (scalar $breadcrumbs->@* >= $max_crumbs) {
+    shift $breadcrumbs->@*;
+  }
+
+  push $breadcrumbs->@*, $breadcrumb;
 }
 
 sub clear_breadcrumbs ($self) {

t/scope.t

@@ -89,6 +89,20 @@ describe 'Sentry::Hub::Scope' => sub {
       lives_ok { Sentry::Hub::Scope->new->set_extras({ foo => 'bar' }) };
     };
   };
+
+  describe 'add_breadcrumb' => sub {
+    it 'limits breadcrumb items' => sub {
+      local $ENV{SENTRY_MAX_BREADCRUMBS} = 2;
+
+      $scope->add_breadcrumb({ message => 'foo' });
+      $scope->add_breadcrumb({ message => 'bar' });
+      $scope->add_breadcrumb({ message => 'baz' });
+
+      is scalar $scope->breadcrumbs->@*,      2;
+      is $scope->breadcrumbs->[0]->{message}, 'bar';
+      is $scope->breadcrumbs->[1]->{message}, 'baz';
+    };
+  };
 };
 
 runtests;