Skip to content

Commit 51b94ba

Browse files
committed
Merge branch 'dev'
2 parents 2a36304 + 31335a6 commit 51b94ba

22 files changed

+747
-61
lines changed

README.md

Lines changed: 48 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<img align="right" width="64px" src="https://raw.githubusercontent.com/hauke96/GeoNotes/main/app/src/main/res/mipmap-xxxhdpi/ic_launcher.png">
22

33
# GeoNotes
4-
A simple app to create and manage georeferenced notes (text and photos) on a map. The goal is to create the notes as fast as possible without any unnecessary UI/UX overhead.
4+
A simple and lightweight app to create and manage georeferenced notes (text and photos) on a map. The goal is to create the notes as fast as possible without any unnecessary UI/UX overhead.
55

66
<p align="center">
77
<img src="screenshots.png" alt="GeoNotes Screenshots"/>
@@ -12,7 +12,7 @@ A simple app to create and manage georeferenced notes (text and photos) on a map
1212
[<img src="https://fdroid.gitlab.io/artwork/badge/get-it-on.png" alt="Get it on F-Droid" height="60">](https://f-droid.org/packages/de.hauke_stieler.geonotes/)
1313
[<img src="https://user-images.githubusercontent.com/663460/26973090-f8fdc986-4d14-11e7-995a-e7c5e79ed925.png" alt="Download APK from GitHub" height="60">](https://github.com/hauke96/geonotes/releases/latest)
1414

15-
Runs on Android 4.1 and newer.
15+
GeoNotes runs on Android 4.1 (SDK 16) and newer. There's no version at the Google Play store (yet).
1616

1717
## Need help?
1818

@@ -23,16 +23,52 @@ See the [OSM Wiki page](https://wiki.openstreetmap.org/wiki/GeoNotes) for detail
2323
* Create, move and delete notes
2424
* Attach photos to note
2525
* List of all notes
26-
* Export all notes in GeoJson format
26+
* Export all notes in GeoJson or GPX format
2727
* Show and follow current location
2828

29+
## Contribute to this project
30+
31+
You want to report a bug, add a feature wish or maybe even add some code?
32+
That great :D Here's how to do so.
33+
34+
### Report feedback (no GitHub-account needed)
35+
36+
1. Open the GeoNotes app.
37+
2. Go into the settings (upper right menu → "Settings"/gear-icon) and click on the "Feedback" button at the bottom of the screen.
38+
39+
This will open your default E-Mail App on your phone so that you can now write me an E-Mail.
40+
41+
### Report bug / add feature request
42+
43+
1. Open a [new issue](https://github.com/hauke96/GeoNotes/issues/new).
44+
2. Describe the bug/feature as clearly as possible. Maybe add some screenshots or drawings to clear things up.
45+
3. Be open for questions and an discussion.
46+
47+
After a possible discussion, the bug will hopefully be fixed or the feature implemented.
48+
Don't be sad if your feature won't make it. This is not my only project and I'm running this in my spare time, my resources are therefore quite limited ;)
49+
50+
### Contribute code
51+
52+
Please create an issue before adding code (except it's just a spelling mistake or something similarly small).
53+
54+
1. Open a [new issue](https://github.com/hauke96/GeoNotes/issues/new).
55+
2. Describe the changes you want to make as clearly as possible. Maybe add mock-ups/drawings, code snippets, diagrams, etc. to clear things up.
56+
3. Be open for questions and an discussion.
57+
4. When everything is clear, enjoy coding ;)
58+
59+
Don't be sad if I don't want your feature idea to be in GeoNotes.
60+
This is my private project and I have a certain idea (s. below) what this app should be and what not.
61+
But feel free to create a fork and develop your own version of this app :)
62+
2963
## Use-case and Philosophy
3064

31-
This is the basic use-case of this app:
65+
### Basic idea of this app
66+
67+
Take notes while being outside (maybe even while walking or sitting in a bus) and later add the data to e.g. OSM.
3268

33-
* Take notes while being outside (maybe even while walking or sitting in a bus)
69+
### Usability principles
3470

35-
To enable this, the app follows some basic principles:
71+
To implement the above goal/idea, the app follows some basic principles:
3672

3773
* **Simplicity:** Make creating, editing, moving and deleting of notes as fast/easy as possible
3874
* **No upload** of data and no creation of notes on osm.org
@@ -41,13 +77,13 @@ To enable this, the app follows some basic principles:
4177
* **Simple and pragmatic UI:** No unnecessary animations, no overloaded UIs
4278
* **Feature toggles:** The possibility to enable/disable features
4379

44-
Features that will *not* make it into GeoNotes:
80+
### Features which will probably *not* be added to GeoNotes
4581

46-
* Offline maps: Too much work (where does the data come from? What format? When to update the data? Vector or raster data/tiles? etc.)
82+
* Offline maps (too much work for now)
4783
* Creating notes on osm.org
48-
* Directly editing data
49-
* All sorts of features that will only be used by ~5% (meaning a very small amount) of the users
50-
* iOS support
84+
* Uploading data directly to OSM (there are [other apps](https://github.com/streetcomplete/StreetComplete) to do that)
85+
* All sorts of features that will only be used by just a few users but require a lot of work to be implemented
86+
* iOS and other non-android support
5187

52-
Use other apps like [StreetComplete](https://github.com/streetcomplete/StreetComplete) if you want to directly edit OSM data or to create notes on osm.org.
88+
Try other apps like [StreetComplete](https://github.com/streetcomplete/StreetComplete) if you want to do one of the above things.
5389

app/build.gradle

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,15 @@ plugins {
33
}
44

55
android {
6-
compileSdkVersion 30
6+
compileSdkVersion 32
77
buildToolsVersion "30.0.2"
88

99
defaultConfig {
1010
applicationId "de.hauke_stieler.geonotes"
1111
minSdkVersion 16
12-
targetSdkVersion 30
13-
versionCode 1004003
14-
versionName "1.4.3"
12+
targetSdkVersion 32
13+
versionCode 1004004
14+
versionName "1.4.4"
1515

1616
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
1717
}
@@ -37,9 +37,9 @@ android {
3737
dependencies {
3838
implementation 'org.osmdroid:osmdroid-android:6.1.8'
3939

40-
implementation 'androidx.appcompat:appcompat:1.3.1'
41-
implementation 'com.google.android.material:material:1.4.0'
42-
implementation 'androidx.preference:preference:1.1.1'
40+
implementation 'androidx.appcompat:appcompat:1.4.1'
41+
implementation 'com.google.android.material:material:1.5.0'
42+
implementation 'androidx.preference:preference:1.2.0'
4343
implementation 'org.apache.commons:commons-text:1.9'
4444
implementation 'com.google.code.gson:gson:2.8.8'
4545
implementation 'me.himanshusoni.gpxparser:gpx-parser:1.13'

app/src/main/java/de/hauke_stieler/geonotes/MainActivity.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -319,6 +319,11 @@ protected void onActivityResult(int requestCode, int resultCode, @Nullable Inten
319319
break;
320320
}
321321
}
322+
323+
// Maybe some or all notes got deleted via the note list -> reload map
324+
if (requestCode == REQUEST_NOTE_LIST_REQUEST_CODE) {
325+
map.reloadAllNotes();
326+
}
322327
}
323328

324329
/**

app/src/main/java/de/hauke_stieler/geonotes/database/Database.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,10 @@ public void removeNote(long id) {
5656
noteStore.removeNote(getWritableDatabase(), id);
5757
}
5858

59+
public void removeAllNotes() {
60+
noteStore.removeAllNotes(getWritableDatabase());
61+
}
62+
5963
public List<Note> getAllNotes() {
6064
return noteStore.getAllNotes(getWritableDatabase());
6165
}

0 commit comments

Comments
 (0)