Skip to content

Commit 1fb83b7

Browse files
committed
Fix menu crash
1 parent 0f57681 commit 1fb83b7

File tree

1 file changed

+21
-21
lines changed

1 file changed

+21
-21
lines changed

app/src/main/java/de/hauke_stieler/geonotes/MainActivity.java

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -94,30 +94,10 @@ protected void onCreate(Bundle savedInstanceState) {
9494
Manifest.permission.CAMERA
9595
});
9696

97-
createExportPopupMenu();
9897
createMarkerFragment();
9998
createMap();
10099
}
101100

102-
private void createExportPopupMenu() {
103-
exportPopupMenu = new PopupMenu(this, findViewById(R.id.toolbar_btn_export));
104-
105-
exportPopupMenu.getMenu().add(0, 0, 0, "GeoJson");
106-
exportPopupMenu.getMenu().add(0, 1, 1, "GPX");
107-
108-
exportPopupMenu.setOnMenuItemClickListener(menuItem -> {
109-
switch (menuItem.getItemId()) {
110-
case 0:
111-
exporter.shareAsGeoJson();
112-
break;
113-
case 1:
114-
exporter.shareAsGpx();
115-
break;
116-
}
117-
return true;
118-
});
119-
}
120-
121101
private void createMarkerFragment() {
122102
MarkerFragment markerFragment = new MarkerFragment();
123103

@@ -157,6 +137,26 @@ void loadPreferences() {
157137
map.setLocation(lat, lon, zoom);
158138
}
159139

140+
private void showExportPopupMenu() {
141+
exportPopupMenu = new PopupMenu(this, findViewById(R.id.toolbar_btn_export));
142+
143+
exportPopupMenu.getMenu().add(0, 0, 0, "GeoJson");
144+
exportPopupMenu.getMenu().add(0, 1, 1, "GPX");
145+
146+
exportPopupMenu.setOnMenuItemClickListener(menuItem -> {
147+
switch (menuItem.getItemId()) {
148+
case 0:
149+
exporter.shareAsGeoJson();
150+
break;
151+
case 1:
152+
exporter.shareAsGpx();
153+
break;
154+
}
155+
return true;
156+
});
157+
exportPopupMenu.show();
158+
}
159+
160160
@Override
161161
public boolean onCreateOptionsMenu(Menu menu) {
162162
getMenuInflater().inflate(R.menu.toolbar_menu, menu);
@@ -177,7 +177,7 @@ public boolean onOptionsItemSelected(@NonNull MenuItem item) {
177177
}
178178
return true;
179179
case R.id.toolbar_btn_export:
180-
exportPopupMenu.show();
180+
showExportPopupMenu();
181181
return true;
182182
case R.id.toolbar_btn_settings:
183183
startActivity(new Intent(this, SettingsActivity.class));

0 commit comments

Comments
 (0)