relax upper bounds revision check (#1214)

* relax upper bounds revision check

* Update src/Distribution/Server/Util/CabalRevisions.hs

Co-authored-by: ˌbodʲɪˈɡrʲim <andrew.lelechenko@gmail.com>

---------

Co-authored-by: ˌbodʲɪˈɡrʲim <andrew.lelechenko@gmail.com>

Author: gbaz

src/Distribution/Server/Util/CabalRevisions.hs

@@ -179,7 +179,12 @@ checkCabalFileRevision checkXRevision old new = do
     checkPackageChecks :: Check GenericPackageDescription
     checkPackageChecks pkg pkg' =
       let checks  = checkPackage pkg  Nothing
-          checks' = checkPackage pkg' Nothing
+          checks' = filter notUpperBounds $ checkPackage pkg' Nothing
+          -- if multiple upper bounds are missing, then the simple set subtraction might detect a change to
+          -- just one, and fail. Ideally we'd perform a set subtraction directly on just the missing bounds
+          -- warning contents. A simple second best is to discard this check for now.
+          notUpperBounds (PackageDistSuspiciousWarn (MissingUpperBounds _)) = False
+          notUpperBounds _ = True
        in case checks' \\ checks of
             []        -> return ()
             newchecks -> fail $ unlines (map ppPackageCheck newchecks)