Add new simpler and friendlier favicon

The current favicon doesn't work well in such a small space. Besides
that, its transparent background doesn't work well in browsers with
dark themes. We agreed to change to a favicon with a haskell-purple
background color with the haskell logo. This commit also changes how
the favicon is exposed to the browser, by using <link> pointing to
a .png file, instead of *.ico as the first appears to be much more
size/quality efficient. Since the favicon declaration becomes explicit
there is no need to serve the it as a root-level file.

Author: Nuno Alexandre

Distribution/Server/Features/StaticFiles.hs

@@ -50,13 +50,9 @@ staticFilesFeature ServerEnv{serverStaticDir, serverTemplatesMode}
 --            resourceGet  = [("", \_ -> serveStaticTemplates)]
 --          }
       , (resourceAt "/static/..") {
-            resourceGet  = [("", \_ -> serveStaticDirFiles)]
+            resourceGet  = [("", const serveStaticDirFiles)]
           }
-      ] ++
-      [ (resourceAt ("/" ++ filename)) {
-            resourceGet  = [("", \_ -> serveStaticToplevelFile mimetype filename)]
-          }
-      | (filename, mimetype) <- toplevelFiles ]
+      ]
         ++
       [ (resourceAt ("/" ++ dropExtension name)) {
             resourceGet  = [("", \_ -> serveStaticTemplate name)]
@@ -136,7 +132,6 @@ staticFilesFeature ServerEnv{serverStaticDir, serverTemplatesMode}
     htmlErrorPage GenericErrorResponse =
       htmlErrorPage internalServerErrorResponse
 
-    toplevelFiles     = [("favicon.ico", "image/x-icon")]
     toplevelTemplates = map dropExtension staticFiles
 
 addHeaders :: Headers -> [(String, String)] -> Headers

Distribution/Server/Pages/Template.hs

@@ -31,6 +31,9 @@ hackagePageWith headExtra docTitle docSubtitle docContent bodyExtra =
                 , thelink ! [ rel "stylesheet"
                             , href stylesheetURL
                             , thetype "text/css"] << noHtml
+                , thelink ! [ rel "icon"
+                            , href faviconURL
+                            , thetype "image/png"] << noHtml
                 , meta ! [ name "viewport"
                          , content "width=device-width, initial-scale=1"]
                 -- if Search is enabled
@@ -43,7 +46,6 @@ hackagePageWith headExtra docTitle docSubtitle docContent bodyExtra =
     docHeader = [ docSubtitle
                 , navigationBar
                 ]
-    googleFontURL = "https://fonts.googleapis.com/css?family=PT+Sans:400,400i,700"
 
 navigationBar :: Html
 navigationBar =
@@ -59,9 +61,16 @@ navigationBar =
           , anchor ! [href accountsURL] << "User accounts"
           ]
 
+
+googleFontURL :: URL
+googleFontURL = "https://fonts.googleapis.com/css?family=PT+Sans:400,400i,700"
+
 stylesheetURL :: URL
 stylesheetURL = "/static/hackage.css"
 
+faviconURL :: URL
+faviconURL = "/static/favion.png"
+
 -- URL of the package list
 pkgListURL :: URL
 pkgListURL = "/packages/browse"

datafiles/static/favicon.ico

@@ -1,4 +1,5 @@
 <meta name="viewport" content="width=device-width, initial-scale=1">
 <link href="https://fonts.googleapis.com/css?family=PT+Sans:400,400i,700" rel="stylesheet">
 <link rel="stylesheet" href="/static/hackage.css" type="text/css" />
+<link rel="icon" type="image/png" href="/static/favicon.png" />
 <link rel="search" type="application/opensearchdescription+xml" title="Hackage" href="/packages/opensearch.xml" />