-
Notifications
You must be signed in to change notification settings - Fork 714
Open
Labels
cabal-validatevalidate.sh (cabal-validate) test suite runnervalidate.sh (cabal-validate) test suite runnermeta: trackingre: devxImproving the cabal developer experience (internal issue)Improving the cabal developer experience (internal issue)type: testingIssues about project test suitesIssues about project test suites
Description
The build
step will build... the stuff used by the other steps you're running!
E.g. solver-benchmarks
is only built if --solver-benchmarks
is passed... but if you use --step solver-benchmarks-run
manually, it won't be built. cabal-install-solver
will not be built if --lib-only
is passed.
So this introduces two confusing behaviors:
./validate.sh -s build && ./validate.sh -s solver-benchmarks
will error becausesolver-benchmarks
aren't built../validate.sh -s build
won't catch compile errors insolver-benchmarks
, which is a little confusing../validate.sh -s build
should... build everything that gets tested in CI, I think!
Related:
cabal-validate
: Too many ways to choose steps #10564cabal-validate
: Steps are not granular enough, add groups of steps #10563
Proposal: There should be a build
group which builds everything, and steps build-lib
, build-cli
, and build-solver-benchmarks
which build specific sets of libraries.
Metadata
Metadata
Assignees
Labels
cabal-validatevalidate.sh (cabal-validate) test suite runnervalidate.sh (cabal-validate) test suite runnermeta: trackingre: devxImproving the cabal developer experience (internal issue)Improving the cabal developer experience (internal issue)type: testingIssues about project test suitesIssues about project test suites