improve error messages

Author: DanielMSchmidt

internal/terraform/node_action.go

@@ -30,11 +30,12 @@ type nodeExpandActionDeclaration struct {
 }
 
 var (
-	_ GraphNodeConfigAction      = (*nodeExpandActionDeclaration)(nil)
-	_ GraphNodeReferenceable     = (*nodeExpandActionDeclaration)(nil)
-	_ GraphNodeReferencer        = (*nodeExpandActionDeclaration)(nil)
-	_ GraphNodeDynamicExpandable = (*nodeExpandActionDeclaration)(nil)
-	_ GraphNodeProviderConsumer  = (*nodeExpandActionDeclaration)(nil)
+	_ GraphNodeConfigAction       = (*nodeExpandActionDeclaration)(nil)
+	_ GraphNodeReferenceable      = (*nodeExpandActionDeclaration)(nil)
+	_ GraphNodeReferencer         = (*nodeExpandActionDeclaration)(nil)
+	_ GraphNodeDynamicExpandable  = (*nodeExpandActionDeclaration)(nil)
+	_ GraphNodeProviderConsumer   = (*nodeExpandActionDeclaration)(nil)
+	_ GraphNodeAttachActionSchema = (*nodeExpandActionDeclaration)(nil)
 )
 
 func (n *nodeExpandActionDeclaration) Name() string {
@@ -54,7 +55,7 @@ func (n *nodeExpandActionDeclaration) ModulePath() addrs.Module {
 	return n.Addr.Module
 }
 
-// GraphNodeAttachActionSchema impl
+// GraphNodeAttachActionSchema
 func (n *nodeExpandActionDeclaration) AttachActionSchema(schema *providers.ActionSchema) {
 	n.Schema = schema
 }

internal/terraform/node_action_apply.go

@@ -69,7 +69,7 @@ func invokeActions(ctx EvalContext, actionInvocations []*plans.ActionInvocationI
 		if err != nil {
 			diags = diags.Append(tfdiags.Sourceless(
 				tfdiags.Error,
-				"Failed to get provider",
+				fmt.Sprintf("Failed to get provider for %s", ai.Addr),
 				fmt.Sprintf("Failed to get provider: %s", err),
 			))
 			return diags

internal/terraform/node_action_instance.go

@@ -28,10 +28,11 @@ type NodeActionDeclarationInstance struct {
 }
 
 var (
-	_ GraphNodeModuleInstance = (*NodeActionDeclarationInstance)(nil)
-	_ GraphNodeExecutable     = (*NodeActionDeclarationInstance)(nil)
-	_ GraphNodeReferencer     = (*NodeActionDeclarationInstance)(nil)
-	_ GraphNodeReferenceable  = (*NodeActionDeclarationInstance)(nil)
+	_ GraphNodeModuleInstance   = (*NodeActionDeclarationInstance)(nil)
+	_ GraphNodeExecutable       = (*NodeActionDeclarationInstance)(nil)
+	_ GraphNodeReferencer       = (*NodeActionDeclarationInstance)(nil)
+	_ GraphNodeReferenceable    = (*NodeActionDeclarationInstance)(nil)
+	_ GraphNodeProviderConsumer = (*NodeActionDeclarationInstance)(nil)
 )
 
 func (n *NodeActionDeclarationInstance) Name() string {
@@ -60,7 +61,7 @@ func (n *NodeActionDeclarationInstance) Execute(ctx EvalContext, _ walkOperation
 	if err != nil {
 		diags = diags.Append(tfdiags.Sourceless(
 			tfdiags.Error,
-			"Failed to get provider",
+			fmt.Sprintf("Failed to get provider for %s", n.Addr),
 			fmt.Sprintf("Failed to get provider: %s", err),
 		))
 		return diags