Skip to content

Commit 480be90

Browse files
Clarify parsing and evaluating terminology in the contributor docs
1 parent 8097d46 commit 480be90

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

CONTRIBUTING.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,9 @@ flowchart TB
7474
3. [ParseDataProvider](server/src/parseDataProvider.ts) reads the file using the `fileContentProvider`, ...
7575
4. ... which caches the file contents, to avoid re-reading files that have not changed.
7676
5. [ParseDataProvider](server/src/parseDataProvider.ts) parses the file using [parser.ts](server/src/parser.ts), ...
77-
6. ... which parses it using the compiled `fbuild-grammar.ts` from step 0. This generates tokens and metadata.
77+
6. ... which parses it using the compiled `fbuild-grammar.ts` from step 0. This generates tokens and metadata. Note that the FASTBuild code base calls this "tokenizing" instead of "parsing".
7878
7. [ParseDataProvider](server/src/parseDataProvider.ts) caches the parse data, to avoid re-parsing files that have not changed.
79-
8. The [server](server/src/server.ts) evaluates the parsed data using [evaluator.ts](server/src/evaluator.ts). This involves:
79+
8. The [server](server/src/server.ts) evaluates the parsed data using [evaluator.ts](server/src/evaluator.ts). Note that the FASTBuild code base calls this "parsing" instead of "evaluating". This involves:
8080
* Evaluating each statement while maintaining state for variables/defines
8181
* Evaluating `If`, `ForEach`, `Using`, etc.
8282
* `#include`ing other files

0 commit comments

Comments
 (0)