Fail the build if there are eslint errors/warnings

Author: riot-harrisont

.eslintignore

@@ -2,4 +2,5 @@ node_modules/**
 client/node_modules/**
 client/out/**
 server/node_modules/**
-server/out/**
+server/out/**
+server/src/fbuild-grammar.ts

.github/workflows/node.js.yml

@@ -28,6 +28,7 @@ jobs:
         cache: 'npm'
     - run: npm clean-install
     - run: npm run build-grammar
+    - run: npm run lint
     - run: npm run build
     - run: npm test
     - name: Publish

.vscode/settings.json

@@ -1,6 +1,5 @@
 {
 	"editor.insertSpaces": false,
-	"tslint.enable": true,
 	"typescript.tsc.autoDetect": "off",
 	"typescript.preferences.quoteStyle": "single",
 	"editor.codeActionsOnSave": {
@@ -9,4 +8,4 @@
 	"search.exclude": {
 		"**/out": true
 	}
-}
+}

.vscode/tasks.json

@@ -11,15 +11,37 @@
 			},
 			"presentation": {
 				"panel": "dedicated",
-				"reveal": "never"
+				"reveal": "silent",
+				"revealProblems": "onProblem",
+				"clear": true
 			},
 			"problemMatcher": [
 				"$tsc"
 			],
 			"dependsOn": [
+				"lint",
 				"build grammar"
 			]
 		},
+		{
+			"label": "lint",
+			"type": "npm",
+			"script": "lint",
+			"group": {
+				"kind": "build",
+				"isDefault": false
+			},
+			"presentation": {
+				"panel": "dedicated",
+				"reveal": "silent",
+				"revealProblems": "onProblem",
+				"clear": true
+			},
+			"problemMatcher": [
+				"$tsc"
+			],
+			"dependsOn": []
+		},
 		{
 			"label": "watch-build",
 			"type": "npm",
@@ -28,12 +50,15 @@
 			"group": "build",
 			"presentation": {
 				"panel": "dedicated",
-				"reveal": "never"
+				"reveal": "silent",
+				"revealProblems": "onProblem",
+				"clear": true
 			},
 			"problemMatcher": [
 				"$tsc-watch"
 			],
 			"dependsOn": [
+				"lint",
 				"build grammar"
 			]
 		},
@@ -52,6 +77,8 @@
 				"isDefault": true
 			},
 			"presentation": {
+				"reveal": "always",
+				"revealProblems": "onProblem",
 				"clear": true
 			},
 			"dependsOn": "build"
@@ -64,7 +91,9 @@
 			"isBackground": true,
 			"presentation": {
 				"panel": "dedicated",
-				"reveal": "silent"
+				"reveal": "silent",
+				"revealProblems": "onProblem",
+				"clear": true
 			},
 			"dependsOn": "watch-build"
 		},
@@ -80,4 +109,4 @@
 			"problemMatcher": []
 		}
 	]
-}
+}

package.json

@@ -70,6 +70,7 @@
 	},
 	"scripts": {
 		"build-grammar": "node server/node_modules/nearley/bin/nearleyc.js server/src/fbuild-grammar.ne --out server/src/fbuild-grammar.ts",
+		"lint": "node ./node_modules/eslint/bin/eslint.js . --max-warnings 0",
 		"build": "tsc --build",
 		"watch-build": "tsc --build --watch",
 		"postinstall": "cd client && npm install && cd ../server && npm install && cd ..",

server/src/features/definitionProvider.ts

@@ -3,10 +3,6 @@ import {
     DefinitionParams,
 } from 'vscode-languageserver-protocol';
 
-import {
-    DocumentUri,
-} from 'vscode-languageserver-types';
-
 import {
     isPositionInRange,
 } from '../parser';
@@ -40,4 +36,4 @@ export class DefinitionProvider {
 
         return null;
     }
-}
+}

server/src/server.ts

@@ -384,4 +384,4 @@ state.documents.onDidClose(change => {
 
 // Make the text document manager listen on the connection for open, change and close text document events.
 state.documents.listen(state.connection);
-state.connection.listen();
+state.connection.listen();