No logging output

[nogginbox]

I don't think the logging is working. I see the alias plugin rcpt hook is running, but there is no logging shown for this plugin.

Looking at the code in this plugin I see logging looks like this:

connection.loginfo(plugin, `unknown action: ${action1}`)

In the hello.checks plugin logging looks like this:

this.loginfo(connection, `SKIPPING: ${test_name}`);

I'm not sure if these are logically equivalent, but as logging is not working I was wondering if something had changed in Haraka that had broke logging on this plugin.

[msimerson]

Nah, this was the issue:

diff --git a/index.js b/index.js
index c1e664e..848d182 100644
--- a/index.js
+++ b/index.js
@@ -81,7 +81,7 @@ exports.aliases = function (next, connection, params) {
 }
 
 function _drop(plugin, connection, rcpt) {
-  connection.logdebug(plugin, `marking ${rcpt} for drop`)
+  connection.loginfo(plugin, `marking ${rcpt} for drop`)
   if (!connection?.transaction?.notes) return
   connection.transaction.notes.discard = true
 }
@@ -98,14 +98,14 @@ function _alias(plugin, connection, key, config, host) {
 
   const txn = connection.transaction
   if (Array.isArray(config.to)) {
-    connection.logdebug(plugin, `aliasing ${txn.rcpt_to} to ${config.to}`)
+    connection.loginfo(plugin, `aliasing ${txn.rcpt_to} to ${config.to}`)
     txn.rcpt_to.pop()
     for (const addr of config.to) {
       txn.rcpt_to.push(new Address(`<${addr}>`))
     }
   } else {
     const to = config.to.search('@') === -1 ? `${config.to}@${host}` : config.to
-    connection.logdebug(plugin, `aliasing ${txn.rcpt_to} to ${to}`)
+    connection.loginfo(plugin, `aliasing ${txn.rcpt_to} to ${to}`)
     txn.rcpt_to.pop()
     txn.rcpt_to.push(new Address(`<${to}>`))
   }

I agree that when a plugin changes mail routing, it should log something. I'll make it so.