Fix tests

Author: fregante

source/libs/icons.js

@@ -6,15 +6,15 @@ export default function pickBestIcon(icons, size = 16) {
 		return 'icons/puzzle.svg';
 	}
 
-	const largestToSmallest = icons.toSorted((a, b) => b.size - a.size);
+	const smallestToLargest = icons.toSorted((a, b) => a.size - b.size);
 
 	// Find the smallest icon that is larger than the requested size
-	for (const icon of largestToSmallest) {
+	for (const icon of smallestToLargest) {
 		if (icon.size >= size) {
 			return icon.url;
 		}
 	}
 
 	// If it's not available (e.g. requested 32, available only 16), get the largest one
-	return largestToSmallest[0].url;
+	return smallestToLargest.at(-1).url;
 }

source/libs/icons.test.js

@@ -2,24 +2,23 @@ import assert from 'node:assert';
 import test from 'node:test';
 import pickBestIcon from './icons.js';
 
-globalThis.devicePixelRatio = 1;
-
 const manifest = [
 	{url: '16.svg', size: 16},
 	{url: '32.svg', size: 32},
 ];
 
 test('pickBestIcon', () => {
+	globalThis.devicePixelRatio = 1;
 	assert.equal(pickBestIcon(), 'icons/puzzle.svg');
 	assert.equal(pickBestIcon(undefined), 'icons/puzzle.svg');
 	assert.equal(pickBestIcon([]), 'icons/puzzle.svg');
-	// assert.equal(pickBestIcon(manifest), '16.svg');
-	// assert.equal(pickBestIcon(manifest, 16), '16.svg');
-	// assert.equal(pickBestIcon(manifest, 1), '16.svg');
-	// assert.equal(pickBestIcon(manifest, 32), '32.svg');
+	assert.equal(pickBestIcon(manifest), '16.svg');
+	assert.equal(pickBestIcon(manifest, 16), '16.svg');
+	assert.equal(pickBestIcon(manifest, 1), '16.svg');
+	assert.equal(pickBestIcon(manifest, 32), '32.svg');
 	assert.equal(pickBestIcon(manifest, 48), '32.svg');
 
-	// globalThis.devicePixelRatio = 2;
-	// assert.equal(pickBestIcon(manifest, 16), '32.svg');
-	// assert.equal(pickBestIcon(manifest, 32), '64.svg');
+	globalThis.devicePixelRatio = 2;
+	assert.equal(pickBestIcon(manifest, 16), '32.svg');
+	assert.equal(pickBestIcon(manifest, 32), '32.svg');
 });