Fix icon flicker (#157)

hankxdev · web-flow · commit 5489d8d6c322 · 2024-09-27T15:03:08.000+08:00
* fix image state change #146 * desc the order of icon list and lint code * lint code * use toReversed * restore wrong places fallback option
diff --git a/source/extension.svelte b/source/extension.svelte
@@ -49,13 +49,12 @@
 
 		if (icons) {
 			// Get a large icon closest to the desired size
-			for (const icon of icons.reverse()) {
+			for (const icon of icons.toReversed()) {
 				if (icon.size >= size) {
 					return icon.url;
 				}
 			}
 		}
-
 		// Fallback icon
 		return 'icons/puzzle.svg';
 	}

Original file line number	Diff line number	Diff line change
`@@ -49,13 +49,12 @@`
`49`	`49`
`50`	`50`	`if (icons) {`
`51`	`51`	`// Get a large icon closest to the desired size`
`52`		`- for (const icon of icons.reverse()) {`
	`52`	`+ for (const icon of icons.toReversed()) {`
`53`	`53`	`if (icon.size >= size) {`
`54`	`54`	`return icon.url;`
`55`	`55`	`}`
`56`	`56`	`}`
`57`	`57`	`}`
`58`		`-`
`59`	`58`	`// Fallback icon`
`60`	`59`	`return 'icons/puzzle.svg';`
`61`	`60`	`}`