Skip to content

Commit 3923970

Browse files
authored
Move disable/enable/more to dropdown (#108)
1 parent 17b547c commit 3923970

File tree

17 files changed

+75
-72
lines changed

17 files changed

+75
-72
lines changed

source/App.svelte

Lines changed: 43 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
import {onMount} from 'svelte';
44
import chromeP from 'webext-polyfill-kinda';
55
import Extension from './Extension.svelte';
6-
import openInTab from './lib/open-in-tab.js';
76
import UndoStack from './lib/undo-stack.js';
87
import {focusNext, focusPrevious} from './lib/focus-next.js';
98
@@ -17,6 +16,7 @@
1716
const options = optionsStorage.getAll();
1817
let showExtras = false;
1918
let showInfoMessage = !localStorage.getItem('undo-info-message');
19+
let userClickedHideInfoMessage = false; // "Disable/enable all" shows the button again, unless the user clicked already "hide" in the current session
2020
2121
options.then(({showButtons, width}) => {
2222
if (showButtons === 'always') {
@@ -44,6 +44,7 @@
4444
function hideInfoMessage() {
4545
localStorage.setItem('undo-info-message', 1);
4646
showInfoMessage = false;
47+
userClickedHideInfoMessage = true;
4748
}
4849
4950
function keyboardNavigationHandler(event) {
@@ -107,32 +108,57 @@
107108
showExtras = !showExtras;
108109
event.preventDefault();
109110
};
111+
112+
function handleBurger() {
113+
switch (this.value) {
114+
case 'enable': {
115+
toggleAll(true);
116+
showInfoMessage = true;
117+
break;
118+
}
119+
120+
case 'disable': {
121+
toggleAll(false);
122+
showInfoMessage = true;
123+
break;
124+
}
125+
126+
case 'extensions': {
127+
chrome.tabs.create({url: 'chrome://extensions'});
128+
break;
129+
}
130+
131+
default:
132+
}
133+
134+
this.value = ''; // Reset the select. PreventDefault doesn't work
135+
}
110136
</script>
111137

112138
<svelte:window on:keydown={keyboardNavigationHandler} />
113-
114139
<main>
115-
{#if showInfoMessage}
116-
<p>
140+
{#if showInfoMessage && !userClickedHideInfoMessage}
141+
<p class="notice">
117142
{@html getI18N('undoInfoMsg')}
118143
<a class="hide-action" href="#hide" on:click={hideInfoMessage}
119144
>{getI18N('hideInfoMsg')}</a
120145
>
121146
</p>
122147
{/if}
123-
<!-- svelte-ignore a11y-autofocus -->
124-
<input
125-
autofocus
126-
placeholder={getI18N('searchTxt')}
127-
bind:value={searchValue}
128-
type="search"
129-
/>
130-
<div class="options">
131-
<button on:click={() => toggleAll(false)}>{getI18N('disAll')}</button>
132-
<button on:click={() => toggleAll(true)}>{getI18N('enableAll')}</button>
133-
<a href="chrome://extensions" on:click={openInTab} title={getI18N('manage')}
134-
>{getI18N('extensionPage')}</a
135-
>
148+
<div class="header">
149+
<!-- svelte-ignore a11y-autofocus -->
150+
<input
151+
autofocus
152+
placeholder={getI18N('searchTxt')}
153+
bind:value={searchValue}
154+
type="search"
155+
/>
156+
<select class="header-burger" on:change={handleBurger}>
157+
<option value="">…</option>
158+
<option value="extensions">{getI18N('manage')}</option>
159+
<option value="disable">{getI18N('disAll')}</option>
160+
<option value="enable">{getI18N('enableAll')}</option>
161+
</select>
136162
</div>
137163
<ul id="ext-list">
138164
{#each extensions as extension (extension.id)}

source/_locales/de/messages.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,6 @@
1111
"extName": {
1212
"message": "One-Click Erweiterungsmanager"
1313
},
14-
"extensionPage": {
15-
"message": "Mehr…"
16-
},
1714
"gotoOpt": {
1815
"message": "Einstellungen…"
1916
},

source/_locales/en/messages.json

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,17 +11,14 @@
1111
"extName": {
1212
"message": "One Click Extensions Manager"
1313
},
14-
"extensionPage": {
15-
"message": "More…"
16-
},
1714
"gotoOpt": {
1815
"message": "Go to options page"
1916
},
2017
"hideInfoMsg": {
2118
"message": "Hide this"
2219
},
2320
"manage": {
24-
"message": "See in the extensions page"
21+
"message": "Open the Extensions page"
2522
},
2623
"openUrl": {
2724
"message": "See on the Web Store"
@@ -33,6 +30,6 @@
3330
"message": "You can undo and redo your last action until you close this popup. Press <kbd>ctrl+z</kbd> on Windows or Ubuntu, and <kbd>cmd+z</kbd> on macOS."
3431
},
3532
"uninstall": {
36-
"message": "Uninstall"
33+
"message": "Remove from Chrome"
3734
}
3835
}

source/_locales/es/messages.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,6 @@
1111
"extName": {
1212
"message": "Administrador de extensión de un clic"
1313
},
14-
"extensionPage": {
15-
"message": "Más…"
16-
},
1714
"gotoOpt": {
1815
"message": "Ir a la página de opciones"
1916
},

source/_locales/fr/messages.json

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,6 @@
1515
"message": "Gestionnaire d‘extensions à un clic",
1616
"hash": "9f7e3f659272f7b34a4073ddd8e29658"
1717
},
18-
"extensionPage": {
19-
"message": "Plus…",
20-
"hash": "65700a81f7671d1536e3cd98104e4be6"
21-
},
2218
"gotoOpt": {
2319
"message": "Aller à la page des options",
2420
"hash": "512c610fec5ae0c3b0d8ad20c7eb8e1e"

source/_locales/he/messages.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,6 @@
1111
"extName": {
1212
"message": "One Click Extensions Manager"
1313
},
14-
"extensionPage": {
15-
"message": "עוד…"
16-
},
1714
"gotoOpt": {
1815
"message": "אפשרויות נוספות"
1916
},

source/_locales/it/messages.json

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,6 @@
1515
"message": "One Click Extensions Manager",
1616
"hash": "9f7e3f659272f7b34a4073ddd8e29658"
1717
},
18-
"extensionPage": {
19-
"message": "Altro…",
20-
"hash": "65700a81f7671d1536e3cd98104e4be6"
21-
},
2218
"gotoOpt": {
2319
"message": "Vai alle impostazioni",
2420
"hash": "512c610fec5ae0c3b0d8ad20c7eb8e1e"
@@ -28,11 +24,11 @@
2824
"hash": "814f376f8a44776d5b80020e1327d173"
2925
},
3026
"manage": {
31-
"message": "Apri la pagina delle estensioni",
27+
"message": "Apri pagina delle estensioni",
3228
"hash": "8eabf58f7231431f0184129019963b9b"
3329
},
3430
"openUrl": {
35-
"message": "Apri il Chrome Web Store",
31+
"message": "Apri Chrome Web Store",
3632
"hash": "54c9abfc9842db7d4a2c0b692d15140c"
3733
},
3834
"searchTxt": {
@@ -44,7 +40,7 @@
4440
"hash": "4c9adc1bb6418b3ecbc77f3ddda22a70"
4541
},
4642
"uninstall": {
47-
"message": "Disinstalla",
43+
"message": "Rimuovi",
4844
"hash": "6c51642469a9fec1b394358b0a2ada5b"
4945
}
5046
}

source/_locales/ja/messages.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,6 @@
1111
"extName": {
1212
"message": "ワンクリックエクステンションマネージャー"
1313
},
14-
"extensionPage": {
15-
"message": "その他…"
16-
},
1714
"gotoOpt": {
1815
"message": "オプションページに移動"
1916
},

source/_locales/ko/messages.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,6 @@
1111
"extName": {
1212
"message": "원 클릭 확장 관리자"
1313
},
14-
"extensionPage": {
15-
"message": "More…"
16-
},
1714
"gotoOpt": {
1815
"message": "옵션 페이지로 이동"
1916
},

source/_locales/ru/messages.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,6 @@
1111
"extName": {
1212
"message": "One Click менеджер расширений"
1313
},
14-
"extensionPage": {
15-
"message": "Больше…"
16-
},
1714
"gotoOpt": {
1815
"message": "Перейти на страницу настроек"
1916
},

0 commit comments

Comments
 (0)