Skip to content

Conversation

Czaki
Copy link
Contributor

@Czaki Czaki commented Oct 4, 2024

The CannyEdgeDetection returns the same dtype as the input image, where plugin_function converts data to floats.

So it is required to convert data to some integer type to be valid lable dtype.

@haesleinhuepf
Copy link
Owner

git-bob review

Copy link

This message was generated by git-bob (version: 0.6.6, model: gpt-4o-2024-08-06, Run details), an experimental AI-based assistant. It can make mistakes and has limitations. Check its messages carefully.

The pull request addresses the issue of the dtype of the array returned by canny_edge_detection. The change applies a casting to sitkUInt8, ensuring that the output is a valid label dtype, as discussed. This change is minimal and directly resolves the issue described in the pull request. The code modification aligns with the requirement to convert the output to an integer type, consistent with the discussion. Everything looks good.

@haesleinhuepf haesleinhuepf merged commit 74ba1b5 into haesleinhuepf:main Oct 10, 2024
10 checks passed
@haesleinhuepf
Copy link
Owner

Awesome, thanks @Czaki !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants