Registered pre-expansion lint for checking macro invocations

Author: floriangru

CHANGELOG.md

@@ -1281,6 +1281,8 @@ Released 2018-09-13
 [`forget_ref`]: https://rust-lang.github.io/rust-clippy/master/index.html#forget_ref
 [`get_last_with_len`]: https://rust-lang.github.io/rust-clippy/master/index.html#get_last_with_len
 [`get_unwrap`]: https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
+[`hacspec`]: https://rust-lang.github.io/rust-clippy/master/index.html#hacspec
+[`hacspec_macros`]: https://rust-lang.github.io/rust-clippy/master/index.html#hacspec_macros
 [`identity_conversion`]: https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
 [`identity_op`]: https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
 [`if_let_redundant_pattern_matching`]: https://rust-lang.github.io/rust-clippy/master/index.html#if_let_redundant_pattern_matching

README.md

@@ -5,7 +5,7 @@
 
 A collection of lints to catch common mistakes and improve your [Rust](https://github.com/rust-lang/rust) code.
 
-[There are 362 lints included in this crate!](https://rust-lang.github.io/rust-clippy/master/index.html)
+[There are 364 lints included in this crate!](https://rust-lang.github.io/rust-clippy/master/index.html)
 
 We have a bunch of lint categories to allow you to choose how much Clippy is supposed to ~~annoy~~ help you:
 

clippy_lints/src/hacspec_macros.rs

@@ -0,0 +1,31 @@
+use crate::utils::span_lint;
+use rustc_lint::{EarlyLintPass, EarlyContext};
+use rustc_session::{declare_lint_pass, declare_tool_lint};
+// use rustc_span::Span;
+use rustc_ast::{
+    ast::{MacCall, PathSegment},
+};
+
+declare_clippy_lint! {
+    /// **What it does:**
+    ///
+    /// **Why is this bad?**
+    ///
+    /// **Known problems:** None.
+    ///
+    /// **Example:**
+    ///
+    /// ```rust
+    /// // example code
+    /// ```
+    pub HACSPEC_MACROS,
+    nursery, //pedantic, corectness or restriction, but shouldn't interfere with other lints ? or shipped completely separately
+    "default lint description"
+}
+
+declare_lint_pass!(HacspecMacros => [HACSPEC_MACROS]);
+
+impl EarlyLintPass for HacspecMacros {
+    fn check_mac(&mut self, _cx: &EarlyContext<'_>, mac: &MacCall) {
+    }
+}

clippy_lints/src/lib.rs

@@ -217,6 +217,7 @@ pub mod formatting;
 pub mod functions;
 pub mod get_last_with_len;
 pub mod hacspec;
+pub mod hacspec_macros;
 pub mod identity_conversion;
 pub mod identity_op;
 pub mod if_let_some_result;
@@ -338,6 +339,7 @@ mod reexport {
 /// Used in `./src/driver.rs`.
 pub fn register_pre_expansion_lints(store: &mut rustc_lint::LintStore, conf: &Conf) {
     store.register_pre_expansion_pass(|| box write::Write::default());
+    store.register_pre_expansion_pass(|| box hacspec_macros::HacspecMacros);
     store.register_pre_expansion_pass(|| box redundant_field_names::RedundantFieldNames);
     let single_char_binding_names_threshold = conf.single_char_binding_names_threshold;
     store.register_pre_expansion_pass(move || box non_expressive_names::NonExpressiveNames {
@@ -560,6 +562,7 @@ pub fn register_plugins(store: &mut rustc_lint::LintStore, sess: &Session, conf:
         &functions::TOO_MANY_LINES,
         &get_last_with_len::GET_LAST_WITH_LEN,
         &hacspec::HACSPEC,
+        &hacspec_macros::HACSPEC_MACROS,
         &identity_conversion::IDENTITY_CONVERSION,
         &identity_op::IDENTITY_OP,
         &if_let_some_result::IF_LET_SOME_RESULT,
@@ -1023,6 +1026,7 @@ pub fn register_plugins(store: &mut rustc_lint::LintStore, sess: &Session, conf:
     store.register_early_pass(move || box excessive_bools::ExcessiveBools::new(max_struct_bools, max_fn_params_bools));
     store.register_early_pass(|| box option_env_unwrap::OptionEnvUnwrap);
     // store.register_early_pass(|| box hacspec::Hacspec);
+    // store.register_early_pass(|| box hacspec_macros::HacspecMacros);
     store.register_late_pass(|| box hacspec::Hacspec);
     store.register_late_pass(|| box wildcard_imports::WildcardImports);
     store.register_early_pass(|| box macro_use::MacroUseImports);
@@ -1088,6 +1092,8 @@ pub fn register_plugins(store: &mut rustc_lint::LintStore, sess: &Session, conf:
         LintId::of(&excessive_bools::STRUCT_EXCESSIVE_BOOLS),
         LintId::of(&functions::MUST_USE_CANDIDATE),
         LintId::of(&functions::TOO_MANY_LINES),
+        LintId::of(&hacspec::HACSPEC),
+        LintId::of(&hacspec_macros::HACSPEC_MACROS),
         LintId::of(&if_not_else::IF_NOT_ELSE),
         LintId::of(&infinite_iter::MAYBE_INFINITE_ITER),
         LintId::of(&items_after_statements::ITEMS_AFTER_STATEMENTS),

src/lintlist/mod.rs

@@ -6,7 +6,7 @@ pub use lint::Lint;
 pub use lint::LINT_LEVELS;
 
 // begin lint list, do not remove this comment, it’s used in `update_lints`
-pub const ALL_LINTS: [Lint; 362] = [
+pub const ALL_LINTS: [Lint; 364] = [
     Lint {
         name: "absurd_extreme_comparisons",
         group: "correctness",
@@ -693,6 +693,20 @@ pub const ALL_LINTS: [Lint; 362] = [
         deprecation: None,
         module: "methods",
     },
+    Lint {
+        name: "hacspec",
+        group: "pedantic",
+        desc: "Checks whether the code belongs to the hacspec subset of Rust",
+        deprecation: None,
+        module: "hacspec",
+    },
+    Lint {
+        name: "hacspec_macros",
+        group: "pedantic",
+        desc: "default lint description",
+        deprecation: None,
+        module: "hacspec_macros",
+    },
     Lint {
         name: "identity_conversion",
         group: "complexity",

tests/ui/hacspec/aes.rs

@@ -1,5 +1,6 @@
 #![allow(clippy::all)]
 #![deny(clippy::hacspec)]
+#![deny(clippy::hacspec_macros)]
 
 extern crate hacspec;
 extern crate contracts;