Skip to content

Commit a21215a

Browse files
committed
Reverting to S3
1 parent 9eb33a3 commit a21215a

File tree

5 files changed

+29
-47
lines changed

5 files changed

+29
-47
lines changed

.github/workflows/build.yml

Lines changed: 24 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -59,14 +59,13 @@ jobs:
5959
cd skia-canvas
6060
npm test && npm run package
6161
62-
- name: Add to release
62+
- name: Upload to S3
6363
env:
64-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
64+
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
65+
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
6566
run: |
6667
cd skia-canvas
67-
export RELEASE="v$(jq -r '.version' package.json)"
68-
export ASSET=$(npm run package 2>&1 | grep 'info package' | cut -d "\"" -f 2)
69-
gh release upload $RELEASE $ASSET
68+
npm run upload
7069
7170
7271
linux-arm64:
@@ -133,14 +132,13 @@ jobs:
133132
cd skia-canvas
134133
npm test && npm run package
135134
136-
- name: Add to release
135+
- name: Upload to S3
137136
env:
138-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
137+
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
138+
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
139139
run: |
140140
cd skia-canvas
141-
export RELEASE="v$(jq -r '.version' package.json)"
142-
export ASSET=$(npm run package 2>&1 | grep 'info package' | cut -d "\"" -f 2)
143-
gh release upload $RELEASE $ASSET
141+
npm run upload
144142
145143
146144
linux-arm:
@@ -205,14 +203,13 @@ jobs:
205203
cd skia-canvas
206204
npm test && npm run package
207205
208-
- name: Add to release
206+
- name: Upload to S3
209207
env:
210-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
208+
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
209+
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
211210
run: |
212211
cd skia-canvas
213-
export RELEASE="v$(jq -r '.version' package.json)"
214-
export ASSET=$(npm run package 2>&1 | grep 'info package' | cut -d "\"" -f 2)
215-
gh release upload $RELEASE $ASSET
212+
npm run upload
216213
217214
218215
mac-x86:
@@ -243,13 +240,12 @@ jobs:
243240
run: |
244241
npm test && npm run package
245242
246-
- name: Add to release
243+
- name: Upload to S3
247244
env:
248-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
245+
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
246+
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
249247
run: |
250-
export RELEASE="v$(jq -r '.version' package.json)"
251-
export ASSET=$(npm run package 2>&1 | grep 'info package' | cut -d "\"" -f 2)
252-
gh release upload $RELEASE $ASSET
248+
npm run upload
253249
254250
255251
mac-arm64:
@@ -285,13 +281,12 @@ jobs:
285281
sed -i.bak 's/"package_name":.*/"package_name": "{platform}-arm64-{node_napi_label}-{libc}.tar.gz",/' package.json
286282
npm run package
287283
288-
- name: Add to release
284+
- name: Upload to S3
289285
env:
290-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
286+
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
287+
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
291288
run: |
292-
export RELEASE="v$(jq -r '.version' package.json)"
293-
export ASSET=$(npm run package 2>&1 | grep 'info package' | cut -d "\"" -f 2)
294-
gh release upload $RELEASE $ASSET
289+
npm run upload
295290
296291
297292
windows-x86:
@@ -320,10 +315,9 @@ jobs:
320315
run: |
321316
npm test && npm run package
322317
323-
- name: Add to release
318+
- name: Upload to S3
324319
env:
325-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
320+
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
321+
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
326322
run: |
327-
export RELEASE="v$(jq -r '.version' package.json)"
328-
export ASSET=$(npm run package 2>&1 | grep 'info package' | cut -d "\"" -f 2)
329-
gh release upload $RELEASE $ASSET
323+
npm run upload

arch/arm/Dockerfile

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,6 @@ RUN git clone https://gn.googlesource.com/gn && \
1313
cp out/gn /usr/local/bin/gn && \
1414
rm -rf /usr/local/src/gn
1515

16-
RUN curl -fsSL https://cli.github.com/packages/githubcli-archive-keyring.gpg | dd of=/usr/share/keyrings/githubcli-archive-keyring.gpg && \
17-
echo "deb [arch=$(dpkg --print-architecture) signed-by=/usr/share/keyrings/githubcli-archive-keyring.gpg] https://cli.github.com/packages stable main" | tee /etc/apt/sources.list.d/github-cli.list > /dev/null && \
18-
apt update && \
19-
apt install -y gh jq
20-
2116
ENV SKIA_GN_COMMAND="/usr/local/bin/gn"
2217
ENV SKIA_NINJA_COMMAND="/usr/bin/ninja"
2318

arch/glibc/Dockerfile

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,11 @@ RUN apt-get update && \
44
apt-get install -y -q \
55
python2 python3 perl git clang lldb lld \
66
build-essential software-properties-common \
7-
libssl-dev libfontconfig-dev ninja-build
7+
libssl-dev libfontconfig-dev \
8+
ninja-build
89

910
RUN add-apt-repository "deb http://deb.debian.org/debian buster-backports main" && \
1011
apt-get update && apt-get install -t buster-backports -y -q \
1112
curl
1213

13-
RUN curl -fsSL https://cli.github.com/packages/githubcli-archive-keyring.gpg | dd of=/usr/share/keyrings/githubcli-archive-keyring.gpg && \
14-
echo "deb [arch=$(dpkg --print-architecture) signed-by=/usr/share/keyrings/githubcli-archive-keyring.gpg] https://cli.github.com/packages stable main" | tee /etc/apt/sources.list.d/github-cli.list > /dev/null && \
15-
apt update && \
16-
apt install -y gh jq
17-
18-
ENV SKIA_NINJA_COMMAND="/usr/bin/ninja"
14+
ENV SKIA_NINJA_COMMAND="/usr/bin/ninja"

arch/musl/Dockerfile

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,12 @@ ENV RUSTFLAGS="-C target-feature=-crt-static" \
88
SKIA_NINJA_COMMAND="/usr/bin/ninja"
99

1010
RUN apk update && apk add --update --no-cache \
11-
bash curl jq git python3 python2 perl clang llvm g++ build-base \
11+
bash curl git python3 python2 perl clang llvm g++ build-base \
1212
musl-dev openssl-dev fontconfig-dev fontconfig ttf-dejavu
1313

1414
RUN apk add --update --no-cache --repository http://dl-cdn.alpinelinux.org/alpine/edge/testing \
1515
gn ninja
1616

17-
RUN echo "@community http://dl-cdn.alpinelinux.org/alpine/edge/community" >> /etc/apk/repositories && \
18-
apk add github-cli@community
19-
2017
RUN export ASM="/usr/include/c++/10.3.1/aarch64-alpine-linux-musl/asm" && \
2118
mkdir -p ${ASM} && \
2219
touch ${ASM}/hwcap.h

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
"module_path": "./lib/v{napi_build_version}",
5151
"remote_path": "./v{version}",
5252
"package_name": "{platform}-{arch}-{node_napi_label}-{libc}.tar.gz",
53-
"host": "https://github.com/samizdatco/skia-canvas/releases/download/",
53+
"host": "https://skia-canvas.s3.us-east-1.amazonaws.com",
5454
"napi_versions": [
5555
6
5656
]

0 commit comments

Comments
 (0)