Skip to content

Commit 87587bd

Browse files
authored
fix heroku one click deployment (#1255)
fix heroku one click deployment
2 parents 969189b + af6bbb4 commit 87587bd

File tree

4 files changed

+1039
-1020
lines changed

4 files changed

+1039
-1020
lines changed

app.json

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,6 @@
1919
"description": "Let npm also install development build tool",
2020
"value": "false"
2121
},
22-
"DB_TYPE": {
23-
"description": "Specify database type. See sequelize available databases. Default using postgres",
24-
"value": "postgres"
25-
},
2622
"HMD_SESSION_SECRET": {
2723
"description": "Secret used to secure session cookies.",
2824
"required": false

bin/heroku

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,7 @@ module.exports = {
1111
'config': path.resolve('config.json'),
1212
'migrations-path': path.resolve('lib', 'migrations'),
1313
'models-path': path.resolve('lib', 'models'),
14-
'url': process.env.DATABASE_URL,
15-
'dialect': process.env.DB_TYPE
14+
'url': process.env.DATABASE_URL
1615
}
1716
1817
EOF
@@ -26,6 +25,4 @@ EOF
2625
2726
EOF
2827

29-
# build app
30-
npm run build
3128
fi

package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,8 @@
2626
"coverage": "nyc mocha --require intelli-espower-loader --exit --recursive ./test",
2727
"coverage:ci": "nyc mocha --no-color -R dot --require intelli-espower-loader --exit --recursive ./test",
2828
"test": "npm run-script lint && npm run-script jsonlint && npm run-script coverage",
29-
"test:ci": "npm run-script lint && npm run-script jsonlint && npm run-script coverage:ci"
29+
"test:ci": "npm run-script lint && npm run-script jsonlint && npm run-script coverage:ci",
30+
"postinstall": "bin/heroku"
3031
},
3132
"dependencies": {
3233
"@hackmd/codemirror": "~5.46.2",
@@ -193,7 +194,7 @@
193194
"utf-8-validate": "~5.0.1"
194195
},
195196
"engines": {
196-
"node": ">=8.0.0"
197+
"node": ">=8.0.0 <12.0.0"
197198
},
198199
"maintainers": [
199200
{

0 commit comments

Comments
 (0)