Merge pull request #1559 from hackmdio/feature/update-delete-note-api

Update and delete note api

Author: Yukaii

lib/note/index.js

@@ -2,11 +2,12 @@
 
 const config = require('../config')
 const logger = require('../logger')
-const { Note, User } = require('../models')
+const { Note, User, Revision } = require('../models')
 
 const { newCheckViewPermission, errorForbidden, responseCodiMD, errorNotFound, errorInternalError } = require('../response')
-const { updateHistory } = require('../history')
+const { updateHistory, historyDelete } = require('../history')
 const { actionPublish, actionSlide, actionInfo, actionDownload, actionPDF, actionGist, actionRevision, actionPandoc } = require('./noteActions')
+const realtime = require('../realtime/realtime')
 
 async function getNoteById (noteId, { includeUser } = { includeUser: false }) {
   const id = await Note.parseNoteIdAsync(noteId)
@@ -232,7 +233,106 @@ function listMyNotes (req, res) {
   }
 }
 
+const deleteNote = async (req, res) => {
+  if (req.isAuthenticated()) {
+    const noteId = await Note.parseNoteIdAsync(req.params.noteId)
+    try {
+      const destroyed = await Note.destroy({
+        where: {
+          id: noteId,
+          ownerId: req.user.id
+        }
+      })
+      if (!destroyed) {
+        logger.error('Delete note failed: Make sure the noteId and ownerId are correct.')
+        return errorNotFound(req, res)
+      }
+
+      historyDelete(req, res)
+
+      if (realtime.isNoteExistsInPool(noteId)) {
+        const note = realtime.getNoteFromNotePool(noteId)
+        realtime.disconnectSocketOnNote(note)
+      }
+
+      res.send({
+        status: 'ok'
+      })
+    } catch (err) {
+      logger.error('Delete note failed: Internal Error.')
+      return errorInternalError(req, res)
+    }
+  } else {
+    return errorForbidden(req, res)
+  }
+}
+
+const updateNote = async (req, res) => {
+  if (req.isAuthenticated()) {
+    const noteId = await Note.parseNoteIdAsync(req.params.noteId)
+    try {
+      const note = await Note.findOne({
+        where: {
+          id: noteId
+        }
+      })
+      if (!note) {
+        logger.error('Update note failed: Can\'t find the note.')
+        return errorNotFound(req, res)
+      }
+
+      if (realtime.isNoteExistsInPool(noteId)) {
+        logger.error('Update note failed: There are online users opening this note.')
+        return res.status('403').json({ status: 'error', message: 'Update API can only be used when no users is online' })
+      }
+
+      const now = Date.now()
+      const content = req.body.content
+      const updated = await note.update({
+        title: Note.parseNoteTitle(content),
+        content: content,
+        lastchangeAt: now,
+        authorship: [
+          [
+            req.user.id,
+            0,
+            content.length,
+            now,
+            now
+          ]
+        ]
+      })
+
+      if (!updated) {
+        logger.error('Update note failed: Write note content error.')
+        return errorInternalError(req, res)
+      }
+
+      updateHistory(req.user.id, note.id, content)
+
+      Revision.saveNoteRevision(note, (err, revision) => {
+        if (err) {
+          logger.error(err)
+          return errorInternalError(req, res)
+        }
+        if (!revision) return errorNotFound(req, res)
+        res.send({
+          status: 'ok'
+        })
+      })
+    } catch (err) {
+      logger.error(err)
+      logger.error('Update note failed: Internal Error.')
+      return errorInternalError(req, res)
+    }
+  } else {
+    return errorForbidden(req, res)
+  }
+}
+
 exports.showNote = showNote
 exports.showPublishNote = showPublishNote
 exports.noteActions = noteActions
 exports.listMyNotes = listMyNotes
+exports.deleteNote = deleteNote
+exports.updateNote = updateNote

lib/routes.js

@@ -12,6 +12,7 @@ const historyController = require('./history')
 const userController = require('./user')
 const noteController = require('./note')
 const response = require('./response')
+const bodyParser = require('body-parser')
 const appRouter = Router()
 
 // register route
@@ -72,6 +73,10 @@ appRouter.get('/p/:shortid', response.showPublishSlide)
 appRouter.get('/p/:shortid/:action', response.publishSlideActions)
 // gey my note list
 appRouter.get('/api/notes/myNotes', noteController.listMyNotes)
+// delete note by id
+appRouter.delete('/api/notes/:noteId', noteController.deleteNote)
+// update note content by id
+appRouter.put('/api/notes/:noteId', bodyParser.json(), noteController.updateNote)
 // get note by id
 appRouter.get('/:noteId', wrap(noteController.showNote))
 // note actions