Break coordsCharInner loop if diff is 0

adrianheine · adrianheine · commit 6606ba4930ca · 2017-06-08T21:27:27.000+02:00
Closes codemirror#4786.
diff --git a/src/measurement/position_measurement.js b/src/measurement/position_measurement.js
@@ -479,7 +479,7 @@ function coordsCharInner(cm, lineObj, lineNo, x, y) {
         steps = Math.min(steps, Math.ceil(Math.abs(diff) / diff_change_per_step))
         dir = diff < 0 ? 1 : -1
       }
-    } while (steps > 1 || ((dir < 0) != (diff < 0) && (Math.abs(diff) <= Math.abs(prevDiff))))
+    } while (diff != 0 && (steps > 1 || ((dir < 0) != (diff < 0) && (Math.abs(diff) <= Math.abs(prevDiff)))))
     if (Math.abs(diff) > Math.abs(prevDiff)) {
       if ((diff < 0) == (prevDiff < 0)) throw new Error("Broke out of infinite loop in coordsCharInner")
       pos = prevPos

Original file line number	Diff line number	Diff line change
`@@ -479,7 +479,7 @@ function coordsCharInner(cm, lineObj, lineNo, x, y) {`
`479`	`479`	`steps = Math.min(steps, Math.ceil(Math.abs(diff) / diff_change_per_step))`
`480`	`480`	`dir = diff < 0 ? 1 : -1`
`481`	`481`	`}`
`482`		`- } while (steps > 1 \|\| ((dir < 0) != (diff < 0) && (Math.abs(diff) <= Math.abs(prevDiff))))`
	`482`	`+ } while (diff != 0 && (steps > 1 \|\| ((dir < 0) != (diff < 0) && (Math.abs(diff) <= Math.abs(prevDiff)))))`
`483`	`483`	`if (Math.abs(diff) > Math.abs(prevDiff)) {`
`484`	`484`	`if ((diff < 0) == (prevDiff < 0)) throw new Error("Broke out of infinite loop in coordsCharInner")`
`485`	`485`	`pos = prevPos`