Merge remote-tracking branch 'codemirror/master'

Author: jackycute

AUTHORS

@@ -19,6 +19,7 @@ Ahmad M. Zawawi
 ahoward
 Akeksandr Motsjonov
 Alasdair Smith
+AlbertHilb
 Alberto González Palomo
 Alberto Pose
 Albert Xing
@@ -101,10 +102,13 @@ Bharad
 BigBlueHat
 Billy Moon
 binny
+Bjorn Hansen
 B Krishna Chaitanya
 Blaine G
 blukat29
+Bo
 boomyjee
+Bo Peng
 borawjm
 Brad Metcalf
 Brandon Frohs
@@ -137,6 +141,7 @@ Chris Smith
 Christian Gruen
 Christian Oyarzun
 Christian Petrov
+christopherblaser
 Christopher Brown
 Christopher Kramer
 Christopher Mitchell
@@ -202,6 +207,7 @@ Elisée
 Emmanuel Schanzer
 Enam Mijbah Noor
 Eric Allam
+Eric Bogard
 Erik Welander
 eustas
 Fabien Dubosson
@@ -243,6 +249,7 @@ Giovanni Calò
 Glebov Boris
 Glenn Jorde
 Glenn Ruehle
+goldsmcb
 Golevka
 Google Inc.
 Gordon Smith
@@ -266,6 +273,7 @@ Hélio
 Hendrik Wallbaum
 Henrik Haugbølle
 Herculano Campos
+hidaiy
 Hiroyuki Makino
 hitsthings
 Hocdoc
@@ -364,6 +372,7 @@ Justin Hileman
 jwallers@gmail.com
 kaniga
 karevn
+Karol
 Kayur Patel
 Kazuhito Hokamura
 Ken Newman
@@ -387,6 +396,7 @@ Kyle Kelley
 KyleMcNutt
 Lanfei
 Lanny
+laobubu
 Laszlo Vidacs
 leaf corcoran
 Lemmon
@@ -449,6 +459,7 @@ matthewhayes
 Matthew Rathbone
 Matthias Bussonnier
 Matthias BUSSONNIER
+Matt MacPherson
 Matt McDonald
 Matt Pass
 Matt Sacks
@@ -484,17 +495,20 @@ Mike Diaz
 Mike Ivanov
 Mike Kadin
 Mike Kobit
+Milan Szekely
 MinRK
 Miraculix87
 misfo
 mkaminsky11
 mloginov
+Moritz Schubotz (physikerwelt)
 Moritz Schwörer
 Moshe Wajnberg
 mps
 ms
 mtaran-google
 Mu-An Chiou
+Mu-An ✌️ Chiou
 mzabuawala
 Narciso Jaramillo
 Nathan Williams
@@ -531,6 +545,7 @@ overdodactyl
 pablo
 pabloferz
 Pablo Zubieta
+paddya
 Page
 paladox
 Panupong Pasupat
@@ -580,6 +595,7 @@ ray ratchup
 Ray Ratchup
 Remi Nyborg
 Renaud Durlin
+Reynold Xin
 Richard Denton
 Richard van der Meer
 Richard Z.H. Wang
@@ -640,6 +656,7 @@ Sorab Bisht
 spastorelli
 srajanpaliwal
 Stanislav Oaserele
+stan-z
 Stas Kobzar
 Stefan Borsje
 Steffen Beyer
@@ -695,8 +712,10 @@ Travis Heppe
 Triangle717
 Tristan Tarrant
 TSUYUSATO Kitsune
+Tugrul Elmas
 twifkak
 Tyler Long
+Vadzim Ramanenka
 Vaibhav Sagar
 VapidWorx
 Vestimir Markov
@@ -716,6 +735,7 @@ William Jamieson
 William Stein
 Willy
 Wojtek Ptak
+wonderboyjon
 Wu Cheng-Han
 Xavier Mendez
 Yassin N. Hassan

CHANGELOG.md

@@ -1,3 +1,59 @@
+## 5.39.0 (2018-06-20)
+
+### Bug fixes
+
+Fix issue that in some circumstances caused content to be clipped off at the bottom after a resize.
+
+[markdown mode](http://codemirror.net/mode/markdown/): Improve handling of blank lines in HTML tags.
+
+### New features
+
+[stex mode](http://codemirror.net/mode/stex/): Add an `inMathMode` option to start the mode in math mode.
+
+## 5.38.0 (2018-05-21)
+
+### Bug fixes
+
+Improve reliability of noticing a missing mouseup event during dragging.
+
+Make sure `getSelection` is always called on the correct document.
+
+Fix interpretation of line breaks and non-breaking spaces inserted by renderer in contentEditable mode.
+
+Work around some browsers inexplicably making the fake scrollbars focusable.
+
+Make sure `coordsChar` doesn't return positions inside collapsed ranges.
+
+[javascript mode](http://codemirror.net/mode/javascript/): Support block scopes, bindingless catch, bignum suffix, `s` regexp flag.
+
+[markdown mode](http://codemirror.net/mode/markdown/): Adjust a wasteful regexp.
+
+[show-hint addon](http://codemirror.net/doc/manual.html#addon_show-hint): Allow opening the control without any item selected.
+
+### New features
+
+New theme: [darcula](http://codemirror.net/demo/theme.html#darcula).
+
+[dialog addon](http://codemirror.net/doc/manual.html#addon_dialog): Add a CSS class (`dialog-opened`) to the editor when a dialog is open.
+
+## 5.37.0 (2018-04-20)
+
+### Bug fixes
+
+Suppress keypress events during composition, for platforms that don't properly do this themselves.
+
+[xml-fold addon](http://codemirror.net/demo/folding.html): Improve handling of line-wrapped opening tags.
+
+[javascript mode](http://codemirror.net/mode/javascript/): Improve TypeScript support.
+
+[python mode](http://codemirror.net/mode/python/): Highlight expressions inside format strings.
+
+### New features
+
+[vim bindings](http://codemirror.net/demo/vim.html): Add support for '(' and ')' movement.
+
+New themes: [idea](http://codemirror.net/demo/theme.html#idea), [ssms](http://codemirror.net/demo/theme.html#ssms), [gruvbox-dark](http://codemirror.net/demo/theme.html#gruvbox-dark).
+
 ## 5.36.0 (2018-03-20)
 
 ### Bug fixes

addon/dialog/dialog.js

@@ -25,6 +25,7 @@
     } else { // Assuming it's a detached DOM element.
       dialog.appendChild(template);
     }
+    CodeMirror.addClass(wrap, 'dialog-opened');
     return dialog;
   }
 
@@ -47,6 +48,7 @@
       } else {
         if (closed) return;
         closed = true;
+        CodeMirror.rmClass(dialog.parentNode, 'dialog-opened');
         dialog.parentNode.removeChild(dialog);
         me.focus();
 
@@ -102,6 +104,7 @@
     function close() {
       if (closed) return;
       closed = true;
+      CodeMirror.rmClass(dialog.parentNode, 'dialog-opened');
       dialog.parentNode.removeChild(dialog);
       me.focus();
     }
@@ -141,6 +144,7 @@
       if (closed) return;
       closed = true;
       clearTimeout(doneTimer);
+      CodeMirror.rmClass(dialog.parentNode, 'dialog-opened');
       dialog.parentNode.removeChild(dialog);
     }
 

addon/hint/show-hint.js

@@ -98,7 +98,7 @@
       var pos = this.cm.getCursor(), line = this.cm.getLine(pos.line);
       if (pos.line != this.startPos.line || line.length - pos.ch != this.startLen - this.startPos.ch ||
           pos.ch < this.startPos.ch || this.cm.somethingSelected() ||
-          (pos.ch && this.options.closeCharacters.test(line.charAt(pos.ch - 1)))) {
+          (!pos.ch || this.options.closeCharacters.test(line.charAt(pos.ch - 1)))) {
         this.close();
       } else {
         var self = this;
@@ -200,7 +200,8 @@
     var widget = this, cm = completion.cm;
 
     var hints = this.hints = document.createElement("ul");
-    hints.className = "CodeMirror-hints";
+    var theme = completion.cm.options.theme;
+    hints.className = "CodeMirror-hints " + theme;
     this.selectedHint = data.selectedHint || 0;
 
     var completions = data.list;
@@ -333,7 +334,7 @@
         i = avoidWrap ? 0  : this.data.list.length - 1;
       if (this.selectedHint == i) return;
       var node = this.hints.childNodes[this.selectedHint];
-      node.className = node.className.replace(" " + ACTIVE_HINT_ELEMENT_CLASS, "");
+      if (node) node.className = node.className.replace(" " + ACTIVE_HINT_ELEMENT_CLASS, "");
       node = this.hints.childNodes[this.selectedHint = i];
       node.className += " " + ACTIVE_HINT_ELEMENT_CLASS;
       if (node.offsetTop < this.hints.scrollTop)

addon/hint/sql-hint.js

@@ -275,10 +275,23 @@
     if (search.charAt(0) == "." || search.charAt(0) == identifierQuote) {
       start = nameCompletion(cur, token, result, editor);
     } else {
-      addMatches(result, search, defaultTable, function(w) {return w;});
-      addMatches(result, search, tables, function(w) {return w;});
+      addMatches(result, search, defaultTable, function(w) {return {text:w, className: "CodeMirror-hint-table CodeMirror-hint-default-table"};});
+      addMatches(
+          result,
+          search,
+          tables,
+          function(w) {
+              if (typeof w === 'object') {
+                  w.className =  "CodeMirror-hint-table";
+              } else {
+                  w = {text: w, className: "CodeMirror-hint-table"};
+              }
+
+              return w;
+          }
+      );
       if (!disableKeywords)
-        addMatches(result, search, keywords, function(w) {return w.toUpperCase();});
+        addMatches(result, search, keywords, function(w) {return {text: w.toUpperCase(), className: "CodeMirror-hint-keyword"};});
     }
 
     return {list: result, from: Pos(cur.line, start), to: Pos(cur.line, end)};

addon/lint/json-lint.js

@@ -23,6 +23,9 @@ CodeMirror.registerHelper("lint", "json", function(text) {
     }
     return found;
   }
+  // for jsonlint's web dist jsonlint is exported as an object with a single property parser, of which parseError
+  // is a subproperty
+  var jsonlint = window.jsonlint.parser || window.jsonlint
   jsonlint.parseError = function(str, hash) {
     var loc = hash.loc;
     found.push({from: CodeMirror.Pos(loc.first_line - 1, loc.first_column),

demo/theme.html

@@ -21,6 +21,7 @@
 <link rel="stylesheet" href="../theme/eclipse.css">
 <link rel="stylesheet" href="../theme/elegant.css">
 <link rel="stylesheet" href="../theme/erlang-dark.css">
+<link rel="stylesheet" href="../theme/gruvbox-dark.css">
 <link rel="stylesheet" href="../theme/hopscotch.css">
 <link rel="stylesheet" href="../theme/icecoder.css">
 <link rel="stylesheet" href="../theme/isotope.css">
@@ -55,6 +56,7 @@
 <link rel="stylesheet" href="../theme/xq-light.css">
 <link rel="stylesheet" href="../theme/yeti.css">
 <link rel="stylesheet" href="../theme/idea.css">
+<link rel="stylesheet" href="../theme/darcula.css">
 <link rel="stylesheet" href="../theme/zenburn.css">
 <script src="../lib/codemirror.js"></script>
 <script src="../mode/javascript/javascript.js"></script>
@@ -104,12 +106,14 @@ <h2>Theme Demo</h2>
     <option>blackboard</option>
     <option>cobalt</option>
     <option>colorforth</option>
+    <option>darcula</option>
     <option>dracula</option>
     <option>duotone-dark</option>
     <option>duotone-light</option>
     <option>eclipse</option>
     <option>elegant</option>
     <option>erlang-dark</option>
+    <option>gruvbox-dark</option>
     <option>hopscotch</option>
     <option>icecoder</option>
     <option>idea</option>

doc/manual.html

@@ -69,7 +69,7 @@
 <section class=first id=overview>
     <h2 style="position: relative">
       User manual and reference guide
-      <span style="color: #888; font-size: 1rem; position: absolute; right: 0; bottom: 0">version 5.36.1</span>
+      <span style="color: #888; font-size: 1rem; position: absolute; right: 0; bottom: 0">version 5.39.1</span>
     </h2>
 
     <p>CodeMirror is a code-editor component that can be embedded in
@@ -292,6 +292,17 @@ <h2>Configuration</h2>
       character. By default, a red dot (<span style="color: red">•</span>)
       is shown, with a title tooltip to indicate the character code.</dd>
 
+      <dt id="option_direction"><code><strong>direction</strong>: "ltr" | "rtl"</code></dt>
+      <dd>Flips overall layout and selects base paragraph direction to
+      be left-to-right or right-to-left.  Default is "ltr".
+      CodeMirror applies the Unicode Bidirectional Algorithm to each
+      line, but does not autodetect base direction — it's set to the
+      editor direction for all lines.  The resulting order is
+      sometimes wrong when base direction doesn't match user intent
+      (for example, leading and trailing punctuation jumps to the
+      wrong side of the line).  Therefore, it's helpful for
+      multilingual input to let users toggle this option.
+
       <dt id="option_rtlMoveVisually"><code><strong>rtlMoveVisually</strong>: boolean</code></dt>
       <dd>Determines whether horizontal cursor movement through
       right-to-left (Arabic, Hebrew) text is visual (pressing the left

doc/realworld.html

@@ -70,6 +70,7 @@ <h2>CodeMirror real-world uses</h2>
       <li><a href="http://ireneros.com/deck/deck.js-codemirror/introduction/#textarea-code">Deck.js integration</a> (slides with editors)</li>
       <li><a href="http://www.dbninja.com">DbNinja</a> (MySQL access interface)</li>
       <li><a href="http://www.ecsspert.com/">eCSSpert</a> (CSS demos and experiments)</li>
+      <li><a href="https://edabit.com">Edabit</a> (coding challenges)</li>
       <li><a href="http://elm-lang.org/Examples.elm">Elm language examples</a></li>
       <li><a href="http://eloquentjavascript.net/chapter1.html">Eloquent JavaScript</a> (book)</li>
       <li><a href="http://emmet.io">Emmet</a> (fast XML editing)</li>
@@ -101,6 +102,7 @@ <h2>CodeMirror real-world uses</h2>
       <li><a href="https://joelpinheiro.github.io/itrading/">iTrading</a> (Algorithmic Trading)</li>
       <li><a href="http://i-mos.org/imos/">i-MOS</a> (modeling and simulation platform)</li>
       <li><a href="http://www.janvas.com/">Janvas</a> (vector graphics editor)</li>
+      <li><a href="https://code.wetrafa.xyz/">JdBEdit</a> (web IDE)</li>
       <li><a href="http://extensions.joomla.org/extensions/edition/editors/8723">Joomla plugin</a></li>
       <li><a href="http://jqfundamentals.com/">jQuery fundamentals</a> (interactive tutorial)</li>
       <li><a href="http://jsbin.com">jsbin.com</a> (JS playground)</li>
@@ -144,6 +146,7 @@ <h2>CodeMirror real-world uses</h2>
       <li><a href="http://refork.com/">Refork</a> (animation demo gallery and sharing)</li>
       <li><a href="http://sagecell.sagemath.org">SageMathCell</a> (interactive mathematical software)</li>
       <li><a href="https://cloud.sagemath.com/">SageMathCloud</a> (interactive mathematical software environment)</li>
+      <li><a href="https://github.com/szekelymilan/salvare">salvare</a> (real-time collaborative code editor)</li>
       <li><a href="https://chrome.google.com/webstore/detail/servephp/mnpikomdchjhkhbhmbboehfdjkobbfpo">ServePHP</a> (PHP code testing in Chrome dev tools)</li>
       <li><a href="http://scala-lang.org/blog/2017/02/20/introducing-scastie.html">Scastie</a> (Scala playground)</li>
       <li><a href="https://www.shadertoy.com/">Shadertoy</a> (shader sharing)</li>