fix: call preloadedWebView in case of incomplete Bundle (#189) (#190)

* fix: re-init sPreloadWebView in preloadedWebView for incomplete Bundle (#189)

* chore: bump to 4.2.1

Author: CAMOBAP

CHANGES.md

@@ -1,5 +1,9 @@
 # Changelog
 
+# 4.2.1
+
+- Fix: java.lang.NullPointerException: during WebView preparation (#189)
+
 # 4.2.0
 
 - Fix: java.lang.IllegalStateException: The specified child already has a parent for reloadedWebView in compose-sdk

compose-sdk/build.gradle

@@ -20,11 +20,11 @@ android {
         // See https://developer.android.com/studio/publish/versioning
         // versionCode must be integer and be incremented by one for every new update
         // android system uses this to prevent downgrades
-        versionCode 48
+        versionCode 49
 
         // version number visible to the user
         // should follow semantic versioning (See https://semver.org)
-        versionName "4.2.0"
+        versionName "4.2.1"
 
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
         consumerProguardFiles "consumer-rules.pro"

sdk/build.gradle

@@ -28,11 +28,11 @@ android {
         // See https://developer.android.com/studio/publish/versioning
         // versionCode must be integer and be incremented by one for every new update
         // android system uses this to prevent downgrades
-        versionCode 48
+        versionCode 49
 
         // version number visible to the user
         // should follow semantic versioning (See https://semver.org)
-        versionName "4.2.0"
+        versionName "4.2.1"
 
         buildConfigField 'String', 'VERSION_NAME', "\"${defaultConfig.versionName}_${defaultConfig.versionCode}\""
 

sdk/src/main/java/com/hcaptcha/sdk/HCaptchaDialogFragment.java

@@ -124,6 +124,7 @@ public void onCreate(Bundle savedInstanceState) {
                 // According to Firebase Analytics, there are cases where Bundle args are empty.
                 // > 90% of these cases occur on Android 6, and the count of crashes <<< the count of sessions.
                 // This is a quick fix to prevent crashes in production
+                HCaptchaLog.w("DialogFragment.onCreate getArguments is incomplete");
                 if (listener != null) {
                     listener.onFailure(new HCaptchaException(HCaptchaError.ERROR));
                 }
@@ -362,6 +363,10 @@ private void prepareWebView(@NonNull View rootView, @NonNull HCaptchaConfig conf
             final ViewGroup parent = (ViewGroup) rootView;
             final int index = parent.indexOfChild(stub);
             parent.removeView(stub);
+            if (sPreloadWebView == null) {
+                HCaptchaLog.w("DialogFragment.prepareWebView: sPreloadWebView cold init");
+                sPreloadWebView = new HCaptchaWebView(requireContext());
+            }
             if (sPreloadWebView.getParent() != null) {
                 ((ViewGroup) sPreloadWebView.getParent()).removeView(sPreloadWebView);
             }
@@ -378,6 +383,8 @@ private void prepareWebView(@NonNull View rootView, @NonNull HCaptchaConfig conf
                     return view.performClick();
                 });
             }
+        } else {
+            HCaptchaLog.w("DialogFragment.prepareWebView invalid state " + stub.getClass());
         }
     }
 }