New member: void NimBLEDevice::setDeviceAppearance(const uint16_t appearance) suggestion!

[Berg0162]

void NimBLEDevice::setDeviceName(const std::string &deviceName) is a valid member of NimBLEDevice
I would suggest to create a new member: void NimBLEDevice::setDeviceAppearance(const uint16_t appearance) of NimBLEDevice.
At present my workaround code looks:

.
#include <nimble/nimble/host/services/gap/include/services/gap/ble_svc_gap.h>
.

void server_setupGA(void)
{
  // Set the Generic Access Appearance value from default: [0] --> Unknown to [1152] --> Generic Cycling
    int RespErr = ble_svc_gap_device_appearance_set(client_GA_Appearance_Value);
    if(RespErr == 0) {
      DEBUG_PRINTF("Successfully Set Generic Access Appearance Chr value to:  [%d] Generic Cycling\n", client_GA_Appearance_Value); 
    } else {
      DEBUG_PRINTLN("Unable to Set Generic Access Appearance Chr value!");      
    } 
  // Set Generic Access Device Name Chr to a value
    RespErr = ble_svc_gap_device_name_set((const char*)client_GA_DeviceName_Str.c_str());
    if(RespErr == 0) {
      DEBUG_PRINTF("Successfully Set Generic Access Device Name Chr value to: [%s]\n", client_GA_DeviceName_Str.c_str()); 
    } else {
      DEBUG_PRINTLN("Unable to Set Generic Access Device Name Chr value!");      
    } 
}

[h2zero]

This is a great idea, I would be more than happy to accept a PR for this.

[Berg0162]

I am not allowed to start a Pull Request!
But my suggestion is the following:

/**
 * @brief Set the NimBLEDevice Appearance.
 * @param [in] deviceAppearance The appearance to set.
 */
bool NimBLEDevice::setDeviceAppearance(const uint16_t deviceAppearance) {
    int rc = ble_svc_gap_device_appearance_set(deviceAppearance);
    if (rc != 0) {
        NIMBLE_LOGE(LOG_TAG, "Device appearance not set - out of range");
        return false;
    }

    return true;
} // setDeviceAppearance