Fix clippy lints

Author: GuillaumeGomez

gio/src/file.rs

@@ -537,7 +537,7 @@ impl<O: IsA<File>> FileExtManual for O {
                 slice::from_raw_parts(file_contents as *const u8, file_size as usize)
             };
 
-            (&mut *callback.1.borrow_mut().get_mut())(data).into_glib()
+            (*callback.1.borrow_mut().get_mut())(data).into_glib()
         }
 
         let user_data = Box::into_raw(user_data) as *mut _;
@@ -573,7 +573,7 @@ impl<O: IsA<File>> FileExtManual for O {
             let callback: &Option<RefCell<Box<dyn Fn(bool, u64, u64, u64) + 'static>>> =
                 &*(user_data as *mut _);
             if let Some(ref callback) = *callback {
-                (&mut *callback.borrow_mut())(reporting, current_size, num_dirs, num_files)
+                (*callback.borrow_mut())(reporting, current_size, num_dirs, num_files)
             } else {
                 panic!("cannot get closure...")
             };

gio/src/pollable_input_stream.rs

@@ -80,8 +80,7 @@ impl<O: IsA<PollableInputStream>> PollableInputStreamExtManual for O {
         ) -> glib::ffi::gboolean {
             let func: &RefCell<F> = &*(func as *const RefCell<F>);
             let mut func = func.borrow_mut();
-            (&mut *func)(PollableInputStream::from_glib_borrow(stream).unsafe_cast_ref())
-                .into_glib()
+            (*func)(PollableInputStream::from_glib_borrow(stream).unsafe_cast_ref()).into_glib()
         }
         unsafe extern "C" fn destroy_closure<O, F>(ptr: glib::ffi::gpointer) {
             Box::<RefCell<F>>::from_raw(ptr as *mut _);

gio/src/pollable_output_stream.rs

@@ -75,8 +75,7 @@ impl<O: IsA<PollableOutputStream>> PollableOutputStreamExtManual for O {
         ) -> glib::ffi::gboolean {
             let func: &RefCell<F> = &*(func as *const RefCell<F>);
             let mut func = func.borrow_mut();
-            (&mut *func)(PollableOutputStream::from_glib_borrow(stream).unsafe_cast_ref())
-                .into_glib()
+            (*func)(PollableOutputStream::from_glib_borrow(stream).unsafe_cast_ref()).into_glib()
         }
         unsafe extern "C" fn destroy_closure<O, F>(ptr: glib::ffi::gpointer) {
             Box::<RefCell<F>>::from_raw(ptr as *mut _);

gio/src/socket.rs

@@ -355,7 +355,7 @@ impl<O: IsA<Socket>> SocketExtManual for O {
         ) -> glib::ffi::gboolean {
             let func: &RefCell<F> = &*(func as *const RefCell<F>);
             let mut func = func.borrow_mut();
-            (&mut *func)(
+            (*func)(
                 Socket::from_glib_borrow(socket).unsafe_cast_ref(),
                 from_glib(condition),
             )

glib/src/object.rs

@@ -322,7 +322,7 @@ impl fmt::Debug for ObjectRef {
     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
         let type_ = unsafe {
             let klass = (*self.inner.as_ptr()).g_type_instance.g_class as *const ObjectClass;
-            (&*klass).type_()
+            (*klass).type_()
         };
 
         f.debug_struct("ObjectRef")

glib/src/source.rs

@@ -109,14 +109,14 @@ unsafe extern "C" fn trampoline<F: FnMut() -> Continue + Send + 'static>(
     func: gpointer,
 ) -> gboolean {
     let func: &RefCell<F> = &*(func as *const RefCell<F>);
-    (&mut *func.borrow_mut())().into_glib()
+    (*func.borrow_mut())().into_glib()
 }
 
 unsafe extern "C" fn trampoline_local<F: FnMut() -> Continue + 'static>(
     func: gpointer,
 ) -> gboolean {
     let func: &ThreadGuard<RefCell<F>> = &*(func as *const ThreadGuard<RefCell<F>>);
-    (&mut *func.get_ref().borrow_mut())().into_glib()
+    (*func.get_ref().borrow_mut())().into_glib()
 }
 
 unsafe extern "C" fn destroy_closure<F: FnMut() -> Continue + Send + 'static>(ptr: gpointer) {
@@ -143,7 +143,7 @@ unsafe extern "C" fn trampoline_child_watch<F: FnMut(Pid, i32) + Send + 'static>
     func: gpointer,
 ) {
     let func: &RefCell<F> = &*(func as *const RefCell<F>);
-    (&mut *func.borrow_mut())(Pid(pid), status)
+    (*func.borrow_mut())(Pid(pid), status)
 }
 
 unsafe extern "C" fn trampoline_child_watch_local<F: FnMut(Pid, i32) + 'static>(
@@ -152,7 +152,7 @@ unsafe extern "C" fn trampoline_child_watch_local<F: FnMut(Pid, i32) + 'static>(
     func: gpointer,
 ) {
     let func: &ThreadGuard<RefCell<F>> = &*(func as *const ThreadGuard<RefCell<F>>);
-    (&mut *func.get_ref().borrow_mut())(Pid(pid), status)
+    (*func.get_ref().borrow_mut())(Pid(pid), status)
 }
 
 unsafe extern "C" fn destroy_closure_child_watch<F: FnMut(Pid, i32) + Send + 'static>(
@@ -187,7 +187,7 @@ unsafe extern "C" fn trampoline_unix_fd<
     func: gpointer,
 ) -> gboolean {
     let func: &RefCell<F> = &*(func as *const RefCell<F>);
-    (&mut *func.borrow_mut())(fd, from_glib(condition)).into_glib()
+    (*func.borrow_mut())(fd, from_glib(condition)).into_glib()
 }
 
 #[cfg(any(unix, feature = "dox"))]
@@ -200,7 +200,7 @@ unsafe extern "C" fn trampoline_unix_fd_local<
     func: gpointer,
 ) -> gboolean {
     let func: &ThreadGuard<RefCell<F>> = &*(func as *const ThreadGuard<RefCell<F>>);
-    (&mut *func.get_ref().borrow_mut())(fd, from_glib(condition)).into_glib()
+    (*func.get_ref().borrow_mut())(fd, from_glib(condition)).into_glib()
 }
 
 #[cfg(any(unix, feature = "dox"))]

glib/src/variant.rs

@@ -650,7 +650,7 @@ impl Variant {
         unsafe {
             let data = Box::new(data);
             let (data_ptr, len) = {
-                let data = (&*data).as_ref();
+                let data = (*data).as_ref();
                 (data.as_ptr(), data.len())
             };
 
@@ -685,7 +685,7 @@ impl Variant {
     pub unsafe fn from_data_with_type_trusted<A: AsRef<[u8]>>(data: A, type_: &VariantTy) -> Self {
         let data = Box::new(data);
         let (data_ptr, len) = {
-            let data = (&*data).as_ref();
+            let data = (*data).as_ref();
             (data.as_ptr(), data.len())
         };
 
@@ -1572,13 +1572,7 @@ where
     }
 
     let mut builder = crate::GStringBuilder::default();
-    write!(
-        &mut builder,
-        "a{{{}{}}}",
-        key_type.as_str(),
-        value_type.as_str()
-    )
-    .unwrap();
+    write!(builder, "a{{{}{}}}", key_type.as_str(), value_type.as_str()).unwrap();
 
     Cow::Owned(VariantType::from_string(builder.into_string()).unwrap())
 }