gtask: fix memory leak in when calling g_task_return_value

Matteo Biggio · Matteo Biggio · commit 845807684cdc · 2022-02-02T12:14:43.000+01:00
The g_task_return_value function does not take ownership of the input GValue pointer, but just borrows it to make a copy: https://developer-old.gnome.org/gio/unstable/GTask.html#g-task-return-value The Rust caller should take care of the deallocation.
diff --git a/gio/src/task.rs b/gio/src/task.rs
@@ -255,7 +255,7 @@ macro_rules! task_impl {
                     Ok(v) => unsafe {
                         ffi::g_task_return_value(
                             self.to_glib_none().0,
-                            v.to_value().to_glib_full() as *mut _,
+                            v.to_value().to_glib_none().0 as *mut _,
                         )
                     },
                     #[cfg(not(feature = "v2_64"))]

Original file line number	Diff line number	Diff line change
`@@ -255,7 +255,7 @@ macro_rules! task_impl {`
`255`	`255`	`Ok(v) => unsafe {`
`256`	`256`	`ffi::g_task_return_value(`
`257`	`257`	`self.to_glib_none().0,`
`258`		`- v.to_value().to_glib_full() as *mut _,`
	`258`	`+ v.to_value().to_glib_none().0 as *mut _,`
`259`	`259`	`)`
`260`	`260`	`},`
`261`	`261`	`#[cfg(not(feature = "v2_64"))]`