Skip to content

Commit 0e0e54e

Browse files
committed
unix_fd_list: Port to safe-io
1 parent 25d29e6 commit 0e0e54e

File tree

1 file changed

+18
-16
lines changed

1 file changed

+18
-16
lines changed

gio/src/unix_fd_list.rs

Lines changed: 18 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
// Take a look at the license at the top of the repository in the LICENSE file.
22

33
#[cfg(unix)]
4-
use std::os::unix::io::{AsRawFd, IntoRawFd, RawFd};
4+
use std::os::unix::io::{AsFd, AsRawFd, BorrowedFd, FromRawFd, IntoRawFd, OwnedFd, RawFd};
55
use std::{mem, ptr};
66

77
use glib::{prelude::*, translate::*};
88
#[cfg(all(not(unix), docsrs))]
9-
use socket::{AsRawFd, IntoRawFd, RawFd};
9+
use socket::{AsFd, AsRawFd, BorrowedFd, FromRawFd, IntoRawFd, OwnedFd, RawFd};
1010

1111
use crate::{ffi, UnixFDList};
1212

@@ -30,12 +30,12 @@ mod sealed {
3030

3131
pub trait UnixFDListExtManual: sealed::Sealed + IsA<UnixFDList> + Sized {
3232
#[doc(alias = "g_unix_fd_list_append")]
33-
fn append<T: AsRawFd>(&self, fd: T) -> Result<i32, glib::Error> {
33+
fn append(&self, fd: impl AsFd) -> Result<i32, glib::Error> {
3434
unsafe {
3535
let mut error = ptr::null_mut();
3636
let ret = ffi::g_unix_fd_list_append(
3737
self.as_ref().to_glib_none().0,
38-
fd.as_raw_fd(),
38+
fd.as_fd().as_raw_fd(),
3939
&mut error,
4040
);
4141
if error.is_null() {
@@ -47,39 +47,41 @@ pub trait UnixFDListExtManual: sealed::Sealed + IsA<UnixFDList> + Sized {
4747
}
4848

4949
#[doc(alias = "g_unix_fd_list_get")]
50-
fn get(&self, index_: i32) -> Result<RawFd, glib::Error> {
50+
fn get(&self, index_: i32) -> Result<OwnedFd, glib::Error> {
5151
unsafe {
5252
let mut error = ptr::null_mut();
53-
let ret = ffi::g_unix_fd_list_get(self.as_ref().to_glib_none().0, index_, &mut error);
53+
let raw_fd =
54+
ffi::g_unix_fd_list_get(self.as_ref().to_glib_none().0, index_, &mut error);
55+
let fd = OwnedFd::from_raw_fd(raw_fd);
5456
if error.is_null() {
55-
Ok(ret)
57+
Ok(fd)
5658
} else {
5759
Err(from_glib_full(error))
5860
}
5961
}
6062
}
6163

6264
#[doc(alias = "g_unix_fd_list_peek_fds")]
63-
64-
fn peek_fds(&self) -> Vec<RawFd> {
65+
fn peek_fds(&self) -> &[BorrowedFd<'_>] {
6566
unsafe {
6667
let mut length = mem::MaybeUninit::uninit();
67-
let ret = FromGlibContainer::from_glib_none_num(
68-
ffi::g_unix_fd_list_peek_fds(self.as_ref().to_glib_none().0, length.as_mut_ptr()),
68+
std::slice::from_raw_parts(
69+
ffi::g_unix_fd_list_peek_fds(self.as_ref().to_glib_none().0, length.as_mut_ptr())
70+
as *const BorrowedFd,
6971
length.assume_init() as usize,
70-
);
71-
ret
72+
)
7273
}
7374
}
75+
7476
#[doc(alias = "g_unix_fd_list_steal_fds")]
75-
fn steal_fds(&self) -> Vec<RawFd> {
77+
fn steal_fds(&self) -> Vec<OwnedFd> {
7678
unsafe {
7779
let mut length = mem::MaybeUninit::uninit();
78-
let ret = FromGlibContainer::from_glib_full_num(
80+
let ret: Vec<RawFd> = FromGlibContainer::from_glib_full_num(
7981
ffi::g_unix_fd_list_steal_fds(self.as_ref().to_glib_none().0, length.as_mut_ptr()),
8082
length.assume_init() as usize,
8183
);
82-
ret
84+
ret.into_iter().map(|fd| OwnedFd::from_raw_fd(fd)).collect()
8385
}
8486
}
8587
}

0 commit comments

Comments
 (0)