PovRay export (openscad#5288)

folkertvanheusden · web-flow · commit fc912cb28914 · 2024-10-04T22:52:50.000-04:00
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -832,6 +832,8 @@ set(CORE_SOURCES
   src/io/export_pdf.cc
   src/io/export_stl.cc
   src/io/export_svg.cc
+  src/io/export_pov.cc
+  src/io/export_param.cc
   src/io/export_wrl.cc
   src/io/fileutils.cc
   src/io/import_amf.cc
diff --git a/resources/common.qrc.in b/resources/common.qrc.in
@@ -53,6 +53,8 @@
     <file>icons/svg-default/export-obj-white.svg</file>
     <file>icons/svg-default/export-off.svg</file>
     <file>icons/svg-default/export-off-white.svg</file>
+    <file>icons/svg-default/export-pov.svg</file>
+    <file>icons/svg-default/export-pov-white.svg</file>
     <file>icons/svg-default/export-pdf.svg</file>
     <file>icons/svg-default/export-pdf-white.svg</file>
     <file>icons/svg-default/export-png.svg</file>
diff --git a/resources/icons/svg-default/export-pov-white.svg b/resources/icons/svg-default/export-pov-white.svg
diff --git a/resources/icons/svg-default/export-pov.svg b/resources/icons/svg-default/export-pov.svg
diff --git a/resources/icons/svg-default/icons.scad b/resources/icons/svg-default/icons.scad
@@ -27,6 +27,7 @@ icons = [
     ["export-csg"],
     ["export-pdf"],
     ["export-png"],
+    ["export-pov"],
     ["preview"],
     ["render"],
     ["send"],
@@ -84,6 +85,7 @@ icon(selected_icon) {
     export("CSG");
     export("PDF");
     export("PNG");
+    export("POV");
     preview();
     render_();
     send();
diff --git a/scripts/github-ci.sh b/scripts/github-ci.sh
@@ -31,7 +31,7 @@ do_build() {
 	mkdir "$BUILDDIR"
 	(
 		cd "$BUILDDIR"
-		cmake -DCMAKE_BUILD_TYPE=Release -DCMAKE_UNITY_BUILD=ON -DPROFILE=ON -DUSE_BUILTIN_OPENCSG=1 ${EXPERIMENTAL} ${PYTHON_DEFINE} ${USE_QT6} .. && make $PARALLEL_MAKE
+		cmake -DCMAKE_BUILD_TYPE=Release -DCMAKE_UNITY_BUILD=OFF -DPROFILE=ON -DUSE_BUILTIN_OPENCSG=1 ${EXPERIMENTAL} ${PYTHON_DEFINE} ${USE_QT6} .. && make $PARALLEL_MAKE
 	)
 	if [[ $? != 0 ]]; then
 		echo "Build failure"
diff --git a/src/geometry/Polygon2d.cc b/src/geometry/Polygon2d.cc
@@ -13,6 +13,7 @@
 #include "geometry/cgal/cgalutils.h"
 #include "Feature.h"
 #include "geometry/PolySet.h"
+#include "glview/RenderSettings.h"
 
 
 Polygon2d::Polygon2d(Outline2d outline) : sanitized(true) {
diff --git a/src/gui/MainWindow.cc b/src/gui/MainWindow.cc
@@ -232,6 +232,8 @@ QAction *getExport3DAction(const MainWindow *mainWindow) {
     return mainWindow->fileActionExportOFF;
   } else if (format == "WRL") {
     return mainWindow->fileActionExportWRL;
+  } else if (format == "POV") {
+    return mainWindow->fileActionExportPOV;
   } else if (format == "AMF") {
     return mainWindow->fileActionExportAMF;
   } else if (format == "3MF") {
@@ -494,6 +496,7 @@ MainWindow::MainWindow(const QStringList& filenames)
   connect(this->fileActionExportOBJ, SIGNAL(triggered()), this, SLOT(actionExportOBJ()));
   connect(this->fileActionExportOFF, SIGNAL(triggered()), this, SLOT(actionExportOFF()));
   connect(this->fileActionExportWRL, SIGNAL(triggered()), this, SLOT(actionExportWRL()));
+  connect(this->fileActionExportPOV, SIGNAL(triggered()), this, SLOT(actionExportPOV()));
   connect(this->fileActionExportAMF, SIGNAL(triggered()), this, SLOT(actionExportAMF()));
   connect(this->fileActionExportDXF, SIGNAL(triggered()), this, SLOT(actionExportDXF()));
   connect(this->fileActionExportSVG, SIGNAL(triggered()), this, SLOT(actionExportSVG()));
@@ -651,6 +654,7 @@ MainWindow::MainWindow(const QStringList& filenames)
   initActionIcon(fileActionExportOBJ, ":/icons/svg-default/export-obj.svg", ":/icons/svg-default/export-obj-white.svg");
   initActionIcon(fileActionExportOFF, ":/icons/svg-default/export-off.svg", ":/icons/svg-default/export-off-white.svg");
   initActionIcon(fileActionExportWRL, ":/icons/svg-default/export-wrl.svg", ":/icons/svg-default/export-wrl-white.svg");
+  initActionIcon(fileActionExportPOV, ":/icons/svg-default/export-pov.svg", ":/icons/svg-default/export-pov-white.svg");
   initActionIcon(fileActionExportDXF, ":/icons/svg-default/export-dxf.svg", ":/icons/svg-default/export-dxf-white.svg");
   initActionIcon(fileActionExportSVG, ":/icons/svg-default/export-svg.svg", ":/icons/svg-default/export-svg-white.svg");
   initActionIcon(fileActionExportCSG, ":/icons/svg-default/export-csg.svg", ":/icons/svg-default/export-csg-white.svg");
@@ -2958,6 +2962,11 @@ void MainWindow::actionExportWRL()
   actionExport(FileFormat::WRL, "WRL", ".wrl", 3);
 }
 
+void MainWindow::actionExportPOV()
+{
+  actionExport(FileFormat::POV, "POV", ".pov", 3);
+}
+
 void MainWindow::actionExportAMF()
 {
   actionExport(FileFormat::AMF, "AMF", ".amf", 3);
diff --git a/src/gui/MainWindow.h b/src/gui/MainWindow.h
@@ -268,6 +268,7 @@ private slots:
   void actionExportOBJ();
   void actionExportOFF();
   void actionExportWRL();
+  void actionExportPOV();
   void actionExportAMF();
   void actionExportDXF();
   void actionExportSVG();
diff --git a/src/gui/MainWindow.ui b/src/gui/MainWindow.ui
@@ -229,6 +229,7 @@
      </property>
      <addaction name="fileActionExportSTL"/>
      <addaction name="fileActionExportOBJ"/>
+     <addaction name="fileActionExportPOV"/>
      <addaction name="fileActionExportOFF"/>
      <addaction name="fileActionExportWRL"/>
      <addaction name="fileActionExportAMF"/>
@@ -1048,6 +1049,11 @@
     <string>Export as &amp;OBJ...</string>
    </property>
   </action>
+  <action name="fileActionExportPOV">
+   <property name="text">
+    <string>Export as &amp;POV...</string>
+   </property>
+  </action>
   <action name="fileActionExportOFF">
    <property name="text">
     <string>Export as &amp;OFF...</string>
diff --git a/src/gui/Settings.cc b/src/gui/Settings.cc
@@ -134,8 +134,8 @@ SettingsEntryString Settings::localSlicerExecutable("printing", "localSlicerExec
 SettingsEntryEnum Settings::localSlicerFileFormat("printing", "localSlicerFileFormat", {{"STL", "STL"}, {"OFF", "OFF"}, {"AMF", "AMF"}, {"3MF", "3MF"}}, "STL");
 
 SettingsEntryBool Settings::exportUseAsciiSTL("export", "useAsciiSTL", false);
-SettingsEntryEnum Settings::renderBackend3D("advanced", "renderBackend3D", {{"CGAL", "CGAL (old/slow)"}, {"Manifold", "Manifold (new/fast)"}}, "CGAL");  
-SettingsEntryEnum Settings::toolbarExport3D("advanced", "toolbarExport3D", {{"none", "none"}, {"STL", "STL"}, {"OFF", "OFF"}, {"WRL", "WRL"}, {"AMF", "AMF"}, {"3MF", "3MF"}}, "STL");
+SettingsEntryEnum Settings::renderBackend3D("advanced", "renderBackend3D", {{"CGAL", "CGAL (old/slow)"}, {"Manifold", "Manifold (new/fast)"}}, "CGAL");
+SettingsEntryEnum Settings::toolbarExport3D("advanced", "toolbarExport3D", {{"none", "none"}, {"STL", "STL"}, {"OFF", "OFF"}, {"WRL", "WRL"}, {"AMF", "AMF"}, {"3MF", "3MF"}, {"POV", "POV"}}, "STL");
 SettingsEntryEnum Settings::toolbarExport2D("advanced", "toolbarExport2D", {{"none", "none"}, {"DXF", "DXF"}, {"SVG", "SVG"}, {"PDF", "PDF"}}, "none");
 
 SettingsEntryBool Settings::summaryCamera("summary", "camera", false);
diff --git a/src/io/export.cc b/src/io/export.cc
@@ -64,7 +64,8 @@ return format == FileFormat::ASCIISTL ||
   format == FileFormat::AMF ||
   format == FileFormat::_3MF ||
   format == FileFormat::NEFDBG ||
-  format == FileFormat::NEF3;
+  format == FileFormat::NEF3 ||
+  format == FileFormat::POV;
 }
 
 bool is2D(const FileFormat format) {
@@ -106,6 +107,9 @@ void exportFile(const std::shared_ptr<const Geometry>& root_geom, std::ostream&
   case FileFormat::PDF:
     export_pdf(root_geom, output, exportInfo);
     break;
+  case FileFormat::POV:
+    export_pov(root_geom, output, exportInfo);
+    break;
 #ifdef ENABLE_CGAL
   case FileFormat::NEFDBG:
     export_nefdbg(root_geom, output);
diff --git a/src/io/export.h b/src/io/export.h
@@ -34,6 +34,7 @@ enum class FileFormat {
   ECHO,
   PNG,
   PDF,
+  POV,
   PARAM
 };
 
@@ -112,6 +113,7 @@ void export_wrl(const std::shared_ptr<const Geometry>& geom, std::ostream& outpu
 void export_amf(const std::shared_ptr<const Geometry>& geom, std::ostream& output);
 void export_dxf(const std::shared_ptr<const Geometry>& geom, std::ostream& output);
 void export_svg(const std::shared_ptr<const Geometry>& geom, std::ostream& output);
+void export_pov(const std::shared_ptr<const Geometry>& geom, std::ostream& output, const ExportInfo& exportInfo);
 void export_pdf(const std::shared_ptr<const Geometry>& geom, std::ostream& output, const ExportInfo& exportInfo);
 void export_nefdbg(const std::shared_ptr<const Geometry>& geom, std::ostream& output);
 void export_nef3(const std::shared_ptr<const Geometry>& geom, std::ostream& output);
@@ -141,6 +143,7 @@ struct ExportFileFormatOptions {
     {"echo", FileFormat::ECHO},
     {"png", FileFormat::PNG},
     {"pdf", FileFormat::PDF},
+    {"pov", FileFormat::POV},
   };
 };
 
diff --git a/src/io/export_pov.cc b/src/io/export_pov.cc
@@ -0,0 +1,112 @@
+/*
+ *  OpenSCAD (www.openscad.org)
+ *  Copyright (C) 2021      Konstantin Podsvirov <konstantin@podsvirov.pro>
+ *         Povray 2024      Folkert van Heusden  <mail@vanheusden.com>
+ *
+ *  This program is free software; you can redistribute it and/or modify
+ *  it under the terms of the GNU General Public License as published by
+ *  the Free Software Foundation; either version 2 of the License, or
+ *  (at your option) any later version.
+ *
+ *  As a special exception, you have permission to link this program
+ *  with the CGAL library and distribute executables, as long as you
+ *  follow the requirements of the GNU GPL in regard to all of the
+ *  software in the executable aside from CGAL.
+ *
+ *  This program is distributed in the hope that it will be useful,
+ *  but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *  GNU General Public License for more details.
+ *
+ *  You should have received a copy of the GNU General Public License
+ *  along with this program; if not, write to the Free Software
+ *  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
+ *
+ */
+
+#include "io/export.h"
+
+#include "geometry/PolySet.h"
+#include "geometry/PolySetUtils.h"
+
+
+void export_pov(const std::shared_ptr<const Geometry>& geom, std::ostream& output, const ExportInfo& exportInfo)
+{
+  auto ps = PolySetUtils::getGeometryAsPolySet(geom);
+  if (Feature::ExperimentalPredictibleOutput.is_enabled()) {
+    ps = createSortedPolySet(*ps);
+  }
+
+  output << "// Generated by OpenSCAD!\n";
+  output << "// Source file: " << exportInfo.sourceFileName << "\n\n";
+
+  output << "#version 3.7;\n";
+  output << "global_settings { assumed_gamma 1.0 }\n";
+  output << "#declare MATERIAL=finish { specular 0.5 roughness 0.001 reflection{0 0.63 fresnel} ambient 0 diffuse 0.6 conserve_energy }\n";
+  output << "#declare MATERIAL_INT=interior{ior 1.32}\n";
+
+  auto has_color = !ps->color_indices.empty();
+
+  for (size_t polygon_index=0; polygon_index<ps->indices.size(); polygon_index++) {
+    const auto &polygon = ps->indices[polygon_index];
+    output << "polygon { " << polygon.size() + 1 << ", \n";
+    for (size_t i=0; i<polygon.size(); i++) {
+      if (i)
+        output << ", ";
+      const auto & x = ps->vertices[polygon[i]].x();
+      const auto & y = ps->vertices[polygon[i]].y();
+      const auto & z = ps->vertices[polygon[i]].z();
+      output << "<" << x << ", " << y << ", " << z << ">";
+    }
+    output << ", <" << ps->vertices[polygon[0]].x() << ", " << ps->vertices[polygon[0]].y() << ", " << ps->vertices[polygon[0]].z() << ">";
+    float r = 0xf9 / 255., g = 0xd7 / 255., b = 0x2c / 255., f = 0.;  // CGAL_FACE_FRONT_COLOR
+    if (has_color) {
+      auto color_index = ps->color_indices[polygon_index];
+      if (color_index >= 0) {
+        auto color = ps->colors[color_index];
+        r = color[0];
+        g = color[1];
+        b = color[2];
+        f = 1.0 - color[3];
+      }
+    }
+    output << "\n";
+    output << "texture { pigment { color rgbf <" << r << ", " << g << ", " << b << ", " << f << "> } }\n";
+    output << "finish { MATERIAL } interior { MATERIAL_INT }\n";
+    output << "}\n";
+  }
+
+  BoundingBox bbox = geom->getBoundingBox();
+
+  auto & min_x = bbox.min().x();
+  auto & min_y = bbox.min().y();
+  auto & min_z = bbox.min().z();
+
+  auto & max_x = bbox.max().x();
+  auto & max_y = bbox.max().y();
+  auto & max_z = bbox.max().z();
+
+  double dx = max_x - min_x;
+  double dy = max_y - min_y;
+  double dz = max_z - min_z;
+
+  constexpr double move_away_factor = 2.;
+  std::vector<double> lx { min_x - dx * move_away_factor, bbox.center().x(), max_x + dx * move_away_factor };
+  std::vector<double> ly { min_y - dy * move_away_factor, bbox.center().y(), max_y + dy * move_away_factor };
+  std::vector<double> lz { min_z - dz * move_away_factor, bbox.center().z(), max_z + dz * move_away_factor };
+
+  constexpr float brightness = 0.2;  // 1.0 is way too bright
+
+  for(auto cur_lx: lx) {
+    for(auto cur_ly: ly) {
+      for(auto cur_lz: lz)
+        output << "light_source { <" << cur_lx << ", " << cur_ly << ", " << cur_lz << "> color rgb <" << brightness << ", " << brightness << ", " << brightness << "> }\n";
+    }
+  }
+
+  output << "camera { look_at <" << bbox.center().x() << ", " << bbox.center().y() << ", " << bbox.center().z() << "> "
+    "location <" << min_x + dx * move_away_factor << ", " << min_y - dy * move_away_factor << ", " << min_z + dz * move_away_factor << "> "
+    "up <0, 0, 1> right <1, 0, 0> sky <0, 0, 1> rotate <-55, clock * 3, clock + 25> right x*image_width/image_height }\n";
+  output << "#include \"rad_def.inc\"\n";
+  output << "global_settings { photons { count 20000 autostop 0 jitter .4 } radiosity { Rad_Settings(Radiosity_Normal, off, off) } }\n";
+}
diff --git a/tests/CMakeLists.txt b/tests/CMakeLists.txt
@@ -1088,6 +1088,8 @@ list(APPEND EXPORT_OBJ_TEST_FILES ${TEST_SCAD_DIR}/3D/features/polyhedron-cube.s
 
 list(APPEND EXPORT_3MF_TEST_FILES ${TEST_SCAD_DIR}/3mf/3mf-export.scad)
 
+list(APPEND EXPORT_POV_TEST_FILES ${TEST_SCAD_DIR}/pov/pov-export.scad)
+
 list(APPEND EXPORT_IMPORT_3D_FILES
 ${TEST_SCAD_DIR}/3D/features/mirror-tests.scad
 ${TEST_SCAD_DIR}/3D/features/polyhedron-tests.scad
@@ -1142,6 +1144,7 @@ add_cmdline_test(objexport              EXPERIMENTAL OPENSCAD SUFFIX obj FILES $
 if (LIB3MF_FOUND)
 add_cmdline_test(3mfexport              EXPERIMENTAL OPENSCAD SUFFIX 3mf FILES ${EXPORT_3MF_TEST_FILES} ARGS --enable=predictible-output)
 endif()
+add_cmdline_test(povexport              EXPERIMENTAL OPENSCAD SUFFIX pov FILES ${EXPORT_POV_TEST_FILES} ARGS --enable=predictible-output --backend=manifold)
 
 # Trivial Export/Import files: Sanity-checks bidirectional file format import/export
 set(SIMPLE_EXPORT_IMPORT_2D_FILES ${TEST_SCAD_DIR}/misc/square10.scad)
diff --git a/tests/data/scad/pov/pov-export.scad b/tests/data/scad/pov/pov-export.scad
@@ -0,0 +1,2 @@
+color([1, 0.5, 0.25, 0.125]) translate([-10, 0, 0]) cube(10);
+color("green") translate([10, 0, 0]) cube(10);
diff --git a/tests/regression/povexport/pov-export-expected.pov b/tests/regression/povexport/pov-export-expected.pov
diff --git a/tests/test_pretty_print.py b/tests/test_pretty_print.py

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ do_build() {`
`31`	`31`	`mkdir "$BUILDDIR"`
`32`	`32`	`(`
`33`	`33`	`cd "$BUILDDIR"`
`34`		`- cmake -DCMAKE_BUILD_TYPE=Release -DCMAKE_UNITY_BUILD=ON -DPROFILE=ON -DUSE_BUILTIN_OPENCSG=1 ${EXPERIMENTAL} ${PYTHON_DEFINE} ${USE_QT6} .. && make $PARALLEL_MAKE`
	`34`	`+ cmake -DCMAKE_BUILD_TYPE=Release -DCMAKE_UNITY_BUILD=OFF -DPROFILE=ON -DUSE_BUILTIN_OPENCSG=1 ${EXPERIMENTAL} ${PYTHON_DEFINE} ${USE_QT6} .. && make $PARALLEL_MAKE`
`35`	`35`	`)`
`36`	`36`	`if [[ $? != 0 ]]; then`
`37`	`37`	`echo "Build failure"`