In implementation compilation unit: move corresponding header to top. (openscad#5327)

Move header foo.h within implementation foo.cc to the top. That ensures
that the header at least is self-contained.

This revealed, that the core/SurfaceNode.h header was missing an
include of core/Value.h.

This PR leaves out changing src/glview, as there are
too many header dependencies that break, and should be addressed
separately.

Author: hzeller

src/Feature.cc

@@ -1,3 +1,5 @@
+#include "Feature.h"
+
 #include <cstdio>
 #include <iostream>
 #include <sstream>
@@ -7,7 +9,6 @@
 #include <boost/range/adaptor/transformed.hpp>
 #include <utility>
 
-#include "Feature.h"
 #include "utils/printutils.h"
 
 /**

src/FontCache.cc

@@ -24,6 +24,8 @@
  *
  */
 
+#include "FontCache.h"
+
 #include <cstdint>
 #include <iostream>
 #include <vector>
@@ -33,7 +35,6 @@
 #include <string>
 #include <utility>
 
-#include "FontCache.h"
 #include "platform/PlatformUtils.h"
 #include "utils/printutils.h"
 #include "utils/version_helper.h"

src/RenderStatistic.cc

@@ -24,6 +24,8 @@
  */
 
 
+#include "RenderStatistic.h"
+
 #include <iostream>
 #include <memory>
 #include <fstream>
@@ -46,7 +48,6 @@
 #include "geometry/manifold/manifoldutils.h"
 #endif // ENABLE_MANIFOLD
 
-#include "RenderStatistic.h"
 
 class GeometryList;
 

src/core/Arguments.cc

@@ -24,9 +24,10 @@
  *
  */
 
+#include "core/Arguments.h"
+
 #include <ostream>
 #include <memory>
-#include "core/Arguments.h"
 #include "core/Expression.h"
 
 Arguments::Arguments(const AssignmentList& argument_expressions, const std::shared_ptr<const Context>& context) :

src/core/BuiltinContext.cc

@@ -1,7 +1,8 @@
+#include "core/BuiltinContext.h"
+
 #include <cmath>
 
 #include "core/Builtins.h"
-#include "core/BuiltinContext.h"
 #include "core/Expression.h"
 #include "core/function.h"
 #include "utils/printutils.h"

src/core/Builtins.cc

@@ -1,8 +1,9 @@
+#include "core/Builtins.h"
+
 #include <memory>
 #include <string>
 #include <vector>
 
-#include "core/Builtins.h"
 #include "core/function.h"
 #include "core/module.h"
 #include "core/Expression.h"

src/core/Children.cc

@@ -24,11 +24,12 @@
  *
  */
 
+#include "core/Children.h"
+
 #include <memory>
 #include <cstddef>
 #include <vector>
 
-#include "core/Children.h"
 #include "core/ScopeContext.h"
 
 std::shared_ptr<AbstractNode> Children::instantiate(const std::shared_ptr<AbstractNode> &target) const

src/core/Context.cc

@@ -24,13 +24,14 @@
  *
  */
 
+#include "core/Context.h"
+
 #include <utility>
 #include <memory>
 #include <cstddef>
 #include <string>
 #include <vector>
 
-#include "core/Context.h"
 #include "core/function.h"
 #include "utils/printutils.h"
 

src/core/ContextFrame.cc

@@ -24,12 +24,13 @@
  *
  */
 
+#include "core/ContextFrame.h"
+
 #include <utility>
 #include <cstddef>
 #include <string>
 #include <vector>
 
-#include "core/ContextFrame.h"
 
 ContextFrame::ContextFrame(EvaluationSession *session) :
   evaluation_session(session)

src/core/ContextMemoryManager.cc

@@ -24,6 +24,8 @@
  *
  */
 
+#include "core/ContextMemoryManager.h"
+
 #include <utility>
 #include <memory>
 #include <deque>
@@ -32,7 +34,6 @@
 #include <vector>
 
 #include "core/Context.h"
-#include "core/ContextMemoryManager.h"
 #include "core/Value.h"
 
 /*