feat: changes to pad re analog toggle

alextwomey · alextwomey · commit 3aef7f85977e · 2024-04-21T16:30:58.000-04:00
diff --git a/src/core/pad.cc b/src/core/pad.cc
@@ -482,7 +482,7 @@ void PadsImpl::reset() {
 }
 
 void PadsImpl::Pad::reset() {
-    m_analogMode = false;
+    //m_analogMode = false;
     m_configMode = false;
     m_cmd = magic_enum::enum_integer(PadCommands::Idle);
     m_bufferLen = 0;
@@ -882,7 +882,7 @@ bool PadsImpl::configure(PCSX::GUI* gui) {
         if (pad.m_type == PadType::Analog && pad.m_settings.get<Keyboard_AnalogMode>() != GLFW_KEY_UNKNOWN) {
             const int key = pad.m_settings.get<Keyboard_AnalogMode>();
 
-            if ((key != ImGuiKey_None) && ImGui::IsKeyDown(GlfwKeyToImGuiKey(key))) {
+            if ((key != ImGuiKey_None) && ImGui::IsKeyReleased(GlfwKeyToImGuiKey(key))) {
                 pad.m_analogMode = !pad.m_analogMode;
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -482,7 +482,7 @@ void PadsImpl::reset() {`
`482`	`482`	`}`
`483`	`483`
`484`	`484`	`void PadsImpl::Pad::reset() {`
`485`		`- m_analogMode = false;`
	`485`	`+ //m_analogMode = false;`
`486`	`486`	`m_configMode = false;`
`487`	`487`	`m_cmd = magic_enum::enum_integer(PadCommands::Idle);`
`488`	`488`	`m_bufferLen = 0;`
`@@ -882,7 +882,7 @@ bool PadsImpl::configure(PCSX::GUI* gui) {`
`882`	`882`	`if (pad.m_type == PadType::Analog && pad.m_settings.get<Keyboard_AnalogMode>() != GLFW_KEY_UNKNOWN) {`
`883`	`883`	`const int key = pad.m_settings.get<Keyboard_AnalogMode>();`
`884`	`884`
`885`		`- if ((key != ImGuiKey_None) && ImGui::IsKeyDown(GlfwKeyToImGuiKey(key))) {`
	`885`	`+ if ((key != ImGuiKey_None) && ImGui::IsKeyReleased(GlfwKeyToImGuiKey(key))) {`
`886`	`886`	`pad.m_analogMode = !pad.m_analogMode;`
`887`	`887`	`}`
`888`	`888`	`}`