tweaks to make it work for me #25

petjal · 2021-09-16T05:52:18Z

petjal
Sep 16, 2021

Got the first part of the Synopsis to work, with the changes below:

~/.../git/bitcoin-bash-tools $ . bitcoin.sh
~/.../git/bitcoin-bash-tools $ let -i a=RANDOM b=RANDOM
~/.../git/bitcoin-bash-tools $ secp256k1 $a
02459A2D11A28D7870CD64CF5EC2F350B33568994D647645085DB2D78670BE0B4D
~/.../git/bitcoin-bash-tools $ secp256k1 $b
02A6A766D77D5F30DB203C78B85AE419E365285E1748A424EAB646791458821F97
~/.../git/bitcoin-bash-tools $ for i in $a $b; do secp256k1 $i; done | secp256k1
0373EF66603A42A00B539CFA4BD6F322D15C5DB7B70BD7AF1420835FBE885C4257
~/.../git/bitcoin-bash-tools $ secp256k1 $((a+b))
0373EF66603A42A00B539CFA4BD6F322D15C5DB7B70BD7AF1420835FBE885C4257
~/.../git/bitcoin-bash-tools $ prv=3aba4162c7251c891207b747840551a71939b0de081f85c4e44cf7c13e41daa6
~/.../git/bitcoin-bash-tools $ secp256k1 "$prv"
025C0DE3B9C8AB18DD04E3511243EC2952002DBFADC864B9628910169D9B9B00EC
~/.../git/bitcoin-bash-tools $ bitcoinAddress "$(!!)"
~/.../git/bitcoin-bash-tools $ bitcoinAddress "$(secp256k1 "$prv")"
14cxpo3MBCYYWCgF74SWTdcmxipnGUsPw3
~/.../git/bitcoin-bash-tools $ bitcoinAddress "$(secp256k1 -u "$prv")"
1thMirt546nngXqyPEz532S8fLwbozud8
~/.../git/bitcoin-bash-tools $ newBitcoinKey -u "$prv"
5JG9hT3beGTJuUAmCQEmNaxAuMacCTfXuw1R3FCXig23RQHMr4K
~/.../git/bitcoin-bash-tools $ newBitcoinKey "$prv"
KyBsPXxTuVD82av65KZkrGrWi5qLMah5SdNq6uftawDbgKa2wv6S

Guess the xdigits need to be paired with parens:

~/.../git/bitcoin-bash-tools $ git diff
diff --git a/base58.sh b/base58.sh
index 44c7649..d0be7e1 100644
--- a/base58.sh
+++ b/base58.sh
@@ -61,7 +61,7 @@ base58() {
     } | ${FUNCNAME[0]}
   elif [[ "$1" =~ ^00 ]]
   then echo -n 1; ${FUNCNAME[0]} "${1:2}"
-  elif [[ "$1" =~ ^[[:xdigit:]]{2}+$ ]]
+  elif [[ "$1" =~ ^([[:xdigit:]]{2})+$ ]]
   then sed -e 'i16i0' -e 's/../100*&+/g' -e 'a[3A~rd0<x]dsxx+f' <<<"${1^^}" |
     dc |
     while read -r; do echo -n ${base58_chars_str:$REPLY:1}; done
diff --git a/bitcoin.sh b/bitcoin.sh
index efbcdc8..8f365fa 100644
--- a/bitcoin.sh
+++ b/bitcoin.sh
@@ -35,7 +35,7 @@ hash160() {
 }

 ser256() {
-  if   [[ "$1" =~ ^(0x)?([[:xdigit:]]{2}{32})$ ]]
+  if   [[ "$1" =~ ^(0x)?(([[:xdigit:]]{2}){32})$ ]]
   then xxd -p -r <<<"${BASH_REMATCH[2]}"
   elif [[ "$1" =~ ^(0x)?([[:xdigit:]]{,63})$ ]]
   then ${FUNCNAME[0]} "0x0${BASH_REMATCH[2]}"
@@ -56,7 +56,7 @@ bitcoinAddress() {
         ;;
       t) P2PKH_PREFIX="\x6F" ${FUNCNAME[0]} "$@" ;;
     esac
-  elif [[ "$1" =~ ^0([23][[:xdigit:]]{2}{32}|4[[:xdigit:]]{2}{64})$ ]]
+  elif [[ "$1" =~ ^0([23]([[:xdigit:]]{2}){32}|4([[:xdigit:]]{2}){64})$ ]]
   then
     {
       printf %b "${P2PKH_PREFIX:-\x00}"
@@ -115,7 +115,7 @@ newBitcoinKey() {
       t) BITCOIN_NET=TEST ${FUNCNAME[0]} "$@";;
     esac
   elif [[ "$1" =~ ^[1-9][0-9]*$ ]]
-  then ${FUNCNAME[0]} "0x$(dc -e "16o$1p")"
-...skipping...
diff --git a/base58.sh b/base58.sh
index 44c7649..d0be7e1 100644
--- a/base58.sh
+++ b/base58.sh
@@ -61,7 +61,7 @@ base58() {
     } | ${FUNCNAME[0]}
   elif [[ "$1" =~ ^00 ]]
   then echo -n 1; ${FUNCNAME[0]} "${1:2}"
-  elif [[ "$1" =~ ^[[:xdigit:]]{2}+$ ]]
+  elif [[ "$1" =~ ^([[:xdigit:]]{2})+$ ]]
   then sed -e 'i16i0' -e 's/../100*&+/g' -e 'a[3A~rd0<x]dsxx+f' <<<"${1^^}" |
     dc |
     while read -r; do echo -n ${base58_chars_str:$REPLY:1}; done
diff --git a/bitcoin.sh b/bitcoin.sh
index efbcdc8..8f365fa 100644
--- a/bitcoin.sh
+++ b/bitcoin.sh
@@ -35,7 +35,7 @@ hash160() {
 }

 ser256() {
-  if   [[ "$1" =~ ^(0x)?([[:xdigit:]]{2}{32})$ ]]
+  if   [[ "$1" =~ ^(0x)?(([[:xdigit:]]{2}){32})$ ]]
   then xxd -p -r <<<"${BASH_REMATCH[2]}"
   elif [[ "$1" =~ ^(0x)?([[:xdigit:]]{,63})$ ]]
   then ${FUNCNAME[0]} "0x0${BASH_REMATCH[2]}"
@@ -56,7 +56,7 @@ bitcoinAddress() {
         ;;
       t) P2PKH_PREFIX="\x6F" ${FUNCNAME[0]} "$@" ;;
     esac
-  elif [[ "$1" =~ ^0([23][[:xdigit:]]{2}{32}|4[[:xdigit:]]{2}{64})$ ]]
+  elif [[ "$1" =~ ^0([23]([[:xdigit:]]{2}){32}|4([[:xdigit:]]{2}){64})$ ]]
   then
     {
       printf %b "${P2PKH_PREFIX:-\x00}"
@@ -115,7 +115,7 @@ newBitcoinKey() {
       t) BITCOIN_NET=TEST ${FUNCNAME[0]} "$@";;
     esac
   elif [[ "$1" =~ ^[1-9][0-9]*$ ]]
-  then ${FUNCNAME[0]} "0x$(dc -e "16o$1p")"
+  then ${FUNCNAME[0]} "0x$(dc -e "16o${1}p")"
   elif [[ "$1" =~ ^(0x)?([[:xdigit:]]{1,64})$ ]]
   then
     {

~/.../git/bitcoin-bash-tools $ bash --version
GNU bash, version 5.1.8(1)-release (i686-pc-linux-android)
Copyright (C) 2020 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

petjal · 2021-09-16T05:55:00Z

petjal
Sep 16, 2021
Author

sorry, I think you can ignore this one:

@@ -115,7 +115,7 @@ newBitcoinKey() {
+  then ${FUNCNAME[0]} "0x$(dc -e "16o${1}p")"

0 replies

grondilu · 2021-09-16T08:40:09Z

grondilu
Sep 16, 2021
Maintainer

Weird, in regex(7) they say :

A piece is an atom possibly followed by a single(!) '*', '+', '?', or bound.

, so bounds ~~should be allowed to follow one another~~. My bad, they don't say a bound could follow an other piece.

What do you get if you try :

[[ foooooo =~ .(o{2}{3}) ]] && declare -p BASH_REMATCH

?

1 reply

petjal Sep 16, 2021
Author

~/dev/bitcoin/git $ [[ foooooo =~ .(o{2}{3}) ]] && declare -p BASH_REMATCH

~/dev/bitcoin/git $ [[ foooooo =~ .((o{2}){3}) ]] && declare -p BASH_REMATCH
declare -a BASH_REMATCH=([0]="foooooo" [1]="oooooo" [2]="oo")

grondilu · 2021-09-16T09:09:23Z

grondilu
Sep 16, 2021
Maintainer

This was a genuine issue. Thanks for reporting (you did it on the discussion tab instead of actually reporting an issue but that's ok).

Hopefully fixed with 7cb0172

0 replies

petjal · 2021-09-16T12:12:47Z

petjal
Sep 16, 2021
Author

fwiw, this fanciness always gets in the way of my laziness:

$ bitcoinAddress "$(!!)"
...
bash: line 12: !!: command not found

~/dev/bitcoin/git $ bash Synopsis.bash
+ rm -rf bitcoin-bash-tools/
+ git clone https://github.com/grondilu/bitcoin-bash-tools.git
Cloning into 'bitcoin-bash-tools'...
remote: Enumerating objects: 1028, done.
remote: Counting objects: 100% (863/863), done.
remote: Compressing objects: 100% (563/563), done.
remote: Total 1028 (delta 526), reused 623 (delta 297), pack-reused 165
Receiving objects: 100% (1028/1028), 391.62 KiB | 2.61 MiB/s, done.
Resolving deltas: 100% (584/584), done.
+ cd bitcoin-bash-tools/
++ set -x
++ sed -re 's/ \$ //g'
++ grep '^ $ *'
++ grep -v prove
++ grep -A9999 Synopsis
++ links -dump https://github.com/grondilu/bitcoin-bash-tools/blob/master/README.md
+ bash -c 'git clone https://github.com/grondilu/bitcoin-bash-tools.git
cd bitcoin-bash-tools/
. bitcoin.sh
let -i a=RANDOM b=RANDOM
secp256k1 $a
secp256k1 $b
for i in $a $b; do secp256k1 $i; done | secp256k1
secp256k1 $((a+b))
# Bitcoin book, chap. 04, example 6 :
prv=3aba4162c7251c891207b747840551a71939b0de081f85c4e44cf7c13e41daa6
secp256k1 "$prv"
bitcoinAddress "$(!!)"
bitcoinAddress "$(secp256k1 -u "$prv")"
newBitcoinKey -u "$prv"
newBitcoinKey "$prv"
. bip-0032.sh
openssl rand 64 > entropy
m="$(bip32 < entropy)"
bip32 $m/N
bip32 $m/0h/5/7'
Cloning into 'bitcoin-bash-tools'...
remote: Enumerating objects: 1028, done.
remote: Counting objects: 100% (863/863), done.
remote: Compressing objects: 100% (563/563), done.
remote: Total 1028 (delta 526), reused 623 (delta 297), pack-reused 165
Receiving objects: 100% (1028/1028), 391.62 KiB | 3.53 MiB/s, done.
Resolving deltas: 100% (584/584), done.
02D5C4743EF30F58F64075B9EE03E98FB9CA4B0F350441940CDE959DD7066A97F2
02ADAA9457F60B9F3EE0A5548C51F945B97884584151AE87FD689B892F8CCB19F4
02BF826D05CBA6BB405670DBEEB6213AD63C3F280933C36D8AE05830924CE2455A
02BF826D05CBA6BB405670DBEEB6213AD63C3F280933C36D8AE05830924CE2455A
025C0DE3B9C8AB18DD04E3511243EC2952002DBFADC864B9628910169D9B9B00EC
bash: line 12: !!: command not found
1+ exit

0 replies

petjal · 2021-09-16T13:21:24Z

petjal
Sep 16, 2021
Author

I think there is a similar problem in:

~/.../git/bitcoin-bash-tools $ git diff
diff --git a/base58.sh b/base58.sh
index 44c7649..c1d5de9 100644
--- a/base58.sh
+++ b/base58.sh
@@ -61,7 +61,7 @@ base58() {
     } | ${FUNCNAME[0]}
   elif [[ "$1" =~ ^00 ]]
   then echo -n 1; ${FUNCNAME[0]} "${1:2}"
-  elif [[ "$1" =~ ^[[:xdigit:]]{2}+$ ]]
+  elif [[ "$1" =~ ^[[:xdigit:]]+$ ]]
   then sed -e 'i16i0' -e 's/../100*&+/g' -e 'a[3A~rd0<x]dsxx+f' <<<"${1^^}" |
     dc |
     while read -r; do echo -n ${base58_chars_str:$REPLY:1}; done

Without that change, this returns a "1" with no newline:

~/.../git/bitcoin-bash-tools $ bitcoinAddress "$(secp256k1 "$prv")"
1

With that change, I get something that looks reasonable:

~/.../git/bitcoin-bash-tools $ bitcoinAddress "$(secp256k1 "$prv")"
14cxpo3MBCYYWCgF74SWTdcmxipnGUsPw3

0 replies

petjal · 2021-09-16T13:28:05Z

petjal
Sep 16, 2021
Author

and then the rest of the Synopsis works for me

~/.../git/bitcoin-bash-tools $ bitcoinAddress "$(secp256k1 -u "$prv")"
1thMirt546nngXqyPEz532S8fLwbozud8
~/.../git/bitcoin-bash-tools $ newBitcoinKey -u "$prv"
5JG9hT3beGTJuUAmCQEmNaxAuMacCTfXuw1R3FCXig23RQHMr4K
~/.../git/bitcoin-bash-tools $ newBitcoinKey "$prv"
KyBsPXxTuVD82av65KZkrGrWi5qLMah5SdNq6uftawDbgKa2wv6S
~/.../git/bitcoin-bash-tools $ . bip-0032.sh
~/.../git/bitcoin-bash-tools $ openssl rand 64 > entropy
~/.../git/bitcoin-bash-tools $ m="$(bip32 < entropy)"
~/.../git/bitcoin-bash-tools $ bip32 $m/N
xpub661MyMwAqRbcF4LhVM2Jk2FWg9tRmF4zLNABi3ovSF47Aji3iyGQrdvfaBYhv5rfqjf1MJYUwGGvBEjM64WX4KsSZ41a7nfaK3r6WEEyPpo
~/.../git/bitcoin-bash-tools $ bip32 $m/0h/5/7
xprv9xhXS8aSDXh3yPwkRBzsBwX4PqQVmVUA1YcPNLuKJ8LPfnJXn7qNTFLKttBqL7zR8RLJBofyugsM56BxQaz8332KxWL6L9cyJJJV5m5diWs

0 replies

petjal · 2021-09-16T15:59:47Z

petjal
Sep 16, 2021
Author

just exploring for other possible issues in this regard:

~/.../git/bitcoin-bash-tools $ find -type f | parallel --tag grep -F -e '}+' -e '}{' 2>/dev/null
./bip-0173.sh       [[ ! "$witness_program" =~ ^[[:xdigit:]]{2}+$ ]]
./bx.sh isHexadecimal()    [[ "$1" =~ ^(0x)?([[:xdigit:]]{2}+)$ ]]
./bx.sh   ec-{add,multiply}{,-secrets}
./bx.sh           then dc_script+="${BASH_REMATCH[2]^^}+"
./secp256k1.sh          then echo "8d+i${BASH_REMATCH[1]^^}+"

1 reply

grondilu Sep 16, 2021
Maintainer

Indeed those are others compound bounds and they are mistakes. Apparently they are tolerated on my system but they definitely are syntax errors.

tweaks to make it work for me #25

Uh oh!

petjal Sep 16, 2021

Replies: 7 comments · 2 replies

Uh oh!

petjal Sep 16, 2021 Author

Uh oh!

Uh oh!

grondilu Sep 16, 2021 Maintainer

Uh oh!

petjal Sep 16, 2021 Author

Uh oh!

grondilu Sep 16, 2021 Maintainer

Uh oh!

petjal Sep 16, 2021 Author

Uh oh!

Uh oh!

petjal Sep 16, 2021 Author

Uh oh!

petjal Sep 16, 2021 Author

Uh oh!

petjal Sep 16, 2021 Author

Uh oh!

grondilu Sep 16, 2021 Maintainer

petjal
Sep 16, 2021

Replies: 7 comments 2 replies

petjal
Sep 16, 2021
Author

grondilu
Sep 16, 2021
Maintainer

petjal Sep 16, 2021
Author

grondilu
Sep 16, 2021
Maintainer

petjal
Sep 16, 2021
Author

petjal
Sep 16, 2021
Author

petjal
Sep 16, 2021
Author

petjal
Sep 16, 2021
Author

grondilu Sep 16, 2021
Maintainer