Skip to content
This repository was archived by the owner on Jan 5, 2023. It is now read-only.

Commit d17eb21

Browse files
chore(deps-dev): update nunomaduro/larastan requirement from ^0.7.12 to ^0.7.12 || ^1.0.0 (#6)
* fix(deps): update guzzlehttp/psr7 requirement from ^1.7 to ^1.7 || ^2.0 Updates the requirements on [guzzlehttp/psr7](https://github.com/guzzle/psr7) to permit the latest version. - [Release notes](https://github.com/guzzle/psr7/releases) - [Changelog](https://github.com/guzzle/psr7/blob/master/CHANGELOG.md) - [Commits](guzzle/psr7@1.7.0...2.1.0) --- updated-dependencies: - dependency-name: guzzlehttp/psr7 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * chore(deps-dev): update nunomaduro/larastan requirement || ^1.0.0 Updates the requirements on [nunomaduro/larastan](https://github.com/nunomaduro/larastan) to permit the latest version. - [Release notes](https://github.com/nunomaduro/larastan/releases) - [Changelog](https://github.com/nunomaduro/larastan/blob/master/CHANGELOG.md) - [Commits](larastan/larastan@v0.7.12...1.0.0) --- updated-dependencies: - dependency-name: nunomaduro/larastan dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> * chore: updated deps * chore: prepared CI pipeline to change default branch * chore: updated comment in phpstan config file * docs: updated README.md * docs: updated CONTRIBUTING.md * docs: updated CHANGELOG.md * fix: removed non-used properties Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mateusz Gostański <mateusz.gostanski@gmail.com>
1 parent dffdd96 commit d17eb21

File tree

8 files changed

+38
-23
lines changed

8 files changed

+38
-23
lines changed

.github/workflows/php.yml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,13 @@ name: CI/CD
22

33
on:
44
push:
5-
branches: [ master ]
5+
branches:
6+
- master
7+
- main
68
pull_request:
7-
branches: [ master ]
9+
branches:
10+
- master
11+
- main
812

913
jobs:
1014
build:

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,11 @@
22

33
All notable changes to `api-client` will be documented in this file
44

5+
## 3.4.1 - 2021-11-08
6+
7+
- Updated Larastan to `1.0.1`
8+
- Prepared CI pipeline to change default branch
9+
510
## 3.4.0 - 2021-10-28
611

712
- Added code quality tools such as PHP_CS_Fixer, PHP Insights & PHPStan

CONTRIBUTING.md

Lines changed: 18 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -10,17 +10,18 @@ This project is open source, and as such, the maintainers give their free time t
1010
held within. They make the code freely available in the hope that it will be of use to other developers. It would be
1111
extremely unfair for them to suffer abuse or anger for their hard work.
1212

13-
Please be considerate towards maintainers when raising issues or presenting pull requests. Let's show the
14-
world that developers are civilized and selfless people.
13+
Please be considerate towards maintainers when raising issues or presenting pull requests. Let's show the world that
14+
developers are civilized and selfless people.
1515

16-
It's the duty of the maintainer to ensure that all submissions to the project are of sufficient
17-
quality to benefit the project. Many developers have different skillsets, strengths, and weaknesses. Respect the maintainer's decision, and do not be upset or abusive if your submission is not used.
16+
It's the duty of the maintainer to ensure that all submissions to the project are of sufficient quality to benefit the
17+
project. Many developers have different skillsets, strengths, and weaknesses. Respect the maintainer's decision, and do
18+
not be upset or abusive if your submission is not used.
1819

1920
## Viability
2021

21-
When requesting or submitting new features, first consider whether it might be useful to others. Open
22-
source projects are used by many developers, who may have entirely different needs to your own. Think about
23-
whether or not your feature is likely to be used by other users of the project.
22+
When requesting or submitting new features, first consider whether it might be useful to others. Open source projects
23+
are used by many developers, who may have entirely different needs to your own. Think about whether or not your feature
24+
is likely to be used by other users of the project.
2425

2526
## Procedure
2627

@@ -40,16 +41,22 @@ Before submitting a pull request:
4041

4142
If the project maintainer has any additional requirements, you will find them listed here.
4243

43-
- **[PSR-12 Coding Standard](https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-12-extended-coding-style-guide.md)** - The easiest way to apply the conventions is to install [PHP Code Sniffer](https://pear.php.net/package/PHP_CodeSniffer).
44+
- **[PSR-12 Coding Standard](https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-12-extended-coding-style-guide.md)**
45+
- The easiest way to apply the conventions is to run `composer cs`.
4446

4547
- **Add tests!** - Your patch won't be accepted if it doesn't have tests.
4648

47-
- **Document any change in behaviour** - Make sure the `README.md` and any other relevant documentation are kept up-to-date.
49+
- **Document any change in behaviour** - Make sure the `README.md` and any other relevant documentation are kept
50+
up-to-date.
4851

49-
- **Consider our release cycle** - We try to follow [SemVer v2.0.0](https://semver.org/). Randomly breaking public APIs is not an option.
52+
- **Consider our release cycle** - We try to follow [SemVer v2.0.0](https://semver.org/). Randomly breaking public APIs
53+
is not an option.
5054

5155
- **One pull request per feature** - If you want to do more than one thing, send multiple pull requests.
5256

53-
- **Send coherent history** - Make sure each individual commit in your pull request is meaningful. If you had to make multiple intermediate commits while developing, please [squash them](https://www.git-scm.com/book/en/v2/Git-Tools-Rewriting-History#Changing-Multiple-Commit-Messages) before submitting.
57+
- **Send coherent history** - Make sure each individual commit in your pull request is meaningful. If you had to make
58+
multiple intermediate commits while developing,
59+
please [squash them](https://www.git-scm.com/book/en/v2/Git-Tools-Rewriting-History#Changing-Multiple-Commit-Messages)
60+
before submitting.
5461

5562
**Happy coding**!

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ Please see [CONTRIBUTING](CONTRIBUTING.md) for details.
9292

9393
### Security
9494

95-
If you discover any security related issues, please email mg@grixu.dev instead of using the issue tracker.
95+
If you discover any security related issues, please email mateusz.gostanski@gmail.com instead of using the issue tracker.
9696

9797
## Credits
9898

composer.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,15 @@
1111
"authors": [
1212
{
1313
"name": "Mateusz Gostański",
14-
"email": "mg@grixu.dev",
14+
"email": "mateusz.gostanski@gmail.com",
1515
"role": "Developer"
1616
}
1717
],
1818
"require": {
1919
"php": "^8.0",
2020
"ext-json": "*",
2121
"guzzlehttp/guzzle": "^7.2",
22-
"guzzlehttp/psr7": "^1.7",
22+
"guzzlehttp/psr7": "^1.7 || ^2.0",
2323
"illuminate/http": "^8.0",
2424
"illuminate/support": "^8.0",
2525
"spatie/laravel-enum": "^2.2"
@@ -29,7 +29,7 @@
2929
"orchestra/testbench": "^6.0",
3030
"phpunit/phpunit": "^9.4",
3131
"friendsofphp/php-cs-fixer": "^3.1",
32-
"nunomaduro/larastan": "^0.7.12",
32+
"nunomaduro/larastan": "^0.7.12 || ^1.0.0",
3333
"nunomaduro/phpinsights": "^2.0"
3434
},
3535
"autoload": {

phpstan.neon.dist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ parameters:
66
paths:
77
- src
88

9-
# The level 8 is the highest level
9+
# The level 9 is the highest level
1010
level: 5
1111

1212
ignoreErrors:

src/AbstractApiFetcher.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,7 @@ abstract class AbstractApiFetcher implements ApiFetcher
1515
protected Collection $dataCollection;
1616

1717
public function __construct(
18-
private Config $config,
19-
private string $path
18+
private Config $config
2019
) {
2120
$tokenClassName = config('api-client.auth_types')[$config->getAuthType()->value];
2221
$this->token = new $tokenClassName($config);

src/JsonApiFetcher.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,11 @@ class JsonApiFetcher extends AbstractApiFetcher
1212

1313
public function __construct(
1414
private JsonApiConfig $config,
15-
private string $path,
15+
string $path,
1616
private bool $loadAll = true,
17-
private int $page = 1
17+
int $page = 1
1818
) {
19-
parent::__construct($config, $path);
19+
parent::__construct($config);
2020

2121
$this->urlComposer = new UrlCompose($config, $path);
2222
$this->urlComposer->setPage($config->getPaginationParam(), $page);

0 commit comments

Comments
 (0)