[1.5.1] can't open some documents : Duplicate ACLResource

[vviers]

Describe the current behavior

Hey there 👋🏼

Some users are complaining that their Grist documents won't open since we deployed 1.5.1

The document crashes on opening with the error : Duplicate ACLResource {id}: an ACLRessource with the same tableID and colIds already exists. Reloading doesn't fix it, and Recovery mode won't let you fix the issue in the ACL pannel since they are stripped to the bare minimum.

The document opens perfectly in grist < 1.5.0

Inspecting the .grist file with sqlite3, we see that the table _grist_ACLResources does contain duplicated lines, although only one of them is reffered to by _grist_ACLRules. Manually removing the unused duplicated line and re-uploading the .grist file fixes the issue (but we're now in a different document).

Looking at the commit history of the project, I see that @paulfitz has touched this part of the code in d38fca6 but I'm not exactly sure why this would break documents that opened perfectly before.

Steps to reproduce

1. create a .grist file with a duplicated entry in _grist_ACLResources (not sure how that happened in the first place in prod)
2. open it without any problem in grist 1.4.2
3. fail to open it in grist 1.5.1

Describe the expected behavior

Docs should open even if there is a duplicated entry in ACLResources

Where have you encountered this bug?

• On docs.getgrist.com
• On a self-hosted instance

Instance information (when self-hosting only)

• Grist instance:
  • Version: 1.5.1
  • Installation mode: kubernetes
  • Architecture: multi-workers

[vviers]

select * from _grist_ACLResources a left join _grist_ACLRules b ON a.id = b.resource where b.id is null; lets you list unused ACLResources.

It looks like it's safe to delete them.