Enables external attachments in DocumentUsage

Author: Spoffy

test/nbrowser/DocumentUsage.ts

@@ -14,9 +14,18 @@ describe('DocumentUsage', function() {
   let api: UserAPI;
   let session: gu.Session;
 
-  before(async function () {
-    session = await gu.session().user(ownerUser).login();
+  gu.enableExternalAttachments();
+
+  async function makeSessionAndLogin() {
+    // login() needs an options object passing to bypass an optimization that causes .login()
+    // to think we're already logged in when we're not after using `server.restart()`.
+    // Without this we end up with bad credentials.
+    session = await gu.session().user(ownerUser).login({ retainExistingLogin: false });
     api = session.createHomeApi();
+  }
+
+  before(async function () {
+    await makeSessionAndLogin();
   });
 
   it('shows usage stats on the raw data page', async function() {
@@ -105,14 +114,9 @@ describe('DocumentUsage', function() {
     });
   });
 
-  describe('attachment usage', function() {
-    let docId: string;
-
-    before(async () => {
-      docId = await session.tempNewDoc(cleanup, "AttachmentUsageTestDoc");
-    });
-
+  function testAttachmentsUsage(getDocId: () => string) {
     it('updates attachments size usage when uploading attachments', async function () {
+      const docId = getDocId();
       // Add a new 'Attachments' column of type Attachment to Table1.
       await api.applyUserActions(docId, [['AddEmptyTable', "AttachmentsTable"]]);
       await gu.getPageItem('AttachmentsTable').click();
@@ -147,6 +151,29 @@ describe('DocumentUsage', function() {
       await assertDataSize('0.00');
       await assertAttachmentsSize('0.00');
     });
+  }
+
+  describe('attachment usage without external attachments', function() {
+    let docId: string;
+
+    before(async () => {
+      docId = await session.tempNewDoc(cleanup, `AttachmentUsageTestDoc - internal`);
+    });
+
+    testAttachmentsUsage(() => docId);
+  });
+
+  describe('attachment usage with external attachments', function() {
+    let docId: string;
+
+    before(async () => {
+      docId = await session.tempNewDoc(cleanup, `AttachmentUsageTestDoc - internal`);
+      const docApi = api.getDocAPI(docId);
+      await docApi.setAttachmentStore("external");
+      assert.equal((await docApi.getAttachmentStore()).type, "external");
+    });
+
+    testAttachmentsUsage(() => docId);
   });
 
   describe('doc usage access', function() {