Skip to content

Commit 7dd0fb5

Browse files
committed
(tests) fix flaky tests when adding columns or pages
waits were already done here and there in the code but not everywhere, making tests breaking randomly when opening dropdowns
1 parent 1dfd460 commit 7dd0fb5

File tree

6 files changed

+8
-8
lines changed

6 files changed

+8
-8
lines changed

test/nbrowser/CellColor.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -463,7 +463,7 @@ describe('CellColor', function() {
463463
it('should handle correctly default text color', async function() {
464464
// Create new checkbox column
465465
await driver.find('.mod-add-column').click();
466-
await driver.find('.test-new-columns-menu-add-new').click();
466+
await driver.findWait('.test-new-columns-menu-add-new', 100).click();
467467
await gu.waitForServer();
468468
await gu.setType(/Toggle/);
469469

@@ -527,7 +527,7 @@ describe('CellColor', function() {
527527

528528
// create a new checkbox column
529529
await driver.find('.mod-add-column').click();
530-
await driver.find('.test-new-columns-menu-add-new').click();
530+
await driver.findWait('.test-new-columns-menu-add-new', 100).click();
531531

532532
await gu.waitForServer();
533533
await gu.setType(/Toggle/);

test/nbrowser/CustomWidgetsConfig.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,7 @@ describe('CustomWidgetsConfig', function () {
237237
await clickOption('Hidden');
238238

239239
// And make sure widget is rendered.
240-
assert.isTrue(await driver.find('.test-custom-widget-ready').isDisplayed());
240+
assert.isTrue(await driver.findWait('.test-custom-widget-ready', 1000).isDisplayed());
241241

242242
const api = mainSession.createHomeApi();
243243
const revert = await gu.beginAclTran(api, docId);
@@ -297,7 +297,7 @@ describe('CustomWidgetsConfig', function () {
297297
});
298298

299299
// Make sure the widget is now visible.
300-
assert.isTrue(await driver.find('.test-custom-widget-ready').isDisplayed());
300+
assert.isTrue(await driver.findWait('.test-custom-widget-ready', 1000).isDisplayed());
301301

302302
// And we see widget with info about mapped columns, Column to A.
303303
assert.deepEqual(await widget.onRecordsMappings(), {Column: 'A'});

test/nbrowser/DescriptionColumn.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -649,7 +649,7 @@ async function clickAddDescription() {
649649

650650
async function addColumn() {
651651
await driver.find(".mod-add-column").click();
652-
await driver.find('.test-new-columns-menu-add-new').click();
652+
await driver.findWait('.test-new-columns-menu-add-new', 100).click();
653653
await gu.waitForServer();
654654
}
655655

test/nbrowser/Importer.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -325,7 +325,7 @@ describe('Importer', function() {
325325

326326
// Add a new column, with a formula to examine the first.
327327
await gu.openColumnMenu('Birthday', 'Insert column to the right');
328-
await driver.find('.test-new-columns-menu-add-new').click();
328+
await driver.findWait('.test-new-columns-menu-add-new', 100).click();
329329
await gu.waitForServer();
330330
await driver.sendKeys(Key.ESCAPE);
331331
await gu.getCell({col: 2, rowNum: 1}).click();

test/nbrowser/TextEditor.ntest.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ describe('TextEditor.ntest', function() {
133133
async function addColumnRightOf(index) {
134134
// Add a column. We have to hover over the column header first.
135135
await gu.openColumnMenu({col: index}, 'Insert column to the right');
136-
await driver.find('.test-new-columns-menu-add-new').click();
136+
await driver.findWait('.test-new-columns-menu-add-new', 100).click();
137137
await gu.waitForServer();
138138
await gu.sendKeys($.ESCAPE);
139139
}

test/nbrowser/gristUtils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1352,7 +1352,7 @@ export async function addNewPage(
13521352

13531353
// Click the 'Page' entry in the 'Add New' menu
13541354
await driver.findWait('.test-dp-add-new', 2000).doClick();
1355-
await driver.find('.test-dp-add-new-page').doClick();
1355+
await driver.findWait('.test-dp-add-new-page', 2000).doClick();
13561356

13571357
// add widget
13581358
await selectWidget(typeRe, tableRe, options);

0 commit comments

Comments
 (0)