Address linter warnings

Author: timopollmeier

gvm/http/core/_api.py

@@ -27,8 +27,9 @@ def __init__(
             api_key: Optional API key for authentication
         """
 
-        "The connector handling the HTTP(S) connection"
+
         self._connector: HttpApiConnector = connector
+        "The connector handling the HTTP(S) connection"
 
-        "Optional API key for authentication"
         self._api_key: Optional[str] = api_key
+        "Optional API key for authentication"

gvm/http/core/connector.py

@@ -7,7 +7,7 @@
 """
 
 import urllib.parse
-from typing import Optional, Tuple, Dict, Any
+from typing import Any, Dict, Optional, Tuple
 
 from requests import Session
 
@@ -36,8 +36,8 @@ def url_join(cls, base: str, rel_path: str) -> str:
         """
         if base.endswith("/"):
             return urllib.parse.urljoin(base, rel_path)
-        else:
-            return urllib.parse.urljoin(base + "/", rel_path)
+
+        return urllib.parse.urljoin(base + "/", rel_path)
 
     def __init__(
         self,

gvm/http/core/headers.py

@@ -7,7 +7,7 @@
 """
 
 from dataclasses import dataclass
-from typing import Self, Dict, Optional
+from typing import Dict, Optional, Self
 
 
 @dataclass
@@ -45,8 +45,8 @@ def from_string(
         if header_string:
             parts = header_string.split(";")
             media_type = parts[0].strip()
-            for param in parts[1:]:
-                param = param.strip()
+            for part in parts[1:]:
+                param = part.strip()
                 if "=" in param:
                     key, value = map(lambda x: x.strip(), param.split("=", 1))
                     params[key] = value

gvm/http/core/response.py

@@ -7,8 +7,9 @@
 """
 
 from dataclasses import dataclass
-from typing import Any, Dict, Self, Optional
-from requests import Request, Response
+from typing import Any, Dict, Optional, Self
+
+from requests import Response
 
 from gvm.http.core.headers import ContentType
 

gvm/http/openvasd/openvasd1.py

@@ -7,10 +7,9 @@
 """
 
 import urllib.parse
-from typing import Optional, Any
+from typing import Any, Optional
 
 from gvm.errors import InvalidArgumentType
-
 from gvm.http.core._api import GvmHttpApi
 from gvm.http.core.connector import HttpApiConnector
 from gvm.http.core.response import HttpResponse

tests/http/core/test_api.py

@@ -3,7 +3,7 @@
 # SPDX-License-Identifier: GPL-3.0-or-later
 
 import unittest
-from unittest.mock import patch, MagicMock
+from unittest.mock import MagicMock, patch
 
 from gvm.http.core._api import GvmHttpApi
 

tests/http/core/test_connector.py

@@ -4,16 +4,15 @@
 import json
 import unittest
 from http import HTTPStatus
-from typing import Optional, Any
-from unittest.mock import patch, MagicMock, Mock
-from requests.exceptions import HTTPError
+from typing import Any, Optional
+from unittest.mock import MagicMock, Mock, patch
 
-from gvm.http.core.connector import HttpApiConnector
 import requests as requests_lib
+from requests.exceptions import HTTPError
 
+from gvm.http.core.connector import HttpApiConnector
 from gvm.http.core.headers import ContentType
 
-
 TEST_JSON_HEADERS = {
     "content-type": "application/json;charset=utf-8",
     "x-example": "some-test-header",

tests/http/openvasd/test_openvasd1.py

@@ -8,7 +8,6 @@
 from unittest.mock import Mock, patch
 
 from gvm.errors import InvalidArgumentType
-
 from gvm.http.core.headers import ContentType
 from gvm.http.core.response import HttpResponse
 from gvm.http.openvasd.openvasd1 import OpenvasdHttpApiV1